[Bug 262168] New: When adding name, the list should only contain people

https://bugs.kde.org/show_bug.cgi?id=262168

           Summary: When adding name, the list should only contain people
           Product: digikam
           Version: 2.0.0
          Platform: Unlisted Binaries
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Face Detection
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           2.0.0
OS:                Linux

When I add a name to a face, it is nice to have a completion list, but this
list should contain only the tag of people names not all tags.


Reproducible: Always

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=262168





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-01-05 15:07:28 ---
In the beginning, when you had a tag hierarchy from 1.x, there will be no
"people" tags but normal tags for people. You will want to assign them.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=262168





--- Comment #2 from Julien Narboux <Julien narboux fr>  2011-01-05 16:06:18 ---
Maybe the user of Digikam 1.x should be advised to put their people tag under
people ?

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=262168





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-01-06 13:59:57 ---
I did not like to restrict users - there is no requirement any more to put your
people tags under "People". It is suggested, but you can put them anywhere, or
have a flat hierarchy.

I though about only showing people tags but providing autocompletion for all
tags. But that would be "surprising" which is bad for usability.
Any filtering checkbox "Show only people tags" is hard to find space for.
Though, could be done in a context menu.
As an easy solution, we could scroll to and expand the "People" folder, if
there is one.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=262168





--- Comment #4 from Julien Narboux <Julien narboux fr>  2011-01-06 14:25:59 ---
What about a general preference in digikam as a checkbox :
 o Always put people tags under "People"

Then the gui could be simplified:
If the option is checked then you have completion only in the people list and
creation of new tags only under People.
If the option is not checked then the behaviour is the same as a normal tag.

Note that a people tag could be considered different from a normal tag. For
instance people tag could automatically get as a thumbnail one of the faces it
is attached to.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Milan Knizek]

https://bugs.kde.org/show_bug.cgi?id=262168


Milan Knizek <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Milan Knizek <knizek volny cz>  2011-01-08 20:44:17 ---
Agree with #4: Adding an option to general preferences could work.

Users could also be advised to migrate their existing "people" tags to /People
and synchronise database with images (Write to images).

(It is actually my case - I have /family, /friends, /others).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=262168





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2011-01-11 13:05:08 ---
I dont want to impose anything - having a friends/family hierarchy should be
fine.
People tags _are_ treated specially, in some contexts at least. It's rather
easy to make a tag a people tag. So we'll need that option, and maybe a context
menu action to make a tag a people tag.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Simon Bühler]

https://bugs.kde.org/show_bug.cgi?id=262168


Simon Bühler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Simon Bühler <simon aktionspotential de>  2011-02-03 10:18:55 ---
i just want to add that it's irritating when asked in the tag dialog "Who is
this" to be not only presented with the list of Peoples to choose from and a so
a default Assumption to add all Persons to the "Person" Category  would be fine
for the average Beginner User and allowing to opt for a "don't restrict People
Tags to peoples category" would allow advanced users to customize for their
needs.

i believe its good to start with a easy and straightforward default Behaviour
in this case

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=262168


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2011-12-14 13:55:50 ---
Julien,

It still valid using digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from [hidden email] ---
This is still valid in digiKam5.0.0-beta6

(I think this should be added to wishlist)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|2.0.0                       |5.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

Mick Sulley <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Mick Sulley <[hidden email]> ---
In my view this is an essential feature.  I have many event tags, birthdays,
weddings etc, which contain peoples names, these should not be included in the
list when selecting a person tag.  This is still the same in the latest
appimage.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|5.0.0                       |5.3.0

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #11 from Mario Frank <[hidden email]> ---
Created attachment 103441
  --> https://bugs.kde.org/attachment.cgi?id=103441&action=edit
A quick-shot patch

This patch introduces the functionality to filter tags for assigning.
Only face tags are given if configured so. The setup option is located in misc
setup settings. Made small tests. Seems to work.
Can someone test the functionality, too?

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|When adding name, the list  |When adding name, the list
                   |should only contain people  |should only contain people
                   |                            |[patch]

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #12 from [hidden email] ---
Mario,

The patch is fine for me...

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #13 from Mick Sulley <[hidden email]> ---
(In reply to Mario Frank from comment #11)
> Created attachment 103441 [details]
> A quick-shot patch
>
> This patch introduces the functionality to filter tags for assigning.
> Only face tags are given if configured so. The setup option is located in
> misc setup settings. Made small tests. Seems to work.
> Can someone test the functionality, too?

Just tested on 5.4.0 and it does not work for me.  I cannot see a setup option,
where is it?  I looked in Settings > Configure Digikam - Miscellaneous tab, but
there is nothing that refers to tags.
Mick

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #14 from Mario Frank <[hidden email]> ---
(In reply to Mick Sulley from comment #13)

> (In reply to Mario Frank from comment #11)
> > Created attachment 103441 [details]
> > A quick-shot patch
> >
> > This patch introduces the functionality to filter tags for assigning.
> > Only face tags are given if configured so. The setup option is located in
> > misc setup settings. Made small tests. Seems to work.
> > Can someone test the functionality, too?
>
> Just tested on 5.4.0 and it does not work for me.  I cannot see a setup
> option, where is it?  I looked in Settings > Configure Digikam -
> Miscellaneous tab, but there is nothing that refers to tags.
> Mick

Hey Mick,
it is not yet included in the release. I will commit a patch for digiKam 5.5
when I am finished with polishing the code.
As soon as we have that, there will be a beta AppImage where this feature will
be included.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://commits.kde.org/dig
                   |                            |ikam/f11e34f7c376e92d8820c8
                   |                            |1f743a7fdeaaa380a1
             Status|CONFIRMED                   |RESOLVED
   Version Fixed In|                            |5.5.0

--- Comment #15 from Mario Frank <[hidden email]> ---
Git commit f11e34f7c376e92d8820c81f743a7fdeaaa380a1 by Mario Frank.
Committed on 16/01/2017 at 20:20.
Pushed by mfrank into branch 'master'.

This patch introduces the functionality to filter tags for assigning.
Only face tags are given if configured so. The setup option is located in misc
setup settings.

Also, the Unconfirmed face tag now shows the count of contained faces.
Related: bug 336253
FIXED-IN: 5.5.0

M  +3    -1    NEWS
M  +10   -0    app/items/overlays/assignnameoverlay.cpp
M  +3    -0    libs/database/dbjobs/dbjob.cpp
M  +2    -0    libs/settings/applicationsettings.cpp
M  +3    -0    libs/settings/applicationsettings.h
M  +10   -0    libs/settings/applicationsettings_miscs.cpp
M  +3    -0    libs/settings/applicationsettings_p.cpp
M  +3    -0    libs/settings/applicationsettings_p.h
M  +11   -0    utilities/facemanagement/assignnamewidget.cpp
M  +8    -2    utilities/setup/setupmisc.cpp

https://commits.kde.org/digikam/f11e34f7c376e92d8820c81f743a7fdeaaa380a1

--
You are receiving this mail because:
You are the assignee for the bug.

[Simon Frei]

Thanks Mario, that's neat. I would even argue only showing face tags
should be the default.