[Bug 262168] New: When adding name, the list should only contain people

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #16 from Simon <[hidden email]> ---
Thanks Mario, that's neat. I would even argue only showing face tags
should be the default.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #17 from [hidden email] ---
To Mick, comment #10,

The digiKam 5.5.0 test AppImage bundle 64 bits is under upload to GDrive
repository. It will be available in one hour, including patch from this file.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #18 from Mick Sulley <[hidden email]> ---
OK just tested again and it works!!  Still have that odd behaviour of only
getting the drop down suggestions on every other character, but I think that is
covered in another bug.

Great work guys.

Mick

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #19 from Mario Frank <[hidden email]> ---
(In reply to Simon from comment #16)
> Thanks Mario, that's neat. I would even argue only showing face tags
> should be the default.

Hey Simon,
Setting this as default is not yet a good idea. If you want to tag some name
that is a tag but not yet a face tag would not be accomplishable easily. We
need a context menu item in tags sidebar that marks an ordinary tag as face
tag.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #20 from Mario Frank <[hidden email]> ---
Git commit 434b0ee73c9a6bb80eac2b8280e8d86d963bda7c by Mario Frank.
Committed on 17/01/2017 at 09:17.
Pushed by mfrank into branch 'master'.

This commit introduces the possibility to mark tags in tag sidebar as face
tags, if they are not already face tags.
Meaning, when one tag is selected and is no face tag, the context menu for it
contains an properties action to set this
tag as face tag. If multiple tags are selected, the context menu contains the
action to mark them as face tags if at
least one of the selected tags is no face tag.

The default option for filtering names for confirmation in people sidebar is
set to true. Meaning, by default,
the suggested tags in line edit and tag tree are filtered to only be face tags.
The option can be unset in setup->misc->Show only face tags ... .

M  +20   -0    app/utils/contextmenuhelper.cpp
M  +6    -0    app/utils/contextmenuhelper.h
M  +1    -1    libs/settings/applicationsettings.cpp
M  +18   -1    libs/tags/tagfolderview.cpp
M  +34   -0    libs/tags/tagmodificationhelper.cpp
M  +24   -0    libs/tags/tagmodificationhelper.h

https://commits.kde.org/digikam/434b0ee73c9a6bb80eac2b8280e8d86d963bda7c

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=262168

--- Comment #21 from Mario Frank <[hidden email]> ---
(In reply to Mario Frank from comment #19)
> (In reply to Simon from comment #16)
> > Thanks Mario, that's neat. I would even argue only showing face tags
> > should be the default.
>
> Hey Simon,
> Setting this as default is not yet a good idea. If you want to tag some name
> that is a tag but not yet a face tag would not be accomplishable easily. We
> need a context menu item in tags sidebar that marks an ordinary tag as face
> tag.

Done

--
You are receiving this mail because:
You are the assignee for the bug.