[Bug 261568] New: Scale action icons with thumbnail size

[todd rme]

https://bugs.kde.org/show_bug.cgi?id=261568

           Summary: Scale action icons with thumbnail size
           Product: digikam
           Version: 1.7.0
          Platform: openSUSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.7.0 (using KDE 4.5.90)
OS:                Linux

Digikam has certain actions you can do when you put your mouse over a thumbnail
in the picture list view.  These include selecting/deselecting the picture,
rotating it clockwise, or rotating it counterclockwise.  

However, these icons are always the same size.  When the thumbnails are small,
the icons are small, which makes sense.  However, when the thumbnails are large
the icons stay small, giving them a really small hit target relative to the
size of the thumbnail.  Dolphin has a similar icon, but rescales it, to an
extent, with the size of the picture.  I think this would be helpful and would
make the icons more useful in digikam as well.

Reproducible: Always

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-12-29 22:14:55 ---
It's a strange behavior. I never see it. Can you take screen-shots as example
please ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[todd rme]

https://bugs.kde.org/show_bug.cgi?id=261568





--- Comment #2 from Todd <toddrme2178 gmail com>  2010-12-29 23:25:12 ---
Created an attachment (id=55362)
 --> (http://bugs.kde.org/attachment.cgi?id=55362)
Comparison of icon scaling in digikam and dolphin

Screenshots of Dolphin and Digikam showing the issue.  The import part is the
"+" icon near the upper-right corner for both Dolphin and Digikam and the
rotate left and rotate right icons to the right of the "+" icon in Digikam.

The left two screenshots show the what you get in each program when the
thumbnail is very small, the right when the icon is very large.  

Notice that for Dolphin (top two pictures), in the left picture the "+" icon is
small while in the right picture the "+" icon is large.  

However, for digikam (bottom two pictures), in the left picture and right
picture the "+" icons are the same size, as are the rotate left and rotate
right pictures.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=261568





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-12-29 23:44:38 ---
Maybe you need KDE 4.5, but it's a known feature of dolphin, easy to test. I
heard Peter Penz talk about it, I think it was requested by users.
Personally, I have a feeling that sometimes the icons get a bit too large for a
good visual impression, visually I'd prefer smaller ones, or only two steps,
like 16+22. But yes, it is technically possible.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Thumbnails




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2011-12-13 10:06:34 ---
It still valid with KDE 4.7.x and digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[todd rme]

https://bugs.kde.org/show_bug.cgi?id=261568





--- Comment #5 from Todd <toddrme2178 gmail com>  2011-12-18 10:00:28 ---
Yes, it is.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Scale action icons with     |Scale overlay action icons
                   |thumbnail size              |accordingly with thumbnail
                   |                            |size

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Scale overlay action icons  |ICONVIEW : scale overlay
                   |accordingly with thumbnail  |action icons accordingly
                   |size                        |with thumb size

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568

--- Comment #6 from Gilles Caulier <[hidden email]> ---
Maik,

I partially identified in source code where icon size are hard-coded :

https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/itemview/itemviewhoverbutton.cpp#L160

Into digikam 4, icons size is set to KIconLoader::Desktop, into digikam 5 it's
48.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=261568

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Maik Qualmann <[hidden email]> ---
Created attachment 94343
  --> https://bugs.kde.org/attachment.cgi?id=94343&action=edit
iconsize.patch

This is a first patch for viewing and testing. Changes to the import view
contains not the patch.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=261568

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|ICONVIEW : scale overlay    |ICONVIEW : scale overlay
                   |action icons accordingly    |action icons accordingly
                   |with thumb size             |with thumb size [patch]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568

--- Comment #8 from Gilles Caulier <[hidden email]> ---
Maik,

The patch work very well. Congratulations.

Note : it cannot be applied now to git/master. 4.13.0 release will be tarballed
this evening by Nicolas Lécureuil. Please delay this patch and future one for
4.14.0 release.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=261568

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #94343|0                           |1
        is obsolete|                            |

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=261568

--- Comment #9 from Maik Qualmann <[hidden email]> ---
Created attachment 94422
  --> https://bugs.kde.org/attachment.cgi?id=94422&action=edit
iconsize2.patch

Final version of the patch to commit.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=261568

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/99648053a70455f1c99ca71
                   |                            |5ccbcc9851d02509a
   Version Fixed In|                            |4.14.0
         Resolution|---                         |FIXED

--- Comment #10 from Maik Qualmann <[hidden email]> ---
Git commit 99648053a70455f1c99ca715ccbcc9851d02509a by Maik Qualmann.
Committed on 06/09/2015 at 06:52.
Pushed by mqualmann into branch 'master'.

apply patch #94422 to scale the overlay action icons accordingly with thumb
size
FIXED-IN: 4.14.0

M  +3    -2    NEWS
M  +6    -4    app/items/overlays/imagerotationoverlay.cpp
M  +4    -2    app/items/overlays/imageselectionoverlay.cpp
M  +6    -5    libs/widgets/itemview/itemviewhoverbutton.cpp
M  +6    -4    utilities/importui/items/importoverlays.cpp

http://commits.kde.org/digikam/99648053a70455f1c99ca715ccbcc9851d02509a

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568

--- Comment #11 from Gilles Caulier <[hidden email]> ---
Git commit 5f2bf2fa336bf7afa966587635591f0446a74b5f by Gilles Caulier.
Committed on 06/09/2015 at 08:57.
Pushed by cgilles into branch 'frameworks'.

backport commit #99648053a70455f1c99ca715ccbcc9851d02509a from git/master to
frameworks branch

M  +4    -2    app/items/overlays/imagerotationoverlay.cpp
M  +3    -1    app/items/overlays/imageselectionoverlay.cpp
M  +6    -6    libs/widgets/itemview/itemviewhoverbutton.cpp
M  +4    -2    utilities/importui/items/importoverlays.cpp

http://commits.kde.org/digikam/5f2bf2fa336bf7afa966587635591f0446a74b5f

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568

--- Comment #12 from Gilles Caulier <[hidden email]> ---
Git commit ea4241cd87bcb347026975338cc3bbeda4cb9da2 by Gilles Caulier.
Committed on 06/09/2015 at 09:13.
Pushed by cgilles into branch 'master'.

adjust face rejection overlay icon size to be dynamic with thumbnail size

M  +8    -6    app/items/overlays/facerejectionoverlay.cpp
M  +2    -2    app/items/overlays/facerejectionoverlay.h

http://commits.kde.org/digikam/ea4241cd87bcb347026975338cc3bbeda4cb9da2

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568

--- Comment #13 from Gilles Caulier <[hidden email]> ---
Git commit c7833dfc57e49fc48c26fb0605d77859f7126afd by Gilles Caulier.
Committed on 06/09/2015 at 09:16.
Pushed by cgilles into branch 'frameworks'.

backport commit #ea4241cd87bcb347026975338cc3bbeda4cb9da2 from git/master to
frameworks branch

M  +8    -6    app/items/overlays/facerejectionoverlay.cpp
M  +2    -2    app/items/overlays/facerejectionoverlay.h

http://commits.kde.org/digikam/c7833dfc57e49fc48c26fb0605d77859f7126afd

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261568

--- Comment #14 from Gilles Caulier <[hidden email]> ---
Maik,

It miss something to patch : image coordinates overlay to draw world map icon
over thumbnail with image has GPS info. Icon is show on top/right corner when
right option is enabled on Setup/AlbumView panel.

The code relevant is a little bit different. There is an overlay implementation
(imagecoordinateoverlay.cpp) but this one do not draw icon. It's done in image
delegate implementation :

updateRects() from delegates calculate the rectangle d->coordinatesRect to host
world map icon.

paint() from delegates call drawGeolocationIndicator() if image has GPS info.

ItemViewImageDelegate::drawGeolocationIndicator(),
ItemViewImportDelegate::drawGeolocationIndicator(),
ItemViewShowfotoDelegate::drawGeolocationIndicator()
are re-implemented to do the job.

This is implemented for album icon view, import icon view and showfoto
thumb-bar.

Gilles

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Maik Qualmann]

https://bugs.kde.org/show_bug.cgi?id=261568

--- Comment #15 from Maik Qualmann <[hidden email]> ---
Git commit 3b82901ee4948b4316ab3b194ba30ddbb0804677 by Maik Qualmann.
Committed on 08/09/2015 at 17:42.
Pushed by mqualmann into branch 'master'.

info icons over thumbnails now scaled

M  +2    -2    app/items/digikamimagedelegate.cpp
M  +3    -2    app/items/imagethumbnaildelegate.cpp
M  +2    -2    libs/widgets/itemview/itemviewimagedelegate.cpp
M  +2    -2    utilities/importui/items/importdelegate.cpp
M  +5    -5    utilities/importui/items/itemviewimportdelegate.cpp

http://commits.kde.org/digikam/3b82901ee4948b4316ab3b194ba30ddbb0804677

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel