[Bug 261417] New: duplicate image counter is not adjusted when removing a duplicate

https://bugs.kde.org/show_bug.cgi?id=261417

           Summary: duplicate image counter is not adjusted when removing
                    a duplicate
           Product: digikam
           Version: 1.6.0
          Platform: Fedora RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: minor
          Priority: NOR
         Component: Fuzzy Searches
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.6.0 (using KDE 4.5.4)
OS:                Linux

When going over the duplicates and deleting a duplicate, the "Items" counter is
not adjusted. You really need to "Find duplicates" again to get an updated list
of duplicates.

Reproducible: Always

Steps to Reproduce:
1. set up some duplicate images (e.g. by copying a folder and importing it)
2. generate/update the fingerprints
3. search for duplicates
4. look at the results
5. delete one of the duplicates


Actual Results:  
the number of "items" is not adjusted, which seems to indicate that the
duplicate still exists.

Expected Results:  
The number of "Items" to be adjusted. If the number is 1, the whole entry
should not be shown anymore (automatically selecting the next entry).

OS: Linux (x86_64) release 2.6.35.9-64.fc14.x86_64
Compiler: gcc

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261417


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-14 16:37:19 ---
Eric,

It still valid with digiKam 2.x serie ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=261417

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|duplicate image counter is  |Duplicate image counter is
                   |not adjusted when removing  |not adjusted when removing
                   |a duplicate                 |a duplicate

--- Comment #2 from Gilles Caulier <[hidden email]> ---
Eric,

This file still valid using last digiKam 4.2.0 ?

Gilles Cauleir

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|minor                       |normal

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.6.0                       |5.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
     Ever confirmed|0                           |1

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

Mario Frank <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from Mario Frank <[hidden email]> ---
I can confirm that one both in 5.3 and master branch. I looked at the code on
the weekend. It seems like the deletion is not communicated to the TreeView
since I found no Signal/Slot-communication concerning this one. I will take a
deeper look at it and try to fix that when I have some time.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #4 from Mario Frank <[hidden email]> ---
Created attachment 102157
  --> https://bugs.kde.org/attachment.cgi?id=102157&action=edit
Patch for the bug.

Tested this patch. Seems to work quite well. Please review it.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

Maik Qualmann <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #5 from Maik Qualmann <[hidden email]> ---
Thanks for the patch Mario. Delete to trash over right click on context menu
does not work here. The Item counter remains the same. Del key works. I'll look
at it tomorrow.

Maik

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #6 from Mario Frank <[hidden email]> ---
Hey, I just tested again. Deleting multiple pictures (selection) at the same
time
does not work properly, too. The counter is only decremented by 1, not by the
count of deleted images. Seems that the signal imagedeleted is only emitted
once even if multiple images are deleted. I can take a look at the code again
and try to fix both problems.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #7 from [hidden email] ---
I can't check the patch actually but I suspect that you fired a signal from
icon view item context menu to duplicates list view to decrease count of items.
This is not the right way. You must fired a signal to database iOS job to
refresh search album for duplicates. This will update properties the virtual
album in database.

THE process is similar that to refresh all duplicates virtual album from button
on left sidebar, but it must only to be processed on current selected
duplicates virtual search album.

Gilles caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #8 from Mario Frank <[hidden email]> ---
Okay. In fact I fired a signal to the AlbumManager and then to the
FindDuplicatesView. I will take a look at the problem more closely.
Is there an overview concerning wirings? And is there an UI definition that can
be used in QTDesigner to get an overview of which component is used in which
scope?

Cheers,
Mario

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #9 from [hidden email] ---
What d'où mean by wiring ?
About qtdesigner : no definition exists yet, because we use mostly Kate editor

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

Simon <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Simon <[hidden email]> ---
I just discovered that there is also an issue with the duplicate count
ordering. It is done lexicographically not mathematically (e.g. 10 is before
2). I thought this is probably related, if I should open a separate bug, please
say so.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #11 from Mario Frank <[hidden email]> ---
I do not know how the developers opinions are. But I think what you see is part
of the problem described in bug 372217 . I already adressed the lexicographical
ordering of the simmilarity. I will provide a patch for your problem at the
site for bug 372217.

Cheers,
Mario

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #12 from [hidden email] ---
yes a separate file will be fine...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #13 from Mario Frank <[hidden email]> ---
Hey Gilles,
by the wiring (of components), I mean the connection of signals to slots. The
lack on information about which class is the correct view in which situation
makes it complicated for me to get find out where to set a hook and trigger
specific updates. Is there some dev documentation going into the details of the
implementation?

Hey Simon,

I can open a bug then and submit the patch.

Cheers,
Mario

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #14 from [hidden email] ---
A good start is to explore the DigiKam namespace and the doxygen documentation
relevant.

https://api.kde.org/extragear-api/graphics-apidocs/digikam/html/namespaceDigikam.html

The class names are identical than cpp file names everywhere.

Each classes are hosted in subdirectory by functions, as image container,
database interface, filters, widgets, etc...

Please give me more info about what you search exactly in source code.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #15 from Mario Frank <[hidden email]> ---
Hey Gilles,
there are obviously 3 ways to delete an image:
1 pressing the delete key
2 klicking the right mouse button on the image and move to trash
3 moving to trash with the main menu (entry->move to trash)
The variant 1 seems to trigger variant 3 since it is a shortcut.
There is a signal from stackedView to DigikamView (imageDeleted) that
works for Variant 1 and 3 but not for variant 2.

What I am looking for is the spot where I can catch all three variant events.

Moreover, I am not sure what you mean with the database iOS job. I did not find
any definition comparable.

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=261417

--- Comment #16 from [hidden email] ---
>there are obviously 3 ways to delete an image:
>1 pressing the delete key
>2 klicking the right mouse button on the image and move to trash
>3 moving to trash with the main menu (entry->move to trash)
>The variant 1 seems to trigger variant 3 since it is a shortcut.

yes it is.

>There is a signal from stackedView to DigikamView (imageDeleted) that
>works for Variant 1 and 3 but not for variant 2.

exact. In this case, the contextual menu is managed by a common class :

https://quickgit.kde.org/?p=digikam.git&a=blob&f=app%2Futils%2Fcontextmenuhelper.cpp

Look this method :

void ContextMenuHelper::addStandardActionItemDelete(QObject* recv, const char*
slot, int quantity)

... which permit to plug an action to the menu to delete and item from icon
view.

Moreover, I am not sure what you mean with the database iOS job. I did not find
any definition comparable.

Since 5.0.0, we have drop all KIOSlave and replaced by 2 multithreaded
interfaces, one for file management (rename, copy, delete, etc...), and one to
query the database. The last one is located here :

https://quickgit.kde.org/?p=digikam.git&a=blob&f=libs%2Fdatabase%2Fdbjobs%2Fdbjob.cpp

Look class SearchesJob which will manage all background Duplicates search
queries in database.

Typically, at end, when you process a duplicates search album to get result,
this DBJob is called.

Typically, to refresh one duplicates search album, you must to call this DBJob
to process iface.rebuildDuplicatesAlbums() with right arguments to only handle
albums where you have removed duplicates items (from icon-view your can remove
more than one at the same time...)

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.