[Bug 259223] New: [RFC][PATCH] Overexposure prevention in white balance tool

[pochini]

https://bugs.kde.org/show_bug.cgi?id=259223

           Summary: [RFC][PATCH] Overexposure prevention in white balance
                    tool
           Product: digikam
           Version: 1.6.0
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Created an attachment (id=54305)
 --> (http://bugs.kde.org/attachment.cgi?id=54305)
avoid overesposure in white balance

Version:           1.6.0 (using KDE 4.4.3)
OS:                Linux

The white balance tool has a big problem in its current form: almost always it
overexposes and clips at least one of the rgb components. The exposure
compensation thing does not help here because it is applied on the already
clipped image.
I wrote a simple proof-of-concept patch (attached) that makes the wb tool
useable by scaling down the rgb multipiers just enough to prevent clipping.
The biggest problem with my patch is that the final image can be quite a lot
dimmer than the preview image because the scaler smooths the (usually tiny)
brightest spots of the photo.


Reproducible: Sometimes

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=259223


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Image Editor                |White Balance
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[pochini]

https://bugs.kde.org/show_bug.cgi?id=259223


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54305|0                           |1
        is obsolete|                            |




--- Comment #1 from  <pochini shiny it>  2010-12-12 15:13:05 ---
Created an attachment (id=54459)
 --> (http://bugs.kde.org/attachment.cgi?id=54459)
Prevent overexposure in WB tool

I prepared a better patch. This one is against the latest svn version, works in
both 8 and 16 bits mode and it follows the coding style.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=259223





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-12-13 08:50:44 ---
Thanks Pochini. I will review your patch soon...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=259223


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[RFC][PATCH] Overexposure   |Overexposure prevention in
                   |prevention in white balance |white balance tool [patch]
                   |tool                        |




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2011-11-10 10:30:33 ---
Pochini,

Do you have an updated version of your patch working with 2.x code from
git/master repository ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[pochini]

https://bugs.kde.org/show_bug.cgi?id=259223





--- Comment #4 from  <pochini shiny it>  2011-11-13 23:04:59 ---
Created an attachment (id=65631)
 --> (http://bugs.kde.org/attachment.cgi?id=65631)
Prevent overexposure in the white balance tool

Yes, the patch is attached. It applies cleanly to any v2.x .

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=259223


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #54459|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=259223


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2011-11-14 13:50:24 ---
Git commit 86f103b771a9bdcc1a80f16e6f2a57c648ed5bc1 by Gilles Caulier.
Committed on 14/11/2011 at 14:47.
Pushed by cgilles into branch 'master'.

Apply patch #65631 to prevent Overexposure with Withe Balance adjustement.
Modify patch to always compute RGB multipliers over original image in case of
preview rendering in image editor.
Use more private internal container plus code polish
BUGS: 259223

M  +3    -0    imageplugins/color/whitebalancetool.cpp
M  +13   -4    libs/dimg/filters/wb/wbcontainer.h
M  +103  -25   libs/dimg/filters/wb/wbfilter.cpp
M  +17   -5    libs/dimg/filters/wb/wbfilter.h
M  +12   -13   libs/dimg/filters/wb/wbsettings.cpp
M  +2    -3    libs/dimg/filters/wb/wbsettings.h

http://commits.kde.org/digikam/86f103b771a9bdcc1a80f16e6f2a57c648ed5bc1

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=259223

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.4.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=259223

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|White Balance               |Tool-WhiteBalance
            Product|digikamimageplugins         |digikam

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel