[Bug 241847] New: Possibility to pre-mark images for deletion

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2011-02-15 19:14:46 ---
Git commit a3b85376c37ffe1c6597ac9b615fcba0d1822674 by Gilles Caulier.
Committed on 15/02/2011 at 19:10.
Pushed by cgilles into branch 'development/2.0'.

Add Pick Label menu entry in all Context menu.
Manage Pick Label Tags Keyboard Shortcuts in manager: Keys are :

ALT+CTRL+0 => No Pick Label Assigned.
ALT+CTRL+1 => Item Rejected.
ALT+CTRL+2 => Item in Pending validation.
ALT+CTRL+3 => Item Accepted and valided.

CCBUGS: 241847

M  +10   -0    digikam/contextmenuhelper.cpp    
M  +15   -0    digikam/contextmenuhelper.h    
M  +14   -0    digikam/digikamimageview.cpp    
M  +2    -0    digikam/digikamimageview.h    
M  +6    -1    digikam/digikamview.cpp    
M  +1    -0    digikam/digikamview.h    
M  +9    -0    digikam/imagepreviewview.cpp    
M  +1    -0    digikam/imagepreviewview.h    
M  +53   -1    digikam/metadatamanager.cpp    
M  +3    -0    digikam/metadatamanager.h    
M  +6    -0    digikam/metadatamanager_p.h    
M  +63   -0    digikam/tags/tagsactionmngr.cpp    
M  +3    -1    digikam/tags/tagsactionmngr.h    
M  +27   -0    utilities/imageeditor/editor/imagewindow.cpp    
M  +2    -0    utilities/imageeditor/editor/imagewindow.h    
M  +42   -0    utilities/lighttable/lighttablebar.cpp    
M  +2    -0    utilities/lighttable/lighttablebar.h    
M  +16   -0    utilities/lighttable/lighttablepreview.cpp    
M  +1    -0    utilities/lighttable/lighttablepreview.h    
M  +5    -0    utilities/lighttable/lighttablewindow.cpp    
M  +1    -0    utilities/lighttable/lighttablewindow.h    

http://commits.kde.org/digikam/a3b85376c37ffe1c6597ac9b615fcba0d1822674

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #20 from Gilles Caulier <caulier gilles gmail com>  2011-02-15 19:23:30 ---
Git commit 52a729369dbf16a079b17faed7fc91cff137a0f0 by Gilles Caulier.
Committed on 15/02/2011 at 19:20.
Pushed by cgilles into branch 'development/2.0'.

Assign Pick Label when items are scanned
Write Pick Label to file metadata is right option is turn on into First Run
Assistant.
CCBUGS: 241847

M  +20   -1    libs/database/imagescanner.cpp    
M  +1    -0    utilities/firstrun/metadatapage.cpp    

http://commits.kde.org/digikam/52a729369dbf16a079b17faed7fc91cff137a0f0

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #21 from Gilles Caulier <caulier gilles gmail com>  2011-02-15 19:34:27 ---
Emile I CC you for info. Pick Label support start to be implmented, and I need
feedback.

Look my previous posts in this file.

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2011-02-15 19:35:22 ---
Julien,

Same for you, please take a look to Pick Label feature and give me a feedback

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #23 from Gilles Caulier <caulier gilles gmail com>  2011-02-16 09:55:11 ---
Git commit 042fb4b0acc9faf29742202062115f4377ce9a6f by Gilles Caulier.
Committed on 16/02/2011 at 09:53.
Pushed by cgilles into branch 'development/2.0'.

Show Pick Label Information into image properties view
CCBUGS: 241847

M  +1    -0    libs/imageproperties/imagepropertiessidebardb.cpp    
M  +24   -20   libs/imageproperties/imagepropertiestab.cpp    
M  +1    -0    libs/imageproperties/imagepropertiestab.h    

http://commits.kde.org/digikam/042fb4b0acc9faf29742202062115f4377ce9a6f

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2011-02-16 10:34:11 ---
Git commit 5b018944b75baed21f770d1f41cfedbcd0f687b7 by Gilles Caulier.
Committed on 16/02/2011 at 10:32.
Pushed by cgilles into branch 'development/2.0'.

Show Pick Label in item tooltip.
CCBUGS: 241847

M  +5    -3    digikam/tooltipfiller.cpp    
M  +7    -7    utilities/setup/setuptooltip.cpp    

http://commits.kde.org/digikam/5b018944b75baed21f770d1f41cfedbcd0f687b7

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2011-02-16 12:00:06 ---
Git commit 9bbc1a9755369fa276b7c2c0fdf80e251babb63a by Gilles Caulier.
Committed on 16/02/2011 at 11:57.
Pushed by cgilles into branch 'development/2.0'.

Pick Label icon-biew filter is implemented and fully suitable.

CCBUGS: 241847

M  +5    -0    digikam/albumiconviewfilter.cpp    
M  +2    -2    digikam/digikamview.cpp    
M  +36   -5    digikam/tagfiltersidebarwidget.cpp    
M  +6    -4    digikam/tagfiltersidebarwidget.h    
M  +2    -2    libs/models/imagefiltermodel.cpp    
M  +1    -1    libs/models/imagefiltermodel.h    
M  +35   -5    libs/models/imagefiltersettings.cpp    
M  +5    -2    libs/models/imagefiltersettings.h    

http://commits.kde.org/digikam/9bbc1a9755369fa276b7c2c0fdf80e251babb63a

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #25 from Gilles Caulier <caulier gilles gmail com>  2011-02-16 12:00:06 ---
Git commit 9bbc1a9755369fa276b7c2c0fdf80e251babb63a by Gilles Caulier.
Committed on 16/02/2011 at 11:57.
Pushed by cgilles into branch 'development/2.0'.

Pick Label icon-biew filter is implemented and fully suitable.

CCBUGS: 241847

M  +5    -0    digikam/albumiconviewfilter.cpp    
M  +2    -2    digikam/digikamview.cpp    
M  +36   -5    digikam/tagfiltersidebarwidget.cpp    
M  +6    -4    digikam/tagfiltersidebarwidget.h    
M  +2    -2    libs/models/imagefiltermodel.cpp    
M  +1    -1    libs/models/imagefiltermodel.h    
M  +35   -5    libs/models/imagefiltersettings.cpp    
M  +5    -2    libs/models/imagefiltersettings.h    

http://commits.kde.org/digikam/9bbc1a9755369fa276b7c2c0fdf80e251babb63a

--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2011-02-16 12:00:06 ---
Git commit 2c8cc82feff3324c4efdffc8b6c07697da96c820 by Gilles Caulier.
Committed on 16/02/2011 at 11:19.
Pushed by cgilles into branch 'development/2.0'.

add new widget to filter by Pick Label
CCBUGS: 241847

M  +5    -2    CMakeLists.txt    
A  +81   -0    digikam/tags/picklabelfilter.cpp         [License: GPL (v2+)]
A  +65   -0    digikam/tags/picklabelfilter.h         [License: GPL (v2+)]

http://commits.kde.org/digikam/2c8cc82feff3324c4efdffc8b6c07697da96c820

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #27 from Gilles Caulier <caulier gilles gmail com>  2011-02-16 12:59:09 ---
Git commit 91a71c0e48780b572ea0c8320c96af6d1a9e8f90 by Gilles Caulier.
Committed on 16/02/2011 at 12:49.
Pushed by cgilles into branch 'development/2.0'.

Move Rating filter from statusbar to Tags Filter view from right sidebar.
As Rating is considerated as a Labels (like Pick or Color), it need to be moved
near Pick/Color Label filters.

Note that i plan to move all filters from status bar to right Sidebar and
rename "Tag Filters" as "Filters", and to add
2 buttons on status bar :
"Reset" to clean all active filters
"Settings" (or something like that) to switch on "Filters" panel from right
sidebar.

The advantage to use "Filters" panel from right side bar is to be able to host
more filters in the future.
Status bar is limited in space to host more settings. There are a lots of
whishes about this subject in bugzilla.

CCBUGS: 241847

M  +6    -32   digikam/albumiconviewfilter.cpp    
M  +2    -5    digikam/albumiconviewfilter.h    
M  +0    -6    digikam/digikamapp.cpp    
M  +5    -5    digikam/digikamview.cpp    
M  +18   -2    digikam/tagfiltersidebarwidget.cpp    
M  +5    -2    digikam/tagfiltersidebarwidget.h    
M  +1    -0    digikam/tags/colorlabelfilter.cpp    
M  +1    -0    digikam/tags/picklabelfilter.cpp    
M  +7    -7    libs/imageproperties/imagedescedittab.cpp    
M  +12   -2    libs/models/imagefiltersettings.cpp    
M  +3    -1    libs/models/imagefiltersettings.h    

http://commits.kde.org/digikam/91a71c0e48780b572ea0c8320c96af6d1a9e8f90

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #28 from Gilles Caulier <caulier gilles gmail com>  2011-02-16 14:52:49 ---
Git commit 3b5292497bb81a7e6b7153d5c8c046791bce54c8 by Gilles Caulier.
Committed on 16/02/2011 at 14:49.
Pushed by cgilles into branch 'development/2.0'.

Implement fully suitable Pick Labels Search option in Advanced Search tool.
Marcel, look my comment into SearchFieldAlbum::read() method about to ignore
internal tags with Tags search widget.
BUGS: 241847

M  +4    -2    digikam/tagfiltersidebarwidget.cpp    
M  +6    -6    libs/database/tagscache.cpp    
M  +4    -4    libs/database/tagscache.h    
M  +58   -24   utilities/searchwindow/searchfields.cpp    
M  +4    -2    utilities/searchwindow/searchfields.h    
M  +1    -1    utilities/searchwindow/searchgroup.cpp    

http://commits.kde.org/digikam/3b5292497bb81a7e6b7153d5c8c046791bce54c8

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #29 from Julien Narboux <Julien narboux fr>  2011-02-18 13:13:12 ---
Gilles,

Sorry for not giving feedback earlier I am very busy these days and I have
digikam git version only on one of my computers.
Your implementation of color labels and pick labels is very nice. I like the
choice of the colors and the icons. I think the widget to assign labels and to
filter labels are very nice. I like the fact that you can easily see the
shortcuts for color labels and pick labels in the context menu.

Small bugs:

1/The shortcuts for stars are missing in the context menu.

2/In preview mode, using the context menu if you try to assign a pick label you
get a color label instead. If you use the context menu of the thumbnail view or
the sidebar it works fine.

3/In the context menu, in the recently assigned tags menu you can see the color
labels and pick labels; I think it should not be the case.


Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #30 from Gilles Caulier <caulier gilles gmail com>  2011-02-18 13:30:47 ---
Thanks Julien to review my code...

1/ The shortcuts appears when you click on start. Yes it's a little bit
different than color/Pick Labels behavior...

2/ fixed with commit
http://commits.kde.org/digikam/078c9e4a1442351e1b855deef83a7cba0005b20a

3/ Right. It must ignore internal DB tags.

Please take a look to:

1/ album icon view Filters where Pick and Color Labels have been added.
2/ Advanced Search tool where Pick and Color Labels have been added.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847





--- Comment #31 from Gilles Caulier <caulier gilles gmail com>  2011-02-18 14:04:37 ---
Julien,

3/ is fixed with this commit :
http://commits.kde.org/digikam/ab662d4b52961671b06a331a54e28e766aa97c86

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=241847

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=241847

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Workflow                    |Tags-Pick

--
You are receiving this mail because:
You are the assignee for the bug.