digiKam › digikam-devel

[Bug 237010] New: Remove DATE and TIME from code

Classic

List

10 messages Options

Options

Bugzilla from cmorve69@yahoo.es

[Bug 237010] New: Remove DATE and TIME from code

https://bugs.kde.org/show_bug.cgi?id=237010

Summary: Remove __DATE__ and __TIME__ from code
Product: digikam
Version: 1.2.0
Platform: openSUSE RPMs
OS/Version: unspecified
Status: UNCONFIRMED
Severity: wishlist
Priority: NOR
Component: general
AssignedTo: [hidden email]
ReportedBy: [hidden email]

Version: 1.2.0 (using KDE 4.4.3)
Installed from: openSUSE RPMs

libs/3rdparty/cimg/CImg.h and digikam/version.h.cmake have __DATE__ and
__TIME__ entries that make a build irreproducible.

Be reproducible is something good because of a lot of causes. But in openSUSE
it also means each time Digikam is rebuilt (because of a change in a
dependency) we can detect if the new build has differences with the old one and
only make users redownload Digikam if it's really needed.

The one at digikam/version.h.cmake has the extra problem of being
internationalizes, making it extra difficult to remove it with a local patch.
Notice also that the about dialog gets "Build date" translated but the date
itself isn't, so IMHO it's best to just remove the build date.

If you really want the build time I would like at least a cmake option to
disable it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from cmorve69@yahoo.es

[Bug 237010] Remove DATE and TIME from code

https://bugs.kde.org/show_bug.cgi?id=237010

--- Comment #1 from Christian Morales Vega <cmorve69 yahoo es> 2010-05-10 22:37:57 ---
Exactly the same thing applies to kipi-plugins 1.2.0 with the file
common/libkipiplugins/tools/kpaboutdata.cpp

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bug 237010] Remove DATE and TIME from code

In reply to this post by Bugzilla from cmorve69@yahoo.es

https://bugs.kde.org/show_bug.cgi?id=237010

--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de> 2011-01-26 12:30:12 ---
If you already have a local patch, preferably with a CMake option, please
attach...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[Bug 237010] Remove DATE and TIME from code

In reply to this post by Bugzilla from cmorve69@yahoo.es

https://bugs.kde.org/show_bug.cgi?id=237010

--- Comment #3 from Gilles Caulier <caulier gilles gmail com> 2011-12-13 09:42:53 ---
Christian, do you see comment #2 from Marcel ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Bugzilla from cmorve69@yahoo.es

[Bug 237010] Remove DATE and TIME from code

In reply to this post by Bugzilla from cmorve69@yahoo.es

https://bugs.kde.org/show_bug.cgi?id=237010

--- Comment #4 from Christian Morales Vega <cmorve69 yahoo es> 2011-12-13 10:20:18 ---
Has been quite a long time since I touched that package. But right now openSUSE
is using this patch:

https://build.opensuse.org/package/view_file?file=digikam-buildtime.patch&package=digikam&project=KDE%3ADistro%3AFactory&rev=ed32de9cfa5637640a0418f8eec08a87

and this in the .spec file

# Remove build time references so build-compare can do its work
FAKE_BUILDDATE=$(LC_ALL=C date -u -r %{_sourcedir}/%{name}.changes '+%%b %%e
%%Y')
sed -i "s/__DATE__/\"$FAKE_BUILDDATE\"/" core/digikam/utils/version.h.cmake

In general we have started to use the sed trick since it avoids problems when
someone is parsing the output and expects to find the date. So it's not such a
big deal for us anymore. Feel free to close the bug if you want to.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Bug 237010] Remove DATE and TIME from code

In reply to this post by Bugzilla from cmorve69@yahoo.es

https://bugs.kde.org/show_bug.cgi?id=237010

--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de> 2011-12-24 16:59:45 ---
I could think of a CMake option to provide this date, if there is interest

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[Bug 237010] Remove DATE and TIME from code

In reply to this post by Bugzilla from cmorve69@yahoo.es

https://bugs.kde.org/show_bug.cgi?id=237010

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |[hidden email]

--- Comment #6 from Gilles Caulier <caulier gilles gmail com> 2011-12-24 21:52:55 ---
Marcel,

+1 for me for a pure Cmake option.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 237010] Remove DATE and TIME from code

In reply to this post by Bugzilla from cmorve69@yahoo.es

https://bugs.kde.org/show_bug.cgi?id=237010

--- Comment #7 from Gilles Caulier <[hidden email]> ---
Christian,

Do you find any solution based on CMake as Marcel explain in comment #5.

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

Gilles Caulier-4

[digikam] [Bug 237010] Remove DATE and TIME from code

In reply to this post by Bugzilla from cmorve69@yahoo.es

https://bugs.kde.org/show_bug.cgi?id=237010

Gilles Caulier <[hidden email]> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DOWNSTREAM
Status|UNCONFIRMED |RESOLVED

--- Comment #8 from Gilles Caulier <[hidden email]> ---
As proposed in comment #5, i close this file as DOWNSTREAM now...

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

bugzilla_noreply

[digikam] [Bug 237010] Remove DATE and TIME from code

In reply to this post by Bugzilla from cmorve69@yahoo.es

https://bugs.kde.org/show_bug.cgi?id=237010

[hidden email] changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|general |Portability

--
You are receiving this mail because:
You are the assignee for the bug.