[Bug 235601] New: Local contrast plugin preview is wrong

https://bugs.kde.org/show_bug.cgi?id=235601

           Summary: Local contrast plugin preview is wrong
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: unspecified
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           svn 1.3.0 (using KDE 4.3.5)
Installed from:    Ubuntu Packages

The local contrast plugin preview does not show the same picture as the final.
It looks like parameters depend on the size of the picture. Maybe the blur
parameter should be expressed as a percentage of the diagonal of the picture.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=235601


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Local Contrast
            Version|unspecified                 |1.3.0
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=235601





--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2011-12-17 19:07:49 ---
Julien,

This file still valid using digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mike]

https://bugs.kde.org/show_bug.cgi?id=235601





--- Comment #2 from Mike <mailto mikes gmx de>  2012-01-03 19:08:57 ---
Created an attachment (id=67406)
 --> (http://bugs.kde.org/attachment.cgi?id=67406)
Sample of the Problem with preview and resulting picture with the local
contrast tool.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mike]

https://bugs.kde.org/show_bug.cgi?id=235601


Mike <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Mike <mailto mikes gmx de>  2012-01-03 19:09:47 ---
I can affirm the problem still exists in Digikam 2.4 in Oneiric. I had this
problem before in Digikam 2.0. After applying the preview settings the finished
image is much more enhanced...overenhanced. So the preview makes no sense...
what you get is another image...
I attached a sample of the preview and the resulting picture resized and put in
one picture. As you can see : the preview is the above.
Regards,
Mike

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=235601


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.3.0                       |2.4.0




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2012-01-03 19:34:04 ---
Can you share your photo to test in local ?

Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mike]

https://bugs.kde.org/show_bug.cgi?id=235601





--- Comment #5 from Mike <mailto mikes gmx de>  2012-01-03 19:52:45 ---
Hi Gillles,

sure. Heres the one screenshot i used for the preview so you can see the
settings i used in LC Tool. I will send you the original picture by email
because here for the bugtracking system ts to big i assume.
Thank you very much :-)
Mike

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Mike]

https://bugs.kde.org/show_bug.cgi?id=235601





--- Comment #6 from Mike <mailto mikes gmx de>  2012-01-03 19:55:01 ---
Created an attachment (id=67408)
 --> (http://bugs.kde.org/attachment.cgi?id=67408)
Preview Settings LC

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=235601


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |t




--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2012-01-17 11:49:13 ---
*** Bug 291537 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=235601

--- Comment #8 from Marcel Wiesweg <[hidden email]> ---
It seems to me that indeed, the "blur" parameter is highly defining for the
result in inplace_blur() and func(). But I dont understand the maths enough to
judge if linear scaling of the blur parameter when scaling the picture will fix
the problem.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=235601

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/digi
                   |                            |kam/c7bf359c7e563be57417f30
                   |                            |2b5846dde01f0169b

--- Comment #9 from Gilles Caulier <[hidden email]> ---
Git commit c7bf359c7e563be57417f302b5846dde01f0169b by Gilles Caulier.
Committed on 22/08/2012 at 18:51.
Pushed by cgilles into branch 'master'.

don't use downscaled image to render preview, it will differs than final
rendering
Related: bug 204466

M  +4    -3    imageplugins/enhance/localcontrasttool.cpp

http://commits.kde.org/digikam/c7bf359c7e563be57417f302b5846dde01f0169b

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=235601

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.9.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=235601

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Local Contrast              |Tool-LocalContrast
            Product|digikamimageplugins         |digikam

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel