[Bug 225728] New: Adding vignette should not increase brightness in the center

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=225728

           Summary: Adding vignette should not increase brightness in the
                    center
           Product: digikam
           Version: unspecified
          Platform: Archlinux Packages
        OS/Version: unspecified
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           trunk (using KDE 4.3.4)
Installed from:    Archlinux Packages

Adding a vignette to an image using the new functionality of the vignetting
tool increases the brightness of the image in the center of the vignette. This
should not happen or only if requested by the user.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=225728


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Image Editor
            Version|unspecified                 |1.2.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225728


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Image Editor                |Anti-Vignetting
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=225728


Fri Duh <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Fri Duh <friiduh gmail com>  2010-02-08 10:40:25 ---
I noticed same problem.

I believe that the tool needs to be redesign.

The effect always is applied to the center of the photo and not to corners of
the photo.

Example, when we are to remove the vignetting, the center of photo is darkened
so that the photo itself will gain the same level of the lightness. After the
fixing, the whole photo needs again fixing by lighting.

Now when we are applying the vigneting. The corners stays same level but are
applied a black layer and the center is again edited to be a brighter.

It is like the tool is wrong way. It should always fix the corners and not the
center what is correctly lightened in the first place.

So when we remove the vignetting, it should brighten the corners and leave
center untouched. And when adding a vignetting to photo, it should darken the
corners and not touch the center.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225728





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-02-10 08:35:28 ---
SVN commit 1088097 by cgilles:

use new BCG api
Fix wrong value with brightness settings to apply it on preview image
CCBUGS: 225728


 M  +32 -36    antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1088097

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225728





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2010-02-10 08:36:16 ---
Please check current implementation from svn to see if problem with brighness
is fixed.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=225728





--- Comment #4 from Julien Narboux <Julien narboux fr>  2010-02-21 22:02:17 ---
SVN commit 1093995 by jnarboux:

Reimplement vignetting/antivignetting logic.
Remove normalizing of the picture. This caused changes in the brightness of the
picture which were hard to predict.
Vignetting now decreases exposure in the periphery. Antivignetting increases
exposure in the periphery.
The center of the picture is always kept untouched. The new parameter inner
circle radius allow user to chose the size of the circle where the image is
kept untouched.
Remove Brightness/Contrast/Gamma tools, which I think were used in the post
only as a trick to restore brightness by hand in the center of the picture.

CCBUGS: 225728



 M  +0 -2      TODO  
 M  +36 -50    antivignetting.cpp  
 M  +7 -5      antivignetting.h  
 M  +71 -129   antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1093995

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=225728


Julien Narboux <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Julien Narboux <Julien narboux fr>  2010-02-22 07:41:13 ---
Johannes,

Can you check if the problem is solved for you ?

Thanks,

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=225728





--- Comment #6 from Johannes Wienke <languitar semipol de>  2010-02-22 18:03:51 ---
Yes, works as expected now, but I would like to have higher values for outer
radius and feather. The slider doesn't allow this right now. Is there any
reason for this?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=225728





--- Comment #7 from Julien Narboux <Julien narboux fr>  2010-02-22 21:48:57 ---
SVN commit 1094477 by jnarboux:

Increase range of parameters.

CCBUGS: 225728



 M  +2 -8      antivignetting.cpp  
 M  +5 -4      antivignettingtool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1094477

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=225728


Julien Narboux <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=225728


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Johannes Wienke <languitar semipol de>  2010-03-21 17:29:29 ---
*** Bug 231562 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=225728

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.2.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=225728

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.2.0                       |unspecified
          Component|Anti-Vignetting             |Tool-Vignetting
            Product|digikamimageplugins         |digikam

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel