[Bug 224136] New: Show dialog with settings when saving image on Windows [patch]

https://bugs.kde.org/show_bug.cgi?id=224136

           Summary: Show dialog with settings when saving image on Windows
                    [patch]
           Product: digikam
           Version: 1.1.0
          Platform: unspecified
        OS/Version: MS Windows
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.1.0 (using 4.3.4 (KDE 4.3.4), compiled sources)
Compiler:          gcc.exe
OS:                Microsoft Windows (i686) release 5.1 (XP Professional)

When saving a image on Windows the FileSaveOptionsBox is not shown since the
native Windows Save As-dialog is used. This patch puts the FileSaveOptionsBox
in a dialog that is shown after the Save As-dialog on Windows. The behavior can
be turned off via a setting.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=224136





--- Comment #1 from David Eriksson <meldavid acc umu se>  2010-01-25 09:56:28 ---
Created an attachment (id=40216)
 --> (http://bugs.kde.org/attachment.cgi?id=40216)
Patch implementing the dialog

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=224136


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2010-01-25 10:17:09 ---
David,

Thanks to contrib. it's very appreciate...

Why to add a digiKam setup option to show or not "file save as settings" view
in dialog. For me this must be always avaialble. I never see a photo
application with a similar behavior.

Why not to use RExpanderBox widget to host "file save as settings" view. You
can expand and collapse view and remember view state between session. Look
there :

http://websvn.kde.org/trunk/extragear/graphics/digikam/libs/widgets/common/rexpanderbox.h?revision=1048660&view=markup

For the rest of the patch, as coding style,, all is fine for me.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=224136





--- Comment #3 from David Eriksson <meldavid acc umu se>  2010-01-25 10:44:56 ---
Gilles,

I added the option since it changes the old behavior with only one dialog. Some
people never changes the default values and some can get annoyed to have to
press Ok twice.

The dialog only shows the settings for the current file type using the
FileSaveOptionsBox so I don't see why a RExpanderBox is needed. No dialog is
shown for file types without options.

David

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=224136





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2010-01-25 10:52:07 ---
>I added the option since it changes the old behavior with only one dialog. Some
>people never changes the default values and some can get annoyed to have to
>press Ok twice.

Ok now i understand. This want mean that under windows, and windows only, this
option is valid, because file saveas settings is displayed in a new dialog (as
gimp does for exemple).

Under linux this is not the case, because file save as dialog provided by KDE
can embbed settings as well. It simplify usability.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=224136


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-01-25 11:08:50 ---
SVN commit 1079934 by cgilles:

apply patch #40216 from David Eriksson
BUGS: 224136


 M  +1 -0      CMakeLists.txt  
 M  +33 -3     utilities/imageeditor/editor/editorwindow.cpp  
 M  +32 -0     utilities/setup/setupiofiles.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1079934

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=224136

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=224136

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|unspecified                 |MS Windows

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel