[Bug 221345] New: [wish] Option to turn off search autostart

[Tenno Seremel]

https://bugs.kde.org/show_bug.cgi?id=221345

           Summary: [wish] Option to turn off search autostart
           Product: digikam
           Version: 1.0.0
          Platform: Debian testing
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0 (using KDE 4.3.2)
OS:                Linux
Installed from:    Debian testing/unstable Packages

It would be useful to have an option to turn off search autostart since with
large collections it's not always a good idea to start searching until you
complete your query.

Sometimes I'm not writing it right away and digiKam thinks it can search
already (which is not always the case).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221345


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
          Component|general                     |setup
         Resolution|                            |FIXED




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2010-01-05 11:00:33 ---
Already implemented. Go to Setup digiKam Misc page and turn off right option...

Gilles Caulise

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Tenno Seremel]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #2 from Tenno Seremel <bug-reporting serenareem net>  2010-01-05 11:16:52 ---
It is? I can't seem to find it.

There are only 4 settings in the Miscellaneous Settings:

* Confirm when moving items to the trash;
* Do not confirm when applying changes in the right sidebar";
* Show splash screen at startup;
* Scan for new items at startup.

Was it implemented recently? digiKam's version is shown as 1.0.0~beta4-2 in
aptitude.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2010-01-05 11:25:05 ---
Nothing news : but "Scan for new items at startup." is that you need...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Tenno Seremel]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #4 from Tenno Seremel <bug-reporting serenareem net>  2010-01-05 11:57:59 ---
Aah... I wrote it way too ambiguous. I'm talking about search field. The one
you can get via ctrl + F while the program is already loaded.

i.e. I want an option so digiKam will wait until I press Enter before starting
search.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2010-01-05 12:30:11 ---
Start is not processed until you press Enter. CTRL+F show search page that all

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2010-01-05 12:31:38 ---
Ok, i understand. CTRL+F show search page + last search processed before. You
don't want to see last processed search. Question : why ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Tenno Seremel]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #7 from Tenno Seremel <bug-reporting serenareem net>  2010-01-05 12:59:00 ---
Umm… no, previous searches are fine (if that's what you talking about).

When you type something in search field digiKam starts searching automatically
as soon as you don't type any letters for some amount of seconds (timeout so to
speak). i.e. open search field type 'a' (without quotes). Wait. You'll see.

I want to have an option to stop it from doing so. With large collections when
you write 1 letter/short word and make a pause for some reason it's a little
bit annoying — disc thrashing, response time and all.

Option should be off by default of course.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221345


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
          Component|setup                       |Searches
         Resolution|FIXED                       |




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2010-01-05 13:31:50 ---
No need an option for that. Using a timer is enough. Like this it lets time for
you type more than one character before to process search. Usually 500 ms is
fine.

I also notified that in search text field, focus is lost when process is done.

Marcel, what do you think about ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221345


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|[wish] Option to turn off   |Do not process search
                   |search autostart            |immediately when enter text
                   |                            |to query




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #9 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-05 21:53:36 ---
There is a timer at 800ms

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2010-01-06 09:33:21 ---
really Marcel ? well, here it doesn't work because search is started
immediately.

I don't take a look in code yet (:=)))

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221345


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-06 19:49:38 ---
searchtabheader.cpp:
271
    d->keywordEditTimer = new QTimer(this);
    d->keywordEditTimer->setSingleShot(true);
    d->keywordEditTimer->setInterval(800);

    connect(d->keywordEdit, SIGNAL(textEdited(const QString &)),
            d->keywordEditTimer, SLOT(start()));

    connect(d->keywordEditTimer, SIGNAL(timeout()),
            this, SLOT(keywordChanged()));

    connect(d->keywordEdit, SIGNAL(editingFinished()),
            this, SLOT(keywordChanged()));

void QLineEdit::editingFinished ()   [signal]
This signal is emitted when the Return or Enter key is pressed or the line edit
loses focus. ...

Maybe editingFinished is too early for you?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=221345


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #12 from Johannes Wienke <languitar semipol de>  2010-01-06 20:09:17 ---
No, timeout() is the problem I think.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Tenno Seremel]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #13 from Tenno Seremel <bug-reporting serenareem net>  2010-01-06 21:07:12 ---
Maybe it's prossible to wrap this timer creation in some kind of "if(enabled)"
and do not create it at all if user says so? (I'd like to have an option like
that if it's not obvious yet).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2010-01-07 13:37:00 ---
Marcel,

It doesn't work here because when you change something in text field, search is
processed. I never use Enter to validate.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #15 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-07 18:06:54 ---
Here, when I type a letter in the line edit field and have a breakpoint set on
keywordChanged(), this slot is activated at a distinctly later time (800ms is a
good fit) by the timer, timerSourceDispatch() etc. in the backtrace.

If that is not the case for you, there are two possibilities:
1) something is setting off the timer before you actually type
2) it's not the timer triggering keywordChanged(), but the other connected
signal, editingFinished(), which is a direct connection to
SLOT(keywordChanged()), no through the timer

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #16 from Johannes Wienke <languitar semipol de>  2010-01-07 20:51:38 ---
I think this is a complete misunderstanding. To my mind, what Tenno wants is
that the search is _not_ triggered before he presses enter. This would only be
the case if the timer is removed or disabled since the timer calls the search
method every time the text is changed in any way.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #17 from Johannes Wienke <languitar semipol de>  2010-01-07 20:57:49 ---
One more thing about this: right now, if you first enter a search text, wait
for the search to start and then empty the search text, the whole database is
returned as results for the new search that's initiated. This is definitely a
performance problem. So we must not search for empty queries.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=221345





--- Comment #18 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-01-07 21:17:02 ---
Yes Johannes, your second comment is right. I think Tenno has filed a second
bug for this.

About the timer, I was mostly referring to Gilles' comments #8 and #10. Looking
at comment #7, you're right, that's not what this bug is about.

Now to the original request:
All other search bars in digikam provide "live" search. If this one now
requires to press Enter, that's different behavior. Additionally we would have
to add a button "Search" which would be cluttering the interface.
For me, the real problem is the loss of focus. That's a bug.
Additionally, we can increase the timeout a bit.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel