[Bug 220454] New: Over-Exposure and Under-Exposure indicators do not work correctly in White Balance dialogue

[Richard Ash (audacity-help)]

https://bugs.kde.org/show_bug.cgi?id=220454

           Summary: Over-Exposure and Under-Exposure indicators do not
                    work correctly in White Balance dialogue
           Product: digikam
           Version: unspecified
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta6 and 1.0.0 (using KDE 4.3.3)
Compiler:          gcc (Gentoo 4.3.4 p1.0, pie-10.1.5) 4.3.4 Affects amd64 and
x86 builds.
OS:                Linux
Installed from:    Gentoo Packages

1 Load a RAW file (any from Canon 450D) into Image Editor (not using Raw Import
Tool, 16 bit colour, camera white balance, rebuild highlights mode, auto
brightness enabled). Image at this point normally has no saturated areas.
2 Choose White Balance tool from the Color menu.
3 Raise the Exposure Compensation value so that the light areas of the image
become saturated white.
4 Click on the over exposure indicator at the top right of the image.

I would expect step 4 to turn the over-exposed areas of the image black, as
selected in the preferences as the over-exposure colour. However in 1.0.0-beta6
and 1.0.0 release, a few random pixels may turn black, but they have no
correlation to the over-exposed parts of the image, which will remain the
over-exposed white they were before.

The same problem occurs with the under-exposure indicator, with a pattern of
dots which look like the wrong image is being used to generate the mask or
something.

This worked correctly in versions up to 1.0.0-beta5 and is still fine now I
have reverted back to that version (but re-compiled from source today, so the
offending change is in digikam not a library).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220454


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-12-28 21:27:22 ---
You want to test and report a bug. Great. But use a stable release, not an old
beta. 1.0.0 is out just in time for Christmas. Install it and try again.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Richard Ash (audacity-help)]

https://bugs.kde.org/show_bug.cgi?id=220454


Richard Ash <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |




--- Comment #2 from Richard Ash <richard audacityteam org>  2009-12-28 21:51:09 ---
I did test the 1.0.0 release - it has exactly this bug in it. That's why I
started to report a bug.

I then went back and tried betas between the last version I knew worked
(1.0.0-beta5) and there to try and localise the problem, which leads me to say
it was last working in 1.0.0-beta5, and first broken in 1.0.0-beta6.

This is a bug in the 1.0.0 release (which I installed today), but it was first
introduced between the 1.0.0-beta5 and 1.0.0-beta6 releases.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220454


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Image Editor
            Version|unspecified                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=220454


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-29 14:52:27 ---
Richard, do I understand correctly that the indicator highlights those areas it
should highlight without applying the change?
Does it work correctly once the tool has applied its changes?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Richard Ash (audacity-help)]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #4 from Richard Ash <richard audacityteam org>  2009-12-29 17:16:44 ---
The preview image turns the bright areas white correctly, both in the preview
and when I apply the change (press OK). Once I've done so the image looks the
same as the preview (correct), however the indicators don't work.

In fact in the main Image Editor window, the under- and over-exposure
indicators (at the bottom right of the screen) are disabled, greyed out and
can't be clicked on. I can enable the under-exposure indicator using the F10
key, and both indicators using the entries in the View menu (at which point the
buttons stop being greyed out and can be clicked on). The indicators don't work
correctly however, they behave the same as in the white balance preview:
* The under-exposure indicator shows a few pixels, but not enough and in the
wrong place. They do have some relationship to the image however, because they
move depending on the image you have loaded.
* The over-exposure indicator doesn't appear to do anything at all, even with
obvious over-exposure (which shows up in older versions quite happily).

I will attach the three screen shots - the image when I first load it, the
image when I apply +1.5 stops correction and ask for over-exposure indication
in the 1.0.0 stable release, and the same image doing the same thing in
1.0.0-beta5, which is what I consider to be the "correct" behaviour.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Richard Ash (audacity-help)]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #5 from Richard Ash <richard audacityteam org>  2009-12-29 17:19:10 ---
Created an attachment (id=39428)
 --> (http://bugs.kde.org/attachment.cgi?id=39428)
Image loaded into the image editor (base line I am starting from).

This image doesn't have any over-exposure to indicate (ignore under-exposure
for the moment).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Richard Ash (audacity-help)]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #6 from Richard Ash <richard audacityteam org>  2009-12-29 17:21:16 ---
Created an attachment (id=39429)
 --> (http://bugs.kde.org/attachment.cgi?id=39429)
What happens when I select white balance, +1.5 stop exposure, over-exposure
indicator on, screen shot from 1.0.0 release version.

This screen shot from the 1.0.0 stable release has obvious over-exposure, but
it isn't being indicated (as far as I can see).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Richard Ash (audacity-help)]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #7 from Richard Ash <richard audacityteam org>  2009-12-29 17:24:53 ---
Created an attachment (id=39430)
 --> (http://bugs.kde.org/attachment.cgi?id=39430)
What happens when I select white balance, +1.5 stop exposure, over-exposure
indicator on, screen shot from 1.0.0-beta5

This screen shot from the 1.0.0-beta5 version has obvious over-exposure, which
is duly indicated (black) when the over-exposure indicator is selected (button
top right of image). Note that this seems disconnected from the buttons for the
same purpose at the bottom right of the whole UI, which I didn't try to use.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #8 from Jens Mueller <tschenser gmx de>  2009-12-29 19:06:10 ---
Created an attachment (id=39433)
 --> (http://bugs.kde.org/attachment.cgi?id=39433)
PATCH fixes not working over/under exposure with 16bit images

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-12-29 19:18:40 ---
Thanks Jens. Great to see you very active.

I propose to become a real contributor using an account to KDE svn repository ?

What do you think about ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220454


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Over-Exposure and           |Over-Exposure and
                   |Under-Exposure indicators   |Under-Exposure indicators
                   |do not work correctly in    |do not work correctly in
                   |White Balance dialogue      |White Balance dialogue
                   |                            |[patch]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2009-12-30 11:33:53 ---
Jens,

Why ? :

[  0%] Building CXX object
digikam/digikam/CMakeFiles/digikamcore.dir/__/libs/dimg/dimg.o                  
/mnt/data/devel/SVN/trunk/graphics/digikam/libs/dimg/dimg.cpp: In member
function ‘QImage
Digikam::DImg::pureColorMask(Digikam::ExposureSettingsContainer*)’:            
/mnt/data/devel/SVN/trunk/graphics/digikam/libs/dimg/dimg.cpp:1611: attention :
unused variable ‘s_alpha’

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #11 from Jens Mueller <tschenser gmx de>  2009-12-30 13:53:46 ---
Created an attachment (id=39456)
 --> (http://bugs.kde.org/attachment.cgi?id=39456)
PATCH, updated version, fixes also new introduced warning about unused member
variable, sorry

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220454


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2009-12-30 14:10:13 ---
SVN commit 1067737 by cgilles:

apply patch #39456 from Jens Mueller
BUGS: 220454


 M  +31 -37    dimg.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1067737

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Richard Ash (audacity-help)]

https://bugs.kde.org/show_bug.cgi?id=220454





--- Comment #13 from Richard Ash <richard audacityteam org>  2009-12-30 17:29:22 ---
Working fine for me as well, thanks! Patch also applies to 1.0.0 release so
I've rolled it into the 1.0.0 package for Gentoo to avoid other people hitting
the same problem (http://bugs.gentoo.org/show_bug.cgi?id=295459).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=220454

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.1.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel