[Bug 216636] New: Option to set parent album in Album -> New Album

https://bugs.kde.org/show_bug.cgi?id=216636

           Summary: Option to set parent album in Album -> New Album
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: unspecified
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.3.3)
Installed from:    Ubuntu Packages

Please add an option to set parent album in Album -> New Album. Thanks.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=216636


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Albums GUI
            Version|unspecified                 |1.0.0




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-11-29 13:00:31 ---
you want mean a new root collection, as you can see in setup collection dialog
?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=216636





--- Comment #2 from Dotan Cohen <kde-51 dotancohen com>  2009-11-29 13:29:42 ---
No. Currently, when choosing Album -> New Album the newly formed album is
created as a sub-album of the current album. That is not always what the user
wants. There should be an option to select where in the tree to place the new
album, or at the very least an option to make it a top-level album.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Georg Wittenburg]

https://bugs.kde.org/show_bug.cgi?id=216636


Georg Wittenburg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Georg Wittenburg <georg wittenburg gmx net>  2009-12-17 16:44:25 ---
I'm all for this. Actually, I'm wondering why it isn't the default to create
new albums in the collection root. Sub-albums really feels more like something
for advanced users, while a plain flat hierarchy is what newbies would expect
(I guess). Furthermore, if no album is selected Album->New... is grayed out,
which doesn't make much sense.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=216636


konstantin <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #4 from konstantin <krivakin gmail com>  2010-04-13 19:17:19 ---
Can be it is necessary to make so:
If it is selected a root collection or it is selected nothing, the window of
creation of a new collection (same as Configure-> Collections-> Add collection)
opens.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=216636


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2011-12-23 11:27:10 ---
Dotan,

This file still valid using digiKam 2.4 ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dotan Cohen-3]

https://bugs.kde.org/show_bug.cgi?id=216636


Dotan Cohen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Dotan Cohen <kde-2011 08 dotancohen com>  2012-01-11 09:09:06 ---
Yes, this is still valid. To reproduce:

1) In the main menu, select Album -> New... -> OK
2) There is no step 2.

It can be seen that the new album is a subalbum of the current album.
Intuitively it should be a top-level album.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=216636


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0                       |2.4.1




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=216636

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #7 from Smit Mehta <[hidden email]> ---
Hi Dotan

Suppose you want an album at position 'X' in the album hierarchy. Make your
current selection to be the parent of 'X' and go for a new album. Wont this
solve the issue?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=216636

--- Comment #8 from Smit Mehta <[hidden email]> ---
Hi Dotan

Kindly reply to my comment. Is it helpful? If it isnt, kindly explain your
problem a bit more elaborately, may be with a screen shot.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dotan Cohen-3]

https://bugs.kde.org/show_bug.cgi?id=216636

--- Comment #9 from Dotan Cohen <[hidden email]> ---
> Suppose you want an album at position 'X' in the album hierarchy. Make your current selection
> to be the parent of 'X' and go for a new album. Wont this solve the issue?
>

That is the current work-around, Smit.

However the bug is not the fact that one cannot create an album in the place of
his desire, but rather the unexpected behaviour regarding the positioning of
the new album. If the menu item were labelled "New Sub-Album" then the current
behaviour would be intuitive, but as the label states "New Album" intuition
expects it to be placed top-level.

Thank you!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=216636

--- Comment #10 from Smit Mehta <[hidden email]> ---
Hi Gilles

What do you suggest after reading Dotan's comment?

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=216636

--- Comment #11 from Gilles Caulier <[hidden email]> ---
2 solutions.

1/ Rename "New Album" as "New Sub Album" in this dialog and contextual menu.
2/ Add an option in dialog to be able to choose where new album will be plug in
hierarchy, as a sub album of current selected (default) or as root of
hierarchy...

Dotan, this respond to your problem ?

Gilles Caulier

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Dotan Cohen-3]

https://bugs.kde.org/show_bug.cgi?id=216636

--- Comment #12 from Dotan Cohen <[hidden email]> ---
I wouldn't call it "my problem" but it does address the issue! This was
actually brought to my attention from another Digikam user.

I think that the second solution is preferable. Thanks Gilles and Smit!

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=216636

--- Comment #13 from Smit Mehta <[hidden email]> ---
Created attachment 69934
  --> https://bugs.kde.org/attachment.cgi?id=69934&action=edit
Patch for bug 216636

Hi Gilles

Kindly go through the above patch. It produces desired results in my system. If
it is fine with you, i shall commit it.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=216636

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #69934|0                           |1
        is obsolete|                            |

--- Comment #14 from Smit Mehta <[hidden email]> ---
Created attachment 69936
  --> https://bugs.kde.org/attachment.cgi?id=69936&action=edit
Patch for bug 216636 (final)

Hi Gilles

This is the latest patch. Previous patch has indentation issues.

Smit

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Smit Mehta]

https://bugs.kde.org/show_bug.cgi?id=216636

Smit Mehta <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #15 from Smit Mehta <[hidden email]> ---
Git commit b17893e9768e6ed020a649e68d238b16c2c7f145 by smit mehta.
Committed on 28/03/2012 at 15:36.
Pushed by smitmehta into branch 'master'.

Adding an option to select the parent in creation of new album
CCMAIL:[hidden email]

M  +4    -7    digikam/album/albummodificationhelper.cpp
M  +53   -9    digikam/album/albumpropsedit.cpp
M  +3    -1    digikam/album/albumpropsedit.h

http://commits.kde.org/digikam/b17893e9768e6ed020a649e68d238b16c2c7f145

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=216636

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |2.6.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel