[Bug 215752] New: Endianness bug saving 16 bits images

[pochini]

https://bugs.kde.org/show_bug.cgi?id=215752

           Summary: Endianness bug saving 16 bits images
           Product: digikam
           Version: 1.0.0-beta6
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta6 (using KDE 4.3.3)
Compiler:          gcc (GCC) 4.1.2 (Gentoo 4.1.2 p1.0.2)  powerpc
OS:                Linux
Installed from:    Compiled From Sources

On big-endian archs digikam does not save 16 bits images properly. Saving
completes without errors, but when the image is loaded with any other program
it looks scrabled.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=215752


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |RAW files management




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[pochini]

https://bugs.kde.org/show_bug.cgi?id=215752





--- Comment #1 from  <pochini shiny it>  2009-11-26 00:45:28 ---
Created an attachment (id=38590)
 --> (http://bugs.kde.org/attachment.cgi?id=38590)
Fix 16 bits PNG output on big-endian architectures.

The attached patch fixes the bug I reported. It doesn't affect little-endian
machines.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=215752


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Endianness bug saving 16    |Endianness bug saving 16
                   |bits images                 |bits images [patch]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=215752


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-20 16:25:20 ---
pochini, do you have an explanation why the loop after loading in
pngloader.cpp, 449-461, works on big endian? Isn't it swapping from network
byte order to little endian?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=215752


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-20 16:31:59 ---
SVN commit 1064297 by mwiesweg:

Fix PNG saving on big endian,
patch from  [hidden email]

BUG: 215752

 M  +2 -1      NEWS  
 M  +44 -31    libs/dimg/loaders/pngloader.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1064297

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[pochini]

https://bugs.kde.org/show_bug.cgi?id=215752





--- Comment #4 from  <pochini shiny it>  2009-12-20 22:22:07 ---
Created an attachment (id=39198)
 --> (http://bugs.kde.org/attachment.cgi?id=39198)
16 bits PNG loader fix

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[pochini]

https://bugs.kde.org/show_bug.cgi?id=215752


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from  <pochini shiny it>  2009-12-20 22:25:10 ---
(In reply to comment #2)
> pochini, do you have an explanation why the loop after loading in
> pngloader.cpp, 449-461, works on big endian? Isn't it swapping from network
> byte order to little endian?

Yes... it doesn't work. Sorry, I didn't test 16 bits PNG loading. I've just
uploaded a patch that fixes it too.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=215752





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-21 20:39:41 ---
SVN commit 1064788 by mwiesweg:

Fix 16bit PNG loading on Big Endian,
thanks to [hidden email]

CCBUG: 215752

 M  +17 -14    pngloader.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1064788

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=215752


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta6                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=215752

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Workflow                    |FilesIO-Engine

--
You are receiving this mail because:
You are the assignee for the bug.