[Bug 211758] New: Saving TIFF-16 compressed using exiv2 0.18 shows odd results

https://bugs.kde.org/show_bug.cgi?id=211758

           Summary: Saving TIFF-16 compressed using exiv2 0.18 shows odd
                    results
           Product: digikam
           Version: unspecified
          Platform: SuSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.2.4)
OS:                Linux
Installed from:    SuSE RPMs

Hi,

during my attempts to find out what is cause for the undo/revert-bug I
discovered a new one:

When using digikam with exiv 0.17 it saves TIFF-16 compressed and uncompressed
without problems. Using exiv2 0.18 or 0.18.2 (and recompiling libkexiv2 and
digikam of course) saving TIFF-16 compressed results in an image looking like
someone has used an emboss filter.

Here is an example:
http://www.dolphin-world.de/images/Bild_M2c_061h.tif

And so it should be:
http://www.dolphin-world.de/images/Bild_M2c_061i.tif

I have tried to use exiv2 0.18 from rpm and by compiling by myself: no
difference.

TIA
Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Metadata




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-10-25 13:23:24 ---
Like previous bug from you : take a look of difference between metadata of both
TIFF files using ExifTool.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #2 from Andreas Huggel <ahuggel gmx net>  2009-10-25 23:12:38 ---
Can you please provide Bild_M2c_061h.tif when it was still ok, before it was
saved in digiKam?

How did you create Bild_M2c_061i.tif? Which version of exiv2 was used to save
it (if it was saved using digiKam at all)?

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #3 from Guenther M. Erhard <guenther erhard gmx de>  2009-10-26 22:01:12 ---
Hi Andreas,

> Can you please provide Bild_M2c_061h.tif when it was still ok, before it was
> saved in digiKam?
>
It is quiet large (120MB). Today my upload speed is really bad. So I'll provide
a link tomorrow.

> How did you create Bild_M2c_061i.tif? Which version of exiv2 was used to save
> it (if it was saved using digiKam at all)?
>
For both images I used Version 1.0.0-beta6 (rev.: 1039950) with exiv2 0.18.2
and libtiff 3.8.2. Before saving I scaled the image down to reduce the size,
but the odd result was the same when I just saved it. The difference was only
that for Bild_M2c_061h.tif the checkbox "Compress TIFF file" was ticked and for
Bild_M2c_061i.tif not.

Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #4 from Guenther M. Erhard <guenther erhard gmx de>  2009-10-27 08:02:20 ---
(In reply to comment #3)
> It is quiet large (120MB). Today my upload speed is really bad. So I'll
> provide a link tomorrow.
>
http://www.gmx.de/mc/gHBpcdORx2xt9u16rDvJm2ZFSzMngl

This link is valid until Nov. 26th.

Guenther

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-10-27 18:20:13 ---
*** Bug 212072 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-11-06 16:45:43 ---
Output from tiffinfo with 061h.tif from above:
TIFFReadDirectory: Warning, Bild_M2c_061i.tif: invalid TIFF directory; tags are
not sorted in ascending order.
TIFFReadDirectory: Warning, Bild_M2c_061i.tif: unknown field with tag 11 (0xb)
encountered.
TIFFReadCustomDirectory: Warning, Bild_M2c_061i.tif: unknown field with tag
40961 (0xa001) encountered.
TIFFReadDirectory: Warning, Bild_M2c_061i.tif: unknown field with tag 513
(0x201) encountered.
TIFFReadDirectory: Warning, Bild_M2c_061i.tif: unknown field with tag 514
(0x202) encountered.
MissingRequired: Bild_M2c_061i.tif: TIFF directory is missing required
"ImageLength" field.

This is bug #211066, only this time affecting image data!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758


Olleg Samoylov <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Olleg Samoylov <splarv ya ru>  2009-11-10 01:41:53 ---
Yep, the same bug in Ubuntu 9.10. These tiffs (8 or 16 bits)) are generated by
builtin Batch Raw Converter.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 15:57:50 ---
yes, i can reproduce there this dysfunction, using ne HDR creation tool when
RAW are imported as HDR. Internally, RAW are converted to TIFF file as post
processed before import.

TIFF are loadable but image contents is broken, as if R and B color are
switched... or definition of component.

This is only reproducible when libkexiv2/Exiv2 is called to restore metadata
from original RAW to TIFF.

And this i also reproducible using RAW converter create TIFF from RAW file. The
tiff writter code is the same than HDR Creator tool (code is shared in
libkipiplugins).

If i comment libkexif call, TIFF file generated is fine... This line in fact :

http://lxr.kde.org/source/extragear/graphics/kipi-plugins/common/libkipiplugins/kpwriteimage.cpp#763

The tiff writter use libtiff of course.

I have used Exiv2 0.18.2 to make tests. I will try current code from svn...

I make some test image for investiguations. upload under progress...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 16:15:04 ---
Andreas,

Test files generated with Exiv2 0.18.2 are there :

http://digikam3rdparty.free.fr/bugs/212072

-rw-r--r-- 1 gilles gilles 30686734 2009-12-05 23:43 MINOLTA-DYNAX7D-04-2.tif
-rw-r--r-- 1 gilles gilles   446816 2009-12-06 15:24 MINOLTA-DYNAX7D-04-2.txt
-rw-r--r-- 1 gilles gilles  9190688 2006-03-24 00:00 MINOLTA-DYNAX7D-04.MRW
-rw-r--r-- 1 gilles gilles    14230 2009-12-06 15:34 MINOLTA-DYNAX7D-04.MRW.txt
-rw-r--r-- 1 gilles gilles 30716928 2009-12-05 23:22 MINOLTA-DYNAX7D-04.tif
-rw-r--r-- 1 gilles gilles   360619 2009-12-06 15:24 MINOLTA-DYNAX7D-04.txt

- MINOLTA-DYNAX7D-04.MRW is the original RAW file
- MINOLTA-DYNAX7D-04.tif is the 1th TIF file converted from RAW file. This one
is corrupted by libkexiv2/Exiv2 call.
- MINOLTA-DYNAX7D-04-2.tif is the 2nd TIF file converted from RAW file without
to call libkexiv2/Exiv2 to restore metadata. In fact only libtiff is used in
this case.

Look the message given by ImageMagick commanad line tool to try to see this
image :

[gilles@localhost HORIZONTAL]$ display MINOLTA-DYNAX7D-04.tif
display: MINOLTA-DYNAX7D-04.tif: invalid TIFF directory; tags are not sorted in
ascending order. `TIFFReadDirectory' @ tiff.c/TIFFWarnings/703.
display: MINOLTA-DYNAX7D-04.tif: unknown field with tag 11 (0xb) encountered.
`TIFFReadDirectory' @ tiff.c/TIFFWarnings/703.
display: MINOLTA-DYNAX7D-04.tif: unknown field with tag 50341 (0xc4a5)
encountered. `TIFFReadDirectory' @ tiff.c/TIFFWarnings/703.
display: MINOLTA-DYNAX7D-04.tif: TIFF directory is missing required
"ImageLength" field. `MissingRequired' @ tiff.c/TIFFErrors/493.

Note : message are generated by libtiff of course...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 16:19:06 ---
Andreas,

Don't forget this code from libkexiv2 to trying to preserve TIFF image
structure.

http://lxr.kde.org/source/KDE/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2.cpp#391

This code is inspired from UFRAW when metadata are backported from RAW to TIFF.

http://ufraw.cvs.sourceforge.net/viewvc/ufraw/ufraw/ufraw_exiv2.cc?revision=1.53&view=markup

...see at line 285...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-06 17:23:27 ---
*** Bug 211066 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #12 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-06 17:27:39 ---
In exiv2's action.cpp, there is a method
bool isExifTag(const Exiv2::Exifdatum& ed) (line 1797) to determine if a tag
from ExivData is an Exif tag in TIFF-like files. It's used from metacopy(...)
(line 1703), specifically for TIFF files (1736-1747).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.0.0




--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 17:53:07 ---
Thanks Marcel for the tip.

Andreas, Exiv2 0.18.99 do not help here. Same problem. Tiff file generated are
broken

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 20:14:36 ---
Marcel,

If i fell all tags listed in isExifTag() as untouched tags from KExiv2::save
method, the tiff file is completly broken : 200kb intead 29Mb...

I'm completly lost. I'm pretty sure that Exiv2 touch something worng there. But
what ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #15 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-06 21:26:24 ---
I tried to copy verbatim the code from metacopy() to libkexiv2, but still, gimp
is complaining.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #16 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 21:52:01 ---
SVN commit 1059510 by cgilles:

disable temporaly tiff metadata using Exiv2.
CCBUGS: 211758


 M  +3 -1      kpwriteimage.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1059510

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2009-12-06 21:53:34 ---
SVN commit 1059511 by cgilles:

idem in digiKam TIFFF writter
CCBUGS: 211758


 M  +2 -1      tiffloader.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1059511

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #18 from Andreas Huggel <ahuggel gmx net>  2009-12-07 01:38:21 ---
(In reply to comment #15)
> I tried to copy verbatim the code from metacopy() to libkexiv2, but still, gimp
> is complaining.

Marcel, what does it complain about exactly? Can you show me the resulting
picture and the modified code?

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2009-12-07 09:56:43 ---
Andreas,

Have you take a look to my TIFF files shared on #9 ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel