[Bug 211758] New: Saving TIFF-16 compressed using exiv2 0.18 shows odd results

[Leonardo Giordani-2]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #39 from Leonardo Giordani <giordani leonardo gmail com>  2010-04-12 15:45:40 ---
With Digikam 1.2.0 (SVN of 03 April 2010) I can open TIFFs with The Gimp
without any problem (Gimp was complaining about TIFF tags - the bug was merged
with the current one). The Gimp issue can be marked as solved.

Thank you.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #40 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-12 17:48:38 ---
In 1.2.0 we dont write the metadata to the created TIFF to workaround this
issue.
So it wasn't fixed there, but the feature disabled.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #41 from Andreas Huggel <ahuggel gmx net>  2010-04-13 04:28:17 ---
Re comment #37: Thumbnails

The standards regarding this are conflicting. There are at least four different
specifications to consider:

TIFF/EP and DNG
---------------
Recommend thumbnail in IFD0, main image in a sub-IFD of IFD0.
Chained IFDs are used for multiple non-identical images (each of which using
this sub-IFD tree structure)

Adobe PageMaker TIFF Technical Notes
------------------------------------
(also referred from the Photoshop Technical notes)
Recommend main image in IFD0, thumbnail in a sub-IFD of IFD0.
Chained IFDs are used as above.

Original TIFF
-------------
Only provides for chaining, the sub-IFD tag doesn't exist in the original TIFF
specification. It doesn't mention thumbnails, but the most obvious place to
store one is in a chained IFD, as specified in the Exif standard.

Exif
----
IFD0 contains only metadata, no image data. The Exif thumbnail is stored in a
chained IFD1. In reality, the Makernote structure of many cameras contain
further thumbnails.

---

The thumbnail that Marcel disabled was in a chained IFD1 and not recognized by
GIMP as such - GIMP looks at a chained IFD as a second non-identical image
("page") within the TIFF file, as recommended by the TIFF/EP and DNG standards.

Exiv2 only has support to read thumbnails which already exist in a TIFF image.
It doesn't generate thumbnails from the main image (e.g., after that was
modified). I'm not familiar with libtiff, but that would be the next place to
look for such a feature it seems:

Does libtiff have a feature to generate a thumbnail from the main image and
store both main image and thumbnail in the appropriate places within the TIFF
image?

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #42 from Andreas Huggel <ahuggel gmx net>  2010-04-13 04:37:06 ---
> Andreas: I'm not sure how to test this. Perhaps the original reporter here can
> give a hint if the problem is fixed with latest versions.

See Gilles' comment #9. I suspect converting a RAW file to a compressed TIFF is
a way to reproduce the problem.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #43 from Gilles Caulier <caulier gilles gmail com>  2010-04-14 09:05:58 ---
Andreas,

>Does libtiff have a feature to generate a thumbnail from the main image and
>store both main image and thumbnail in the appropriate places within the TIFF
>image?

I think no. libtiff is really low level API. You need to do it by hand, as i do
with code in digiKam tiff writer.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #44 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-17 16:22:05 ---
So, how to create "a chained IFD as a second non-identical image ("page")
within the TIFF file"? Assuming I have the preview image data generated, do I
add it with exiv2 or with libtiff?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #45 from Andreas Huggel <ahuggel gmx net>  2010-04-19 05:58:21 ---
Marcel,

That "chained IFD" is what digiKam generates today. I think it's not the
correct way to create a thumbnail. Instead I suggest to create the thumbnail
either (1) in IFD0 according to TIFF/EP standard or (2) in a sub-IFD as
suggested in the Adobe PageMaker TIFF Technical Note.

Using libtiff, see the file tools/thumbnail.c for an example. I believe it
creates a thumbnail according to method (2).

With Exiv2, conceptually you do the same, i.e., add the relevant tags, but I
don't have a good sample. I don't mind writing one, it's a good use-case. Will
post it here.

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #46 from Andreas Huggel <ahuggel gmx net>  2010-04-19 17:27:20 ---
Created an attachment (id=42899)
 --> (http://bugs.kde.org/attachment.cgi?id=42899)
Sample program: Add a (dummy) JPEG thumbnail to a TIFF image with Exiv2

The attached sample adds a JPEG thumbnail in the first sub-IFD of a TIFF image.
It only adds the most basic tags, a real application may want to add a few more
(eg, X/YResolution, ResolutionUnit). All of the applications I tried are happy
with a TIFF image modified with this sample, but none actually seems to use the
thumbnail.

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #47 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-04-19 19:16:11 ---
Thanks a lot Andreas.

So what I will do with TIFFs is:

- use ExifThumb::erase() to remove all IFD1 entries
- use your code example to add an IFD0 thumb.

With all other image formats except for TIFF, we add a thumb with
ExifThumb::setJpegThumbnail.
For all images including TIFF, we set a (larger) preview in
Iptc.Application2.Preview.

Is that ok?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #48 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-05-07 20:55:57 ---
SVN commit 1124097 by mwiesweg:

Use dedicated methods from libkexiv2 to set a TIFF thumbnail.
Reenable metadata writing to TIFF for testing (not all problems solved).

Provide original image size for JPEG and RAW from DImg.
For RAWs, size is read with Exiv2.

CCBUG: 211758

 M  +21 -0     dimg/dimg.cpp  
 M  +4 -0      dimg/dimg.h  
 M  +2 -0      dimg/loaders/jpegloader.cpp  
 M  +3 -0      dimg/loaders/pgfloader.cpp  
 M  +2 -7      dimg/loaders/tiffloader.cpp  
 M  +11 -2     threadimageio/previewtask.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1124097

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #49 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-05-07 20:58:18 ---
I have no followed the suggestions to add a thumbnail to a TIFF file, and Gimp
does no longer show to images for the TIFF.

However, the "not sorted in ascending order" problem is still unsolved!
As a testcase, I used the MRW file from Gilles from comment #9. Importing from
RAW, saving as TIFF, and Gimp shows an error message about tag sort order.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #50 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-05-20 12:47:03 ---
Andreas, after some considerations and a bit reading the docs, I have these
ideas:

As soon as I remove the 0xb tag, all user-visible GIMP warnings are gone.
0x000b is officially defined as a TIFF TAG, the GPS tag GPSDOP. Libtiff may
expect such a tag in the GPS IFD, and is then right in its warning about the
wrong order.
As I understand, this tag was created by ACDsee and not by any official
standard?

In any case, I suggest we remove this tag when writing a TIFF. This should
finally solve the remaining problems here.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211758





--- Comment #51 from Andreas Huggel <ahuggel gmx net>  2010-05-21 04:26:45 ---
Marcel, yes not writing the 0x0b tag is a workaround to prevent the libtiff
error. However the issue is clearly a small libtiff bug - it wrongly says the
tags are not sorted (just remembered I was actually looking for a place to file
this one weekend, but got sidetracked somehow...) The rule is simply that tags
within an IFD must be sorted. A tag with a given number in one directory is not
in any way related to another tag with the same number in a different
directory.

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=211758


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #52 from Marcel Wiesweg <marcel wiesweg gmx de>  2010-05-21 12:53:56 ---
SVN commit 1129105 by mwiesweg:

Remove the ProcessingSoftware tag (0xb) when writing a TIFF file, because
it makes libtiff generate a warning which is then user-visible in Gimp.

Now finally, the Gimp is happy again with our TIFF files.

BUG: 211758

 M  +2 -1      NEWS  
 M  +2 -0      libs/dimg/loaders/tiffloader.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1129105

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211758

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.3.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel