[Bug 211423] New: Raw import intensity curve is not restored

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211423

           Summary: Raw import intensity curve is not restored
           Product: digikam
           Version: unspecified
          Platform: Ubuntu Packages
        OS/Version: unspecified
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta6 (rev.: 1038897) (using KDE 4.3.2)
Installed from:    Ubuntu Packages

When importing a raw file using the advanced import dialog, everything is
restored from the previous import action except the intensity curve.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211423


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |RAW files management




--- Comment #1 from Johannes Wienke <languitar semipol de>  2009-10-22 11:28:58 ---
Is this RAW files management or image editor? ;)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211423


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|RAW files management        |Image Editor
            Version|unspecified                 |1.0.0-beta6




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-10-22 11:41:55 ---
But this code is dedicated for this task :

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/rawimport/rawsettingsbox.cpp#526

http://lxr.kde.org/source/extragear/graphics/digikam/utilities/imageeditor/rawimport/rawsettingsbox.cpp#463

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=211423





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2009-10-22 12:05:56 ---
Maybe an orphaned or invalid read config var again? This is why I started to
use variables instead of hardcoded text,

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211423





--- Comment #4 from Johannes Wienke <languitar semipol de>  2009-10-22 17:23:11 ---
Ok, I found the problem. After some fixes the raw curve points are restored
correctly from the rc file but this is not the real problem.

What happens is that:
1. curve is restored for the widget
2. the image is set in CurvesWidget::updateData
3. this method creates new curves depending on if the image is 16 bit or not
=> restored curve is reset

Why does the curve need to know whether the image is 16 bit or not? If this
wasn't necessary, then this reset won't be needed. Moreover, what do we do at
the moment, if a curve was generated for a 16 bit image and the next one is a
normal image with 8 bits per channel?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211423


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-10-22 18:10:50 ---
It's simple : as you can switch from 8 to 16 and 16 to 8 bits into Raw
demosaicing settings between Raw import session, and as Curves widget use this
setting to adjust internal image data management, curves informations are
formated accordingly with this setting. So if you have curves 8 bits info from
rc file to apply on 16 bits image, you need to convert it and vice versa...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211423





--- Comment #6 from Johannes Wienke <languitar semipol de>  2009-10-22 18:23:18 ---
But I don't understand, why the Curve needs the information if demosaicing is
for 16 bit or not? To my mind the curve should always have the same external
interface (with same data ranges and so on) and should handle the differences
for 8 or 16 bit internally. This would really simplify the usage.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211423





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2009-10-22 18:26:59 ---
No, it's not the same interface for the histogram. Try CurvesAdjust tool for
example... and look in CurvesWidget class for details

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211423





--- Comment #8 from Johannes Wienke <languitar semipol de>  2009-10-22 18:43:14 ---
I did not mean the same interface for the histogram. What I meant is why
ImageCurves needs to use different data ranges (eg. the QPoints returned in
getCurvePoint) depending on the number of bits of the image. Why can't it
always use 255 as max value and convert it internally to what is needed?

But maybe I misunderstand the purpose of this class. What exactly is it meant
to?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211423





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-10-22 18:51:21 ---
Because ImageCurves code come from gimp which only support 8 bits color depth.
I have adapted code to support 16 bits...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211423





--- Comment #10 from Johannes Wienke <languitar semipol de>  2009-10-22 18:53:09 ---
Ah ok, I see

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=211423


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #11 from Johannes Wienke <languitar semipol de>  2009-10-23 01:01:35 ---
SVN commit 1039201 by jwienke:

Restore curves for raw import. This includes some refactorings and removing of
magic numbers.

BUG: 211423

 M  +2 -1      NEWS  
 M  +4 -2      imageplugins/adjustcurves/adjustcurvestool.cpp  
 M  +14 -23    imageplugins/coreplugin/bwsepiatool.cpp  
 M  +17 -17    imageplugins/coreplugin/iccprooftool.cpp  
 M  +173 -51   libs/curves/imagecurves.cpp  
 M  +28 -3     libs/curves/imagecurves.h  
 M  +5 -43     libs/widgets/common/curvesbox.cpp  
 M  +2 -2      libs/widgets/common/curvesbox.h  
 M  +109 -8    libs/widgets/common/curveswidget.cpp  
 M  +38 -0     libs/widgets/common/curveswidget.h  
 M  +2 -26     utilities/imageeditor/rawimport/rawsettingsbox.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039201

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=211423


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta6                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel