[Bug 210969] New: crash when saving images in editor

https://bugs.kde.org/show_bug.cgi?id=210969

           Summary: crash when saving images in editor
           Product: digikam
           Version: 1.0.0-beta5
          Platform: unspecified
        OS/Version: MS Windows
            Status: UNCONFIRMED
          Severity: crash
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta5 (using 4.3.2 (KDE 4.3.2), MS Visual Studio 2008
SP1)
Compiler:          cl.exe
OS:                Microsoft Windows (i686) release 6.0 (Vista Professional)

I experience problems when saving images in the editor.

1) When saving an exiting image overwriting it (i.e. i press the "Save"
button), I get the following error:

Could not open a temporary file in the folder "/E:/my/photo/directory/": The
filename, directory name, or volume label syntax is incorrect. (5)

Notice the initial slash in the file path: maybe related with
https://bugs.kde.org/show_bug.cgi?id=205341 ?
If I click OK, Digikam freezes and I have to terminate it via Task Manager.


2) If I save the image with "Save as...", choosing a new filename, Digikam just
crashes and a Windows' popup says "digikam.exe has stopped working".

Please ask if more details are needed.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210969


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Image Editor




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-10-18 17:34:03 ---
Yes, we need a backtrace.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210969


Dario Andres <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Dario Andres <andresbajotierra gmail com>  2009-10-21 16:09:19 ---
This link could help you:
http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_on_MS_Windows

Regards

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-10-22 19:04:17 ---
Tried to test this here, but the code path hitting the error condition in
EditorWindow::setupTempSaveFile does not lead to a freeze here. So I can't
reproduce.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #4 from Paolo Masulli <paolo masulli gmail com>  2009-10-22 20:44:30 ---
Created an attachment (id=37743)
 --> (http://bugs.kde.org/attachment.cgi?id=37743)
gdb output

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #5 from Paolo Masulli <paolo masulli gmail com>  2009-10-22 20:45:29 ---
Created an attachment (id=37745)
 --> (http://bugs.kde.org/attachment.cgi?id=37745)
Debugview output

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210969


Paolo Masulli <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Paolo Masulli <paolo masulli gmail com>  2009-10-22 20:46:44 ---
(In reply to comment #2)
> This link could help you:
> http://techbase.kde.org/Development/Tutorials/Debugging/Debugging_on_MS_Windows
>
> Regards

I tried to follow these instructions.
I attached the files NABUCCO.LOG from Debugview and gdb.txt from gdb.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-10-23 18:54:51 ---
Unfortunately this backtrace is not helpful, looks broken. I'm sorry I have
never debugged on Windows.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210969


David Eriksson <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from David Eriksson <meldavid acc umu se>  2009-10-27 15:06:24 ---
I can confirm both problems.
I think the first is related to bug #205341. KUrl:directory() uses path() and
not toLocalFile so it gives a starting / with KDE 4.3. This can be seen in
otrher places to, like in image information in right sidebar where Directory is
given and it also starts with a /.

The second problem may not be just a Digikam problem since for me Kate also
crashes the same way on Save as. When run under gdb I get the following:

Program received signal SIGSEGV, Segmentation fault.
0x09afc659 in KFileDialog (this=0x2479cc90, startDir=@0x23bb4c,
filter=@0x23bc74,

parent=0x22f74490,
    customWidget=0x22431a30)
    at

C:\kde\kde-mingw4-stable\build\kde-4.3\kdelibs-20080202\work\kdelibs-4.3.2\kio\kfile\kfiledialog.cpp:238
238     in

C:\kde\kde-mingw4-stable\build\kde-4.3\kdelibs-20080202\work\kdelibs-4.3.2\kio\kfile\kfiledialog.cpp

I am running KDE 4.3.2 mingw4 from installer with self-compiled Digikam.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-10-27 15:12:21 ---
Yes: under windows, KDE 4.3.2, I can reproduce the crash with kate and showfoto
when File/Open is used...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-11-27 20:49:14 ---
Gilles, is this a kdelibs crash? Any improvement after the coding sprint work
on Windows?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #11 from David Eriksson <meldavid acc umu se>  2009-12-09 22:46:18 ---
No more crash with KDE 4.3.4 and digikam from svn. However both Save and Save
As gives problem 1. This is since KUrl::directory() uses KUrl::path().
Is it possible to change it to toLocalFile() and use the whole filename as
start for the temporaryfile?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2009-12-09 23:28:58 ---
Marcel,

As David said, ye i think it's solved now in kdelibs

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #13 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-10 20:32:11 ---
It seems to me now that KUrl::directory() is pretty useless for local files,
there is no proper replacement method (like "toLocalDirectory")
What should we use to emulate this?

KUrl parent(url.directory()); parent.toLocalFile();

QFileInfo info(url.toLocalFile()); info.dir().path();

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210969





--- Comment #14 from David Eriksson <meldavid acc umu se>  2009-12-17 23:18:10 ---
Created an attachment (id=39131)
 --> (http://bugs.kde.org/attachment.cgi?id=39131)
Patch with KUrl

This must be fixed before release. The attached patch uses Marcels first
suggestion. It works for me with both Save and Save As.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210969


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2009-12-18 15:16:29 ---
SVN commit 1063417 by cgilles:

apply patch #39131
BUGS: 210969


 M  +6 -0      editorwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1063417

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210969


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta5                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=210969

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Platform|unspecified                 |MS Windows

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel