[Bug 210967] New: Deleting left image in Light Table in Pair mode jumps to next pair

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210967

           Summary: Deleting left image in Light Table in Pair mode jumps
                    to next pair
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.3.2)
Installed from:    Compiled From Sources

Instead of moving the right image to the left slot and taking the next
available one to the right the next pair is selected the image previously
selected into the right half of the view is discarded to the left of the
list... So in fact by looking at the descriptions in the code case:
1)  A_L  B_R  C    D   ->   B_L  C_R  D
Works out as
1)  A_L  B_R  C    D   ->   B  C_L  D_R

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210967


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Light Table
            Version|unspecified                 |1.0.0-beta6




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210967





--- Comment #1 from  <kgw mineralien-verkauf de>  2009-10-18 23:35:58 ---
Additional information: This seems to happen outside of
LightTableWindow::slotRemoveItem as the items determined for the left and right
hand side of the light table are correct...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210967





--- Comment #2 from  <kgw mineralien-verkauf de>  2009-10-18 23:55:24 ---
Further debugging reveals that slotRemoveItem is the culprit after all. In pair
mode always the left item is active but the slot tries to set the right item
active after the deletion, which in pair mode moves the selection one item to
the right... Please can anyone confirm that the correct way of handling this
case would be not to set the leftPanelActive variable to false in pair mode as
this case IMHO can't happen...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210967





--- Comment #3 from  <kgw mineralien-verkauf de>  2009-10-19 00:44:47 ---
Created an attachment (id=37656)
 --> (http://bugs.kde.org/attachment.cgi?id=37656)
Patch to not try to set the right panel active in pair mode

For me this now works as intended...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210967


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Deleting left image in      |Deleting left image in
                   |Light Table in Pair mode    |Light Table in Pair mode
                   |jumps to next pair          |jumps to next pair [patch]




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-10-19 08:56:21 ---
Thanks for the patch. We will review it soon

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=210967


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Johannes Wienke <languitar semipol de>  2009-10-22 01:57:31 ---
Is this the same issue that I just fixed for 211366?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210967


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-10-22 09:09:01 ---
In the idea yes, but look patch attached to this file...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210967





--- Comment #7 from  <kgw mineralien-verkauf de>  2009-10-22 09:24:20 ---
@Johannes: I looked at your patch, it does fix a problem but not this one
though, this arises later while the effects of the deletion is evaluated - see
my patch attached below...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=210967


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #8 from Johannes Wienke <languitar semipol de>  2009-10-22 11:18:09 ---
SVN commit 1038901 by jwienke:

Applied patch from  [hidden email] that improves light table
behaviour when deleting images. Thanks for the patch.

BUG: 210967

 M  +2 -1      NEWS  
 M  +5 -2      utilities/lighttable/lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1038901

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210967


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta6                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel