[Bug 210956] New: Zoom slider looks not centered with Oxygen style [patch]

https://bugs.kde.org/show_bug.cgi?id=210956

           Summary: Zoom slider looks not centered with Oxygen style
                    [patch]
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using Devel)
Compiler:          gcc 4.4.1
OS:                Linux
Installed from:    Compiled sources

When using Oygen widget style, the zoom slider looks off-center a few pixels.
It does, however, look fine when using other styles. I've taken a look into the
code and found the guilty line. In Dolphin, the code for setting up the zoom
slider and buttons is identical, but doesn't include this line. I've got no
clue why it's there, but removing it really helps.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210956





--- Comment #1 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-18 11:56:50 ---
Created an attachment (id=37645)
 --> (http://bugs.kde.org/attachment.cgi?id=37645)
proposed patch

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210956


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-10-18 12:19:48 ---
Right, this doesn't make sense. I'll apply your patch! Thanks...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210956





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2009-10-18 12:21:18 ---
SVN commit 1037037 by aclemens:

Let the slider decide what size to take. I'll leave this code commented if
someone really thinks we need this.

BUG:210956

 M  +1 -1      statuszoombar.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1037037

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210956





--- Comment #4 from Ignat Semenov <ragnarokk91 gmail com>  2009-10-18 16:19:56 ---
Created an attachment (id=37647)
 --> (http://bugs.kde.org/attachment.cgi?id=37647)
patch #2

It appears that setInvertedControls() in zoomSlider is unnecessary (using Qt4.6
snapshot). If it's not set, then Ctrl+Mouse Wheel Up zooms in the view and
Mouse Wheel Up over zoom slider does the same. Zoom out works fine as well.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=210956

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Usability

--
You are receiving this mail because:
You are the assignee for the bug.

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=210956

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Usability-Ergonomy

--
You are receiving this mail because:
You are the assignee for the bug.