[Bug 210907] New: Allow immediate deleting of images without diverting through the "trash-folder"

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907

           Summary: Allow immediate deleting of images without diverting
                    through the "trash-folder"
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.3.2)
Installed from:    Compiled From Sources

When sorting my images on the light table I would like to delete the bad ones
immediately for example by pressing CTRL-DEL from the filesystem, going through
the trash folder is a tedious process (deleting many 30MB files quickly is
resulting in a severe case of disk trashing) as the trash folder resides on
another disk which is quite limited in space.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #1 from  <kgw mineralien-verkauf de>  2009-10-17 20:42:45 ---
Sorry, meant this to be a wish list item...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |INVALID




--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-10-17 20:54:15 ---
Already implemented, like in every other KDE application, just press SHIFT+DEL.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|INVALID                     |




--- Comment #3 from  <kgw mineralien-verkauf de>  2009-10-17 21:00:15 ---
Sorry, but then this doesn't work! I just tried in the Light Table to delete an
image by pressing SHIFT and DEL and it does nothing!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Johannes Wienke-3]

https://bugs.kde.org/show_bug.cgi?id=210907


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Light Table




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #4 from  <kgw mineralien-verkauf de>  2009-10-23 01:23:12 ---
Created an attachment (id=37747)
 --> (http://bugs.kde.org/attachment.cgi?id=37747)
Patch to add deletion without trash via SHIFT+DEL and Toolbar in Lighttable

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2009-10-23 01:34:06 ---
The patch doesn't compile, in lighttablewindow.cpp you added a "3" in the
copyright comment which makes the file invalid :-)

For me the patch is not working, due to the following errors:
1) The normal delete method (trash delete, Del key) is dead now
2) pressing Shift+Del will call the "trash delete" method :-)

Can anyone confirm?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #6 from  <kgw mineralien-verkauf de>  2009-10-23 01:50:37 ---
@Andi, sorry abouth the 3 sneaking into the patch... As to the other problems,
it works for me...as for the DEL-key no longer working: You are correct, I just
don't know why, I didn't remove the relevant code, I just added the proposed
key sequence of SHIFT+DEL. The trash is not used when pressing SHIFT+DEL
though...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907


[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37747|0                           |1
        is obsolete|                            |




--- Comment #7 from  <kgw mineralien-verkauf de>  2009-10-23 01:59:33 ---
Created an attachment (id=37750)
 --> (http://bugs.kde.org/attachment.cgi?id=37750)
Patch to add deletion without trash via SHIFT+DEL and Toolbar in Lighttable

Corrected Version, I had added two actions under the same name into the
actionCollection ().

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=210907


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|unspecified                 |1.0.0
            Summary|Allow immediate deleting of |Allow immediate deleting of
                   |images without diverting    |images without diverting
                   |through the "trash-folder"  |through the "trash-folder"
                   |                            |[patch]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2009-10-25 02:03:52 ---
SVN commit 1039943 by aclemens:

Add permanent delete action to the light table as well.

Kgw,
I have altered your patch a lot, it had code duplication that was actually not
necessary.
Can we close this bug now?

Andi

CCBUG:210907

 M  +33 -5     lighttablewindow.cpp  
 M  +6 -0      lighttablewindow.h  
 M  +2 -0      lighttablewindow_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1039943

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #9 from  <kgw mineralien-verkauf de>  2009-10-25 08:27:58 ---
@Andi, I didn't quite understand the semantics of the dialog quite, will the
two ways to delete result in different confirmation  dialogs? What I mean is, I
might want to use the move to trash without and the delete file with
confirmation. I might have gotten it wrong as well as I don't get the dialog
anymore on both, but I don't know where to reset the question to appear at
all... Besides this quibble the bug could be closed.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #10 from Andi Clemens <andi clemens gmx net>  2009-10-25 10:51:09 ---
(In reply to comment #9)
> @Andi, I didn't quite understand the semantics of the dialog quite, will the
> two ways to delete result in different confirmation  dialogs?

Yes, it will result in the same dialogs as in AlbumUI, one for delete, the
other for trash action.

 What I mean is, I
> might want to use the move to trash without and the delete file with
> confirmation. I might have gotten it wrong as well as I don't get the dialog
> anymore on both, but I don't know where to reset the question to appear at
> all... Besides this quibble the bug could be closed.

Delete will always need confirmation, for the trash action you can set a
checkbox for "Never ask again".
To revert this, go into Settings->Misc->Confirm move to trash

Ok I will close the bug now.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #11 from  <kgw mineralien-verkauf de>  2009-10-25 11:10:34 ---
@Andi, it may be fine for you that the Delete always needs confirmation, for me
this is a big nuisance I want to get rid o, is there a way to configure the
confirmation dialog to be optional like the move to trash is?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #12 from Andi Clemens <andi clemens gmx net>  2009-10-25 11:23:13 ---
No there is no config option and I guess there will be none.
We can not satisfy every user (:-)), and I can assure you that if this would be
an option, we will get a lot of hate mails :-)

A permanent delete is a very destructive action, and most users don't want
their images to vanish that easy.

Just imagine you press the key kombination for "permanently delete" and while
you are doing this, you realize that this was a mistake. Boom... your images
are gone.
Moving them to trash without confirmation is not a big deal, you can restore it
again.

Or imagine you set this option once, but forget about it. Hitting "permanent
delete" will not ask you again, and yes, although you might know what you are
doing, others might not :-)

So from my point of view, this will not be implemented.
Gilles, Marcel,
your opinion?

Anyway just press Enter twice, shouldn't be that time consuming?

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #13 from Andi Clemens <andi clemens gmx net>  2009-10-25 12:59:32 ---
I can add such an option, let's hope we get no bugreports like "please, warn
user on permanent delete" :D

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Karl Günter Wünsch]

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #14 from  <kgw mineralien-verkauf de>  2009-10-25 13:16:14 ---
@Andi: Don't. I'll patch it for my use, I agree with your reluctance to add
this option...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #15 from Andi Clemens <andi clemens gmx net>  2009-10-25 13:25:38 ---
No, I'm adding it already.
Gilles and co think it might be useful.
The default is set to confirm, and I just saw that dolphin has such a
"dangerous" checkbox, too.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=210907





--- Comment #16 from Andi Clemens <andi clemens gmx net>  2009-10-25 13:52:02 ---
SVN commit 1040051 by aclemens:

Use "Do not ask again" option for permanent delete as well.
This is a global setting, not only true for lighttable.

CCBUG:210907

 M  +19 -5     digikam/albumsettings.cpp  
 M  +3 -0      digikam/albumsettings.h  
 M  +35 -10    libs/dialogs/deletedialog.cpp  
 M  +3 -2      libs/dialogs/deletedialog.h  
 M  +17 -15    utilities/setup/setupmisc.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1040051

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel