[Bug 209906] New: Unportable test(1) construct in cleanup_digikamdb

https://bugs.kde.org/show_bug.cgi?id=209906

           Summary: Unportable test(1) construct in cleanup_digikamdb
           Product: digikam
           Version: 1.0.0-beta5
          Platform: NetBSD pkgsrc
        OS/Version: NetBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta5 (using KDE 4.3.1)
Compiler:          n/a n/a
OS:                NetBSD
Installed from:    NetBSD pkgsrc

The script utilities/scripts/cleanup_digikamdb uses the unportable bash "=="
comparison operator for test(1). It is not supported by most other shells or
even test(1) from GNU coreutils. Please use "=" instead.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=209906





--- Comment #1 from Thomas Klausner <tk giga or at>  2009-10-08 20:55:40 ---
Created an attachment (id=37454)
 --> (http://bugs.kde.org/attachment.cgi?id=37454)
Patch fixing the problem.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=209906





--- Comment #2 from Thomas Klausner <tk giga or at>  2009-10-08 20:58:22 ---
Note: I know that it has "#!/bin/bash" at the beginning, but the script works
fine otherwise and could be changed to just use /bin/sh instead.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=209906


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from Andi Clemens <andi clemens gmx net>  2009-10-08 23:33:29 ---
SVN commit 1032924 by aclemens:

Use more portable comparison operator. Thanks to Thomas Klausner.

BUG:209906

 M  +3 -3      cleanup_digikamdb  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1032924

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=209906


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta5                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=209906

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Portability

--
You are receiving this mail because:
You are the assignee for the bug.