[Bug 208851] New: Collections: Detection of duplicate collections too strict [patch]

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=208851

           Summary: Collections: Detection of duplicate collections too
                    strict [patch]
           Product: digikam
           Version: 1.0.0-beta5
          Platform: Debian testing
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta5 (using KDE 4.3.1)
OS:                Linux
Installed from:    Debian testing/unstable Packages

Assume I have a network collection under /mnt/shares/pics. Then adding
/mnt/shared/pics-new is rejected with the message "There is already a
collection for a network share with the same path" although the new share is a
sibling, not a child. On the other hand, adding /mnt/shares is not detected as
being a parent to /mnt/shared/pics

Current codes checks if the path for a new collection is contained in the path
to existing collections. Attached patch uses KUrl::parentOf instead, and checks
relations in both directions (new.parentOf(old) and old.parentOf(new)).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=208851





--- Comment #1 from Michael G. Hansen <mike mghansen de>  2009-09-29 10:14:53 ---
Created an attachment (id=37232)
 --> (http://bugs.kde.org/attachment.cgi?id=37232)
Patch against r1028026, use KUrl::parentOf

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208851


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Database




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208851


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-09-29 10:18:49 ---
Marcel,

Patch is simple and sound fine for me... Your viewpoint ? No problem here for
you ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=208851





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-29 18:58:41 ---
Fine for me

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=208851


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Michael G. Hansen <mike mghansen de>  2009-09-30 06:26:34 ---
SVN commit 1029537 by mghansen:

Improve checks for existing collections when adding new ones.

BUG: 208851


 M  +2 -1      NEWS  
 M  +10 -3     libs/database/collectionmanager.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1029537

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=208851


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta5                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=208851

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|Database                    |Database-Setup

--
You are receiving this mail because:
You are the assignee for the bug.