[Bug 206666] New: thumbnail borders are drawn inside instead of outside the images thus hiding parts of the image

https://bugs.kde.org/show_bug.cgi?id=206666

           Summary: thumbnail borders are drawn inside instead of outside
                    the images thus hiding parts of the image
           Product: digikam
           Version: 1.0.0-beta3
          Platform: Debian testing
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta3 (using KDE 4.3.0)
OS:                Linux
Installed from:    Debian testing/unstable Packages

I have noticed that the borders that should be drawn around the thumbnails are
instead drawn inside the thumbnails. This of course hides parts of the image,
which seems negligible at first glance.

The Problem is that this behaviour heavily impacts images with important
objects near the edges, for example it's a huge difference if a person's head
is "cut off" or still on the image.

If someone needs to decide which images he should delete and which not, the
thumbnails are very important source of information and should be as accurate
as possible.


I therefore suggest that the borders are drawn outside of the thumbnails in
future versions of digiKam. This would greatly improve the user experience for
me and possibly for many others.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=206666


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Thumbnails




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-09-07 21:07:39 ---
If i remember, my code draw outside the image and do not crop contents...

Marcel, do you have changed something with QT4 model view port ?

Johannes, please test with beta4...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=206666





--- Comment #2 from Johannes Tögel <jtoegel42 gmail com>  2009-09-07 21:31:24 ---
I updated to beta4 and I've still got the same problem. It is noticeable
especially well if the thumbnails are small. Just a minute and I'll provide a
screenshot showing the problem.

Johannes

P.S.: Thanks for the immediate response!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=206666





--- Comment #3 from Johannes Tögel <jtoegel42 gmail com>  2009-09-07 21:53:34 ---
Here is the Screenshot (edited a bit for easier recognition of the problem)

http://picfront.de/d/KQOTgf2q4/digikam_croppedthumbnails.jpg


The second thumbnail under the digikam one I created myself, to be sure that it
isn't an effect caused by thumbnail generation.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=206666





--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-09-11 00:02:22 ---
I can confirm this....

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=206666





--- Comment #5 from Mikolaj Machowski <mikmach wp pl>  2009-09-12 00:39:06 ---
"thumbnails are very important source of information and should be as accurate
as possible"

True but on the other hand drawing borders "inside" of image means thumbnail
will be less minimized and details in thumbnail will be bigger. And only small
areas near borders are lost, in big majority of photos not containing important
informations.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=206666





--- Comment #6 from Johannes Tögel <jtoegel42 gmail com>  2009-09-12 07:52:43 ---
"True but on the other hand drawing borders "inside" of image means thumbnail
will be less minimized and details in thumbnail will be bigger. And only small
areas near borders are lost, in big majority of photos not containing important
informations."

No. There is so much whitespace around the thumbnails that it would be no
problem to keep the current thumbnail size AND draw the borders outside. So (of
course depending on the photographers style) some or very much images will
profit from this while the rest isn't affected negatively.

Besides that, the real problem is that the "small area" can heavily affect the
images' look, this is not the case with a somewhat smaller thumbnail.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=206666


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-21 19:39:06 ---
Johannes, your screenshot is from the thumbnail bar. Do you see this bug as
well in the main icon view?

If yes, can you please send me this butterfly picture for testing by private
mail.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=206666





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2009-09-21 20:38:03 ---
I can see this bug in thumbbar and iconview...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=206666





--- Comment #9 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-21 21:00:04 ---
Ok I found it. It is the one-pixel "highlighting" frame drawn in
ThumbnailLoadThread::slotThumbnailLoaded.
I would not like to remove this border, it has been in the digikam icon view
for ages.
The solution would be to load thumbnails always 2 pixels smaller and add the
frame.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=206666


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-09-25 21:18:40 ---
SVN commit 1028073 by mwiesweg:

Do not cut off a one-pixel line at each side, but instead load the thumbnail 2
pixels smaller
and add these by drawing the lines afterwards.

BUG: 206666

 M  +3 -1      NEWS  
 M  +14 -4     libs/threadimageio/thumbnailloadthread.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1028073

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=206666


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta3                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=206666

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Thumbs-Image                |Thumbs-RAW

--
You are receiving this mail because:
You are the assignee for the bug.