[Bug 205776] New: "Embedded preview loads full image size" does not only do what it says, confusing users
Locked
12345
12345
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files
 
|
https://bugs.kde.org/show_bug.cgi?id=205776
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|"Embedded preview loads |Option to load full image |full image size" does not |size in preview mode does |only do what it says, |not only do what it says |confusing users |with RAW files --- Comment #58 from Gilles Caulier <[hidden email]> --- Matti, What's about this file using last digiKam 4.2.0 ? Gilles Caulier -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
Stefan Brüns <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] | |e --- Comment #59 from Stefan Brüns <[hidden email]> --- Tested Digikam 4.4.0: Preview: depending on Album View -> Preview Settings -> Embedded preview loads full size image either loads embedded JPEG preview (off) or half size RAW (on) Light Table: Copies Preview settings, ignores its own setting Full Size RAW is never loaded. Test file: several Canon CR2, PowerShot S95 and EOS 350D -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
Vincent Tassy <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[hidden email] --- Comment #60 from Vincent Tassy <[hidden email]> --- Following up on the discussion in the mailing list and using Digikam 4.4.0 on Fedora 20: Looking at the code, the choice of using the embedded JPG or Half Size Raw Preview depends (between other things) on the screen resolution ... It turns out my home 27" monitor is 2560x1440 and the Embedded JPG in the Canon S100 RAW files are 1600x1200. Digikam therefore displays the Half Size Raw Preview no matter the setting in the preferences. Similar behaviour for the Canon 400D RAW files whose embedded JPG are 2.5Mpx :-( If I change my screen resolution to, say, 1920x1080, it displays the Embedded JPG ! However, the Embedded JPG of my Canon 60D CR2 are 17Mpx so for these RAW files it will indeed display the embedded JPG ... The thing is that if I manually extract the 1600x1200 JPG embedded in my RAW file and display it in digikam, it's just fine ! on my screen, it's zoomed at 96% so it's completely acceptable to view images of this size as previews ! I'm therefore thinking that the heuristics are not good as is ... Maybe choice should be left to the end user by the addition of a second checkbox in the settings (as suggested in other comments) ? -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #61 from Gilles Caulier <[hidden email]> --- Vincent, I think i found where is the problem. The option from digiKam/Config/AlbumView/Preview Load Full Image is well used by Preview widget. Setting is passed into these methods : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/graphicsview/dimgpreviewitem.cpp#L301 https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/graphicsview/dimgpreviewitem.cpp#L146 In both case d->loadFullImageSize is settings from Config dialog. Depending of bool value, we will call PreviewLoadThread::loadHighQuality() or PreviewLoadThread::load(). The first one is not a problem. As expected it load full image. The second one use an argument which is the minimum image size to load (d->previewSize). Look how it set this integer value : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/widgets/graphicsview/dimgpreviewitem.cpp#L82 Typically, size is bounded between VGA to WQXGA resolutions. We need to be sure if this minimum image size is correctly set with you high resolution displays. Gilles Caulier -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #62 from Gilles Caulier <[hidden email]> --- Vincent, The second point to check is code from PreviewTask is well adapted to all situation. I add comment and i polished source code. Look here : https://projects.kde.org/projects/extragear/graphics/digikam/repository/revisions/master/entry/libs/threadimageio/previewtask.cpp Code relevant to load preview is given from line 211 to line 460. The rest is cache management and post processing. You can see the different between RAW and non RAW image. Note that in your case, the "dcraw -e " to extract manually embedded JPEG is performed by KDcrawIface::KDcraw::loadEmbeddedPreview(). Gilles Caulier -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #63 from Vincent Tassy <[hidden email]> --- Ok, I did a little gdb session and here's what I I saw: First of all, my screen resolution is 2560x1440 RAW file being displayed is 4000x3000 JPG preview embedded in the RAW file is 1600x1200 in dimgpreviewitem.cpp, the previewSize is set to 2560 Then, when stepping through previewtask.cpp line 213: size = 2560 (which is the previewSize set before and = width of my screen) line 241: bestSize = 4000 (this is the width of my RAW image) line 247: bestSize = 2000 (4000 / 2) line 259: aBitSmallerThanSize = 2048 (2560 * 0.8) line 260: sizeLimit = 2000 line 293: KDCRaw loads the preview : width = 1600 and height = 1200 (correct) The test takes us to line 305 (loadHalfPreview) since 1600 < 2000 So the behaviour is correct, all the sizes (screen , image, embedded jpg) are properly discovered. The "problem" is therefore the heuristics because as I explained in the forum, displaying a 1600x1200 image on my screen is fine ! zoom level is 92% If we're going to keep the heuristics to take the decision, then maybe we should look at the size of the preview area instead of looking at the entire screen resolution ? On my system, where digikam is always maximized, that area is roughly 1700x1100 ... It also makes sense if you are not using digikam in maximized mode, what's the point in looking at the entire screen size if we don't have access to it :/ Looking forward to hearing your thoughts ! -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #64 from Vincent Tassy <[hidden email]> --- Created attachment 89490 --> https://bugs.kde.org/attachment.cgi?id=89490&action=edit Use preview area size instead of screen resolution Use the preview area size instead of the entire screen resolution when making the decision to load the embedded JPG preview or the half size preview. This reflects the reality of the space available for display ! (window maximized or not, sidebars opened or not, etc) Here's the behavior now on my WQXGA screen (2560x1440) with a 4000x3000 RAW file containing a 1600x1200 JPG preview: Window maximized + Left sidebar open + Right Sidebar open: digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - size = 1688 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - bestSize = 4000 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - bestSize = 2000 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - aBitSmallerThanSize = 1350 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - sizeLimit = 1350 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - exiv2 Preview largest dimension >= sizeLimit ( 1600 >= 1350 ) digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - Loading embedded preview Window maximized + Left sidebar open + Right Sidebar closed: digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - size = 1925 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - bestSize = 4000 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - bestSize = 2000 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - aBitSmallerThanSize = 1540 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - sizeLimit = 1540 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - exiv2 Preview largest dimension >= sizeLimit ( 1600 >= 1540 ) digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - Loading embedded preview Window maximized + Left sidebar closed + Right Sidebar closed: digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - size = 2494 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - bestSize = 4000 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - bestSize = 2000 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - aBitSmallerThanSize = 1995 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - sizeLimit = 1995 digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - kdcrawPreview largest dimension < sizeLimit ( 1600 < 1995 ) digikam(1592)/digikam (core) Digikam::PreviewLoadingTask::execute: Preview Loading - Loading half preview That's the behavior I expected. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #65 from DrSlony <[hidden email]> --- Could someone please summarize what the final behavior is? For my purposes, any preview which does not show me what I explicitly desire to see and is not intuitive and predictable is fundamentally flawed. I explained my suggested behavior in Bug 319241. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #66 from Vincent Tassy <[hidden email]> --- Current behavior is the same as before so for RAW files: option checked in the settings: Always display Half Size preview option unchecked in the settings: If embedded JPG is large enough, display it If not, display Half Size preview The only difference is that with the patch I submitted, the decision whether the embedded JPG is large enough is based on the size of the preview area and not the entire screen resolution so behavior will change if the window is maximized or not, if the sidebars are opened or not, etc ... In the end, I guess the idea is to support all possible RAW/EmbeddedJPG combination ... so if a RAW file's largest embedded JPG is much smaller than the preview area, there's no point in displaying it ! not good enough as a preview so instead let's display a fast processing of the RAW ... I was originally in line with your requirements but then, thinking about it, I guess it could be problematic to FORCE loading the embedded preview because if you have RAW files with too small embedded JPGs, you would have to switch the option to view these files correctly, and then switch again for others, it would be unpractical. I myself have 3 different types of RAW files and am not facing the situation I'm describing so I'm not serving my own purpose here ;) but I'm just guessing this is the reason these "heuristics" have been implemented in the first place ... -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Option to load full image |Option to load full image |size in preview mode does |size in preview mode does |not only do what it says |not only do what it says |with RAW files |with RAW files [patch] -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|0.10.0 |4.4.0 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|RAW files management |Preview -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
Gilles Caulier <[hidden email]> changed: What |Removed |Added ---------------------------------------------------------------------------- Version Fixed In|2.5.0 | -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #67 from DrSlony <[hidden email]> --- Thank you for explaining that. For people with screens 4MP and larger (or cameras that write small JPEG previews) the heuristics become messy, impossible to predict. Taking this into account, I would propose the following choice for raw files (again empowering the user): ● Automatic preview (this is using your heuristics). ○ Fast demosaiced image (full resolution fast demosaic). ○ Fast demosaiced half-resolution image (optional choice mayb useful for those with 36MP cameras). ○ High quality demosaiced image (AMaZE or whatever). ○ Largest embedded JPEG preview. ○ Largest embedded JPEG preview, high quality demosaiced image on keyboard shortcut. Explanation for the last option: the JPEG preview is almost never representative of the raw data. When checking hundreds of raw shots for sharp focus, the JPEG is enough. When checking for over/under-exposure, demosaicing is the safe choice. While quickly browsing through shots, would be nice to be able to hit a keyboard shortcut to quickly render a demosaiced preview to screen. Yes this last option is a separate feature request, but I thought I'd mention it here as it involved the other changes. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #68 from Marcel Wiesweg <[hidden email]> --- The heuristics were indeed implemented with regards to some RAW images (older formats in my test collection) which only had very small embedded previews. I am open for a refined proposal here. I the fast demosaiced algorithm readily available for us? What we need should find its way into libraw for us to use it. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #69 from DrSlony <[hidden email]> --- No problem. amsterdam.pef from http://rawtherapee.com/shared/test_images/amsterdam.pef YA-DSC_1900.NEF from http://www.imaging-resource.com/PRODS/nikon-d810/nikon-d810GALLERY.HTM Demosaicing times (median of 5 runs): Pentax K10D PEF 10.1MP using "fast" took 74ms. Pentax K10D PEF 10.1MP using "AMaZE" took 368ms. Nikon D810 NEF 36.3MP using "fast" took 251ms. Nikon D810 NEF 36.3MP using "AMaZE" took 1292ms. Gentoo Linux 3.17.2 x86_64 Intel(R) Core(TM) i7 CPU Q 820 @ 1.73GHz Used RawTherapee: for n in {1..5}; do ~/rt_default_Release_stopwatch/rawtherapee -o /dev/null/foo.tif -p /tmp/fast.pp3 -b8 -t -c /tmp/YA-DSC_1900.NEF; done "Fast" https://code.google.com/p/rawtherapee/source/browse/rtengine/fast_demo.cc "AMaZE" https://code.google.com/p/rawtherapee/source/browse/rtengine/amaze_demosaic_RT.cc -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #70 from Matti Rintala <[hidden email]> --- Although I'm not currently using Digikam in my workflow (this may change again in the future), I'll add a small comment as I originally filed this "bug". The embedded preview and previews created from raw data have really different processing done to them (by the camera for embedded previews, by the raw decoder in the other case). The resulting image may look very different. That's why I think it's important that what is shown to the user is *consistent*, otherwise it becomes difficult to preview images if they sometimes have camera's processing done to them, sometimes not. Making the choice based on screen resolution is problematic if the user does changes between monitors (laptop user sometimes using external display, sometimes laptop's screen). Using the preview are size is even more problematic if Digikam is not used fullscreen, then just changing the window size may change the preview method (if I understood correctly). I personally vote for letting the user choose the method and not using heuristics. But since the heuristics may be good for people with multiple cameras, what about letting the user choose the minimum embedded preview size? If the embedded preview is larger than this size, it is show. Otherwise a preview is generated from raw data? -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #71 from Marcel Wiesweg <[hidden email]> --- Git commit b56fc72ca455da8844011e78880e0cd1dbf4bd81 by Marcel Wiesweg. Committed on 14/11/2014 at 17:57. Pushed by mwiesweg into branch 'master'. Adapt image preview loading to use the new settings. PreviewTask is restructured and much cleaner now. M +3 -1 libs/threadimageio/loadingdescription.cpp M +4 -10 libs/threadimageio/loadingdescription.h M +37 -14 libs/threadimageio/previewloadthread.cpp M +22 -5 libs/threadimageio/previewloadthread.h M +204 -228 libs/threadimageio/previewtask.cpp M +13 -3 libs/threadimageio/previewtask.h M +2 -2 libs/threadimageio/thumbnailloadthread.cpp http://commits.kde.org/digikam/b56fc72ca455da8844011e78880e0cd1dbf4bd81 --- Comment #72 from Marcel Wiesweg <[hidden email]> --- Git commit 9ddedf90d4de2a504a0feb71de5064b209207422 by Marcel Wiesweg. Committed on 14/11/2014 at 17:58. Pushed by mwiesweg into branch 'master'. Apply settings UI for previews: () Fast preview () High quality preview RAW: - Automatic - Always embedded preview - Always half-size demosaic M +43 -2 app/settings/applicationsettings.cpp M +3 -2 app/settings/applicationsettings.h M +4 -4 app/settings/applicationsettings_iconview.cpp M +2 -2 app/settings/applicationsettings_p.cpp M +5 -1 app/settings/applicationsettings_p.h M +1 -1 app/utils/slideshowbuilder.cpp M +2 -1 app/views/imagepreviewview.cpp M +48 -14 utilities/setup/setupalbumview.cpp http://commits.kde.org/digikam/9ddedf90d4de2a504a0feb71de5064b209207422 --- Comment #73 from Marcel Wiesweg <[hidden email]> --- Git commit 7edc98d1efc9da7104bdd13379295047029d9fc5 by Marcel Wiesweg. Committed on 14/11/2014 at 18:00. Pushed by mwiesweg into branch 'master'. Adapt to PreviewSettings everywhere. Import tool has its own, simpler settings. LightTable reuses main settings. M +1 -0 CMakeLists.txt M +2 -1 libs/widgets/graphicsview/dimgitemspriv.h M +16 -19 libs/widgets/graphicsview/dimgpreviewitem.cpp M +2 -1 libs/widgets/graphicsview/dimgpreviewitem.h M +4 -1 utilities/importui/views/importpreviewview.cpp M +3 -3 utilities/lighttable/lighttableview.cpp M +3 -1 utilities/lighttable/lighttableview.h M +6 -4 utilities/lighttable/lighttablewindow.cpp M +1 -1 utilities/lighttable/lighttablewindow.h M +1 -6 utilities/maintenance/fingerprintstask.cpp M +1 -6 utilities/maintenance/imagequalitytask.cpp M +5 -5 utilities/setup/setuplighttable.cpp M +10 -24 utilities/slideshow/slideimage.cpp M +3 -1 utilities/slideshow/slideimage.h M +1 -1 utilities/slideshow/slideshow.cpp M +0 -1 utilities/slideshow/slideshowsettings.cpp M +2 -1 utilities/slideshow/slideshowsettings.h http://commits.kde.org/digikam/7edc98d1efc9da7104bdd13379295047029d9fc5 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #71 from Marcel Wiesweg <[hidden email]> --- Git commit b56fc72ca455da8844011e78880e0cd1dbf4bd81 by Marcel Wiesweg. Committed on 14/11/2014 at 17:57. Pushed by mwiesweg into branch 'master'. Adapt image preview loading to use the new settings. PreviewTask is restructured and much cleaner now. M +3 -1 libs/threadimageio/loadingdescription.cpp M +4 -10 libs/threadimageio/loadingdescription.h M +37 -14 libs/threadimageio/previewloadthread.cpp M +22 -5 libs/threadimageio/previewloadthread.h M +204 -228 libs/threadimageio/previewtask.cpp M +13 -3 libs/threadimageio/previewtask.h M +2 -2 libs/threadimageio/thumbnailloadthread.cpp http://commits.kde.org/digikam/b56fc72ca455da8844011e78880e0cd1dbf4bd81 --- Comment #72 from Marcel Wiesweg <[hidden email]> --- Git commit 9ddedf90d4de2a504a0feb71de5064b209207422 by Marcel Wiesweg. Committed on 14/11/2014 at 17:58. Pushed by mwiesweg into branch 'master'. Apply settings UI for previews: () Fast preview () High quality preview RAW: - Automatic - Always embedded preview - Always half-size demosaic M +43 -2 app/settings/applicationsettings.cpp M +3 -2 app/settings/applicationsettings.h M +4 -4 app/settings/applicationsettings_iconview.cpp M +2 -2 app/settings/applicationsettings_p.cpp M +5 -1 app/settings/applicationsettings_p.h M +1 -1 app/utils/slideshowbuilder.cpp M +2 -1 app/views/imagepreviewview.cpp M +48 -14 utilities/setup/setupalbumview.cpp http://commits.kde.org/digikam/9ddedf90d4de2a504a0feb71de5064b209207422 --- Comment #73 from Marcel Wiesweg <[hidden email]> --- Git commit 7edc98d1efc9da7104bdd13379295047029d9fc5 by Marcel Wiesweg. Committed on 14/11/2014 at 18:00. Pushed by mwiesweg into branch 'master'. Adapt to PreviewSettings everywhere. Import tool has its own, simpler settings. LightTable reuses main settings. M +1 -0 CMakeLists.txt M +2 -1 libs/widgets/graphicsview/dimgitemspriv.h M +16 -19 libs/widgets/graphicsview/dimgpreviewitem.cpp M +2 -1 libs/widgets/graphicsview/dimgpreviewitem.h M +4 -1 utilities/importui/views/importpreviewview.cpp M +3 -3 utilities/lighttable/lighttableview.cpp M +3 -1 utilities/lighttable/lighttableview.h M +6 -4 utilities/lighttable/lighttablewindow.cpp M +1 -1 utilities/lighttable/lighttablewindow.h M +1 -6 utilities/maintenance/fingerprintstask.cpp M +1 -6 utilities/maintenance/imagequalitytask.cpp M +5 -5 utilities/setup/setuplighttable.cpp M +10 -24 utilities/slideshow/slideimage.cpp M +3 -1 utilities/slideshow/slideimage.h M +1 -1 utilities/slideshow/slideshow.cpp M +0 -1 utilities/slideshow/slideshowsettings.cpp M +2 -1 utilities/slideshow/slideshowsettings.h http://commits.kde.org/digikam/7edc98d1efc9da7104bdd13379295047029d9fc5 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
[digikam] [Bug 205776] Option to load full image size in preview mode does not only do what it says with RAW files [patch]
|
|
In reply to this post by Bugzilla from bitti@cs.tut.fi
https://bugs.kde.org/show_bug.cgi?id=205776
--- Comment #71 from Marcel Wiesweg <[hidden email]> --- Git commit b56fc72ca455da8844011e78880e0cd1dbf4bd81 by Marcel Wiesweg. Committed on 14/11/2014 at 17:57. Pushed by mwiesweg into branch 'master'. Adapt image preview loading to use the new settings. PreviewTask is restructured and much cleaner now. M +3 -1 libs/threadimageio/loadingdescription.cpp M +4 -10 libs/threadimageio/loadingdescription.h M +37 -14 libs/threadimageio/previewloadthread.cpp M +22 -5 libs/threadimageio/previewloadthread.h M +204 -228 libs/threadimageio/previewtask.cpp M +13 -3 libs/threadimageio/previewtask.h M +2 -2 libs/threadimageio/thumbnailloadthread.cpp http://commits.kde.org/digikam/b56fc72ca455da8844011e78880e0cd1dbf4bd81 --- Comment #72 from Marcel Wiesweg <[hidden email]> --- Git commit 9ddedf90d4de2a504a0feb71de5064b209207422 by Marcel Wiesweg. Committed on 14/11/2014 at 17:58. Pushed by mwiesweg into branch 'master'. Apply settings UI for previews: () Fast preview () High quality preview RAW: - Automatic - Always embedded preview - Always half-size demosaic M +43 -2 app/settings/applicationsettings.cpp M +3 -2 app/settings/applicationsettings.h M +4 -4 app/settings/applicationsettings_iconview.cpp M +2 -2 app/settings/applicationsettings_p.cpp M +5 -1 app/settings/applicationsettings_p.h M +1 -1 app/utils/slideshowbuilder.cpp M +2 -1 app/views/imagepreviewview.cpp M +48 -14 utilities/setup/setupalbumview.cpp http://commits.kde.org/digikam/9ddedf90d4de2a504a0feb71de5064b209207422 --- Comment #73 from Marcel Wiesweg <[hidden email]> --- Git commit 7edc98d1efc9da7104bdd13379295047029d9fc5 by Marcel Wiesweg. Committed on 14/11/2014 at 18:00. Pushed by mwiesweg into branch 'master'. Adapt to PreviewSettings everywhere. Import tool has its own, simpler settings. LightTable reuses main settings. M +1 -0 CMakeLists.txt M +2 -1 libs/widgets/graphicsview/dimgitemspriv.h M +16 -19 libs/widgets/graphicsview/dimgpreviewitem.cpp M +2 -1 libs/widgets/graphicsview/dimgpreviewitem.h M +4 -1 utilities/importui/views/importpreviewview.cpp M +3 -3 utilities/lighttable/lighttableview.cpp M +3 -1 utilities/lighttable/lighttableview.h M +6 -4 utilities/lighttable/lighttablewindow.cpp M +1 -1 utilities/lighttable/lighttablewindow.h M +1 -6 utilities/maintenance/fingerprintstask.cpp M +1 -6 utilities/maintenance/imagequalitytask.cpp M +5 -5 utilities/setup/setuplighttable.cpp M +10 -24 utilities/slideshow/slideimage.cpp M +3 -1 utilities/slideshow/slideimage.h M +1 -1 utilities/slideshow/slideshow.cpp M +0 -1 utilities/slideshow/slideshowsettings.cpp M +2 -1 utilities/slideshow/slideshowsettings.h http://commits.kde.org/digikam/7edc98d1efc9da7104bdd13379295047029d9fc5 -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ Digikam-devel mailing list [hidden email] https://mail.kde.org/mailman/listinfo/digikam-devel |
«
Return to digikam-devel
|
1 view|%1 views
| Free forum by Nabble | Edit this page |