[Bug 205001] New: MapSearch: Merge overlapping markers to clusters

https://bugs.kde.org/show_bug.cgi?id=205001

           Summary: MapSearch: Merge overlapping markers to clusters
           Product: digikam
           Version: unspecified
          Platform: Debian testing
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Map Searches
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta3+svn (using KDE 4.3.0)
OS:                Linux
Installed from:    Debian testing/unstable Packages

In the digikam-svn version, the map search tool displays markers for the images
it found on the map. However, the density of the markers can be very high at
times, so you end up with a bunch of markers overlapping which is not very
useful. One solution that I have seen is clustering:

http://googlegeodevelopers.blogspot.com/2009/04/markerclusterer-solution-to-too-many.html

I have made an attempt to apply this clustering to the mapwidget, attached as a
patch. Instead of individual markers, it just shows circles with the number of
images at a particular point.

There are two different ways to form the clusters from the markers, implemented
in MarkerClusterHolder::reorderClustersSimple and
MarkerClusterHolder::reorderClustersPixelGrid, please try both and tell me what
you think. (uncomment the one you want in MarkerClusterHolder::reorderClusters)

What's not implemented but could probably be added:
- highlight clusters when a user selects an image in the album view
- narrow down the search when the user clicks on a cluster
- revert to simple markers for clusters with only one marker
- show clusters when there is no selection on the map to make it easier to
select an area of interest
- make the clusters better looking as in the Google Maps demo

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #1 from Michael G. Hansen <mhansen mghansen de>  2009-08-24 20:52:17 ---
Created an attachment (id=36413)
 --> (http://bugs.kde.org/attachment.cgi?id=36413)
Patch for clustering of markers against r1014109. Work in progress

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #2 from Michael G. Hansen <mhansen mghansen de>  2009-08-24 20:57:12 ---
Created an attachment (id=36414)
 --> (http://bugs.kde.org/attachment.cgi?id=36414)
Screenshot of clustering feature

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |1.0.0




--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-08-24 22:22:23 ---
Michael,

I'm very impressioned by your patch. great work. I will review it soon, before
beta4 planed at end of this week, to include it in this release...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36413|0                           |1
        is obsolete|                            |




--- Comment #4 from Michael G. Hansen <mhansen mghansen de>  2009-08-26 21:34:12 ---
Created an attachment (id=36474)
 --> (http://bugs.kde.org/attachment.cgi?id=36474)
Map clustering, new version

New version:
- some refactoring (will do more tomorrow)
- selecting images in the icon view highlights the corresponding markers
- support for highlighting clusters by moving the mouse over them and pressing
shift (currently only one cluster can be highlighted this way at once)

left to do:
- select images when a cluster is highlighted by mouse
- find better colors for clusters and highlights
- select size steps for clusters
- currently the clusters steal some markers from each other, but this is the
only easy way to get them far enough apart. Might try a better implementation
tomorrow

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36474|0                           |1
        is obsolete|                            |




--- Comment #5 from Michael G. Hansen <mhansen mghansen de>  2009-08-27 16:39:19 ---
Created an attachment (id=36502)
 --> (http://bugs.kde.org/attachment.cgi?id=36502)
Map clustering, supports additional filtering and bi-directonal selections

added:
- selections synchronized between icon view and map, use
shift+left_mouse_button to select clusters
- filtering the icon view by clusters: control+left_mouse_button on a cluster
hides images from other clusters. Other clusters are grayed out, if you click
them, their images become visible as well. Note that this filtering does not
get saved in the map searches!
- selections and filtering: selection and filtering is stored for markers,
because the clusters are too fragile. A cluster can become partially
selected/filtered when it is formed from other clusters. Clicking with
control/shift+LMB cycles through partially-all-none.
- the MarkerClusterHolder code is intentionally separated from the rest, so it
can be used in other projects

left to do:
- disable selection and filtering in the map on the right side of digikam
- find better colors for clusters and highlights
- select size steps for clusters
- currently the clusters steal some markers from each other, but this is the
only easy way to get them far enough apart. Might try a better implementation
tomorrow
- more code documentation

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-08-27 20:04:20 ---
Excelent job. Continue. Big thanks.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #7 from Mikolaj Machowski <mikmach wp pl>  2009-08-27 22:02:53 ---
Truly amazing! Great feature, thanks.

One thing I am missing - easy switching between clusters. Now I use Ctrl+LMB to
select cluster, Ctrl+LMB to select next one and have to return to old cluster
to hide images from old location. Bit awkward - but have no idea how to do this
interface-wise :(

Bug: select area with several clusters, all are highlighted and images shown.
Select one cluster, only images from this cluster are shown. Once again select
the original area - all clusters are highlighted but only images from selected
cluster are shown. IMO all images should be shown again.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #8 from Mikolaj Machowski <mikmach wp pl>  2009-08-27 22:18:37 ---
Another bug: right side Geolocation panel was affected - when selecting image
with geolocation data it should be centered with place where geolocation data
points. Now it only adds circle with number and doesn't move viewport at all.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36502|0                           |1
        is obsolete|                            |




--- Comment #9 from Michael G. Hansen <mhansen mghansen de>  2009-08-28 11:59:05 ---
Created an attachment (id=36531)
 --> (http://bugs.kde.org/attachment.cgi?id=36531)
Map clustering, against r1014109

- fixes the two bugs reported by Mikolaj

Mikolaj wrote:
> One thing I am missing - easy switching between clusters. Now I use Ctrl+LMB
> to select cluster, Ctrl+LMB to select next one and have to return to old
> cluster to hide images from old location. Bit awkward - but have no idea how
> to do this interface-wise :(
Good point. I now made Ctrl+LMB select clusters on their own. If you click on a
cluster, it will deselect the old one. But you can use Shift+Ctrl+LMB to select
multiple clusters at once now. Shift+LMB is unchanged. One would probably
expect Ctrl to alter the shift-select-behavior, but we are running out of
modifier keys... ;-)

- add tooltips as a replacement for labels on Marble's placemarks. Tooltips
show the filenames, but are only shown for clusters with up to three markers,
otherwise the tooltip would get too big. Tooltips are only enabled in the Image
Properties Map on the right side, not in the search map.
- fix another bug whether the filter was not reset when switching from the map
search tab to another tab
- partially selected clusters have their stroke circle now dotted, fully
selected clusters have solid lines

Gilles, if you plan to include this feature in beta4, please let me know if
there are any changes you'd like me to make, or a higher revision number to
test it with (I am still at r1014109, because I did not want to risk breaking
my build). I can probably do some more changes until noon of Saturday.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #10 from Mikolaj Machowski <mikmach wp pl>  2009-08-28 12:27:41 ---
Thank you very much :)

Cannot test new version now but I think selecting of clusters one by one (not
adding) should be done with Ctrl+Shift+LMB. Awkward but Ctrl+LMB behavior is
like in all other places where Ctrl+LMB adds or removes from selection.

Another feature which could be handy: use clusters for quick navigation and
zooming.

Double click (is is possible with Marble widget?) will "decluster" clicked
marker and zoom to next level of clusters. Example - you see whole world, with
markers in Europe, America, Africa. Double click on Europe marker and continent
is zoomed in with visible clusters in regions like Iberia, Balkans,
Scandinavia, etc. This would offer quick and easy navigation and zooming. Last
stage would be miniature thumbnails placed on map where are individual photos
(like in Google Maps). Altough I think this last feature will be available in
Marble only in next generation (as was written on some Marble related blog).

I don't have GPS and always had to geolocate manually. Thanks to Gilles great
kipi-plugin it wasn't hard, just slightly boring. With this feature it is easy
to visualize my journeys and have some fun from GPS tags :)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2009-08-28 12:36:57 ---
Michael,

I'm very busy at home, so i plan to delay little 1.0.0-beta4 release, probably
next week.

So let's go to continue your great work. congratulations in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #12 from Arnd Baecker <arnd baecker web de>  2009-08-28 14:54:22 ---
Michael, though I haven't tested it yet, this sounds like an extremely
nice set of features. Thanks a lot!!!

Just two remarks, also related to Mikolaj's last comment:
When a "cluster" only contains one image, it might be nice that on
mouse-over one sees a little thumbnail image (just a few pixels).
In principle this could be realized by a few lines of simple kml
(though it might be that marble does not support the corresponding elements
yet;
at least last time I checked it did not work). If that's of interest,
I could post an example on how to do that.

In addition to using auto-clustering of geo-localized images, there
is also another approach: for example for a holiday trip
one may select one image which represents the whole trip.
This image (with a special marker) becomes visible on a (specified)
low zoom level (ie far away). Then for each day of a trip one can
define further selected images, which become visible at other zoom levels (ie
when zooming in).
I am using something like this for quite a while via google-earth
with some additional files in each digikam folder and some
hand-written python scripts.
Having such type of functionality integrated in digikam might be of interest
to others as well.
(I am aware that this is in a different direction than the clustering,
but in combination this would be very cool ...).

Best, Arnd

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36531|0                           |1
        is obsolete|                            |




--- Comment #13 from Michael G. Hansen <mhansen mghansen de>  2009-09-01 16:33:58 ---
Created an attachment (id=36617)
 --> (http://bugs.kde.org/attachment.cgi?id=36617)
Map clustering, against r1018188

new version:
- patch confirmed to work up to r1018188
- display thumbnails for clusters with only one image
- painting through callback-plugin for Marble, now clusters do not paint over
the grid/compass/etc. anymore. If the plugin is not available, painting is done
through customPaint as before. The plugin has to be shipped as a separate
shared library, currently there is no way to add a plugin from within the
application. Torsten of Marble has indicated interest in a patch, I will try to
come up with one, but it will take time until we can actually use it.

Mikolaj: I like suggestion for "zooming into a cluster" and will try to
integrate it next time. Showing images on the map is available now!

Arnd: I think we could get something similar to your idea by just using the
oldest|newest|highest rated|album-thumbnail picture when there are multiple
images in a cluster. Oldest and newest should be easy to implement, but will
require a configuration interface.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2009-09-01 20:05:57 ---
The patch do not compile with KDE 4.2.1 :

Generating externaldraw.moc
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/libs/imageproperties/markerclusterholderplugin/externaldraw.h:42:
Error: Undefined interface
automoc4: process for
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/libs/imageproperties/markerclusterholderplugin/externaldraw.moc
failed: Unknown error
pid to wait for: 0
returning failed..

Sound like marble API problem. Your patch need to check marblewidget version to
see if code can be compiled.

Another little problem : moc files inclusion :  externaldraw.moc and
markerclusterholder.moc are missing

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #15 from Mikolaj Machowski <mikmach wp pl>  2009-09-03 00:15:22 ---
Works great :)

One thing: in geolocation panel on right side when you select one image its
thumbnail is displayed, great. But this is small thumb (and this is OK) and
over this small thumbnail crosshairs are overlayed. Not big, but big enough to
cover image and limit its readability. Also when more that one image is
selected crosshairs are making number with count of images barely readable.

First I was thinking 'Is it possible to turn off that cross?' but this is
useful for zooming to point where center zooming point is. Any ideas how to
solve that?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36617|0                           |1
        is obsolete|                            |




--- Comment #16 from Michael G. Hansen <mhansen mghansen de>  2009-09-03 12:11:50 ---
Created an attachment (id=36651)
 --> (http://bugs.kde.org/attachment.cgi?id=36651)
Map clustering, new version

- fix moc-issue
- patch now compiles without marble, with marble from kde 4.2.2, with marble
from kde 4.3. I hope compilation with kde 4.2.1 works now, too.
- mouse-interaction does not work correctly with marble from kde 4.2.2, so it
was deactivated for that version

Mikolaj:
Yes, the crosshairs does get in the way! I moved the rendering up above the
coordinate grid, so that is out of the way. Disabling the crosshairs is not an
option, so I don't know what to do.
For the zooming-on-cluster option: It seems that Marble does not currently have
a method for zooming into a bounding box, so this will not be as easy. We'll
see!

left to do:
- adjust indentation in markerclusterholder-files to digikam coding guidelines,
it was reset somehow
- find a way to set a bounding box on Marble

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2009-09-03 12:46:39 ---
Michael,

Just tested. One word: great !!!!

By "find a way to set a bounding box on Marble", do you mean to draw the area
rectangle corresponding to selection done previously in map search view from
the left sidebar ? This rectangle is save in map search virtual folder
properties from Database. It will be nice to see this selection as an overlay
behind the map.

What do you think about ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #18 from Mikolaj Machowski <mikmach wp pl>  2009-09-03 12:56:42 ---
Michael: cannot test now but did you move thumbnail "over" crosshairs (z-index
"infinity")? If it is so I think this is OK solution, complete turn off of it
could be harmful - problems with zooming.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #19 from Michael G. Hansen <mhansen mghansen de>  2009-09-03 13:06:48 ---
Gilles:
Thanks ;-)
By "find a way to set a bounding box on Marble", I meant when I have the
bounding box around all markers in a cluster in latitudes and longitudes, I
don't know how to tell Marble to zoom to that area. I can set the center, but
still have to figure out the zoom/altitude. This would be used to zoom in on a
particular cluster.
The rectangle corresponding to the map search could be visualized, too, it
think. I'll add it to my list. We could also zoom into the search area when a
saved search is activated, if we get the bounding-box issue solved.

Mikolaj:
No, I moved it between the crosshairs and the coordinate grid. But maybe it is
okay to cover it when there is a cluster in the center.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel