[Bug 205001] New: MapSearch: Merge overlapping markers to clusters

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #20 from Mikolaj Machowski <mikmach wp pl>  2009-09-03 19:53:22 ---
Bug, latest patch:

I have two clusters in left panel, select one, enter preview mode. Browsing
through this cluster. Change cluster with Ctrl+LMC. Blank screen.

In such case I see two possible solutions: exit preview mode and show list of
images from second cluster or immediately enter in preview mode with first
image from second cluster shown.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #21 from Michael G. Hansen <mhansen mghansen de>  2009-09-03 20:03:10 ---
Mikolaj:
Sorry, I don't understand what you are doing exactly. Can you post a few
screenshots? I tried, but could not reproduce a blank screen. Which version of
Marble do you have?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #22 from Mikolaj Machowski <mikmach wp pl>  2009-09-03 20:57:12 ---
It is not blank screen in Marble area but in main Album GUI.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #23 from Mikolaj Machowski <mikmach wp pl>  2009-09-03 21:05:14 ---
Created an attachment (id=36669)
 --> (http://bugs.kde.org/attachment.cgi?id=36669)
bug with none image selected

digiKam is in preview mode, previously was selected cluster in lower right
with 4 images, now I selected with Ctrl+LMB cluster in lower left with 3
images. Images are visible in thumbnail list but nothing is shown in main
area.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36651|0                           |1
        is obsolete|                            |




--- Comment #24 from Michael G. Hansen <mhansen mghansen de>  2009-09-07 21:26:27 ---
Created an attachment (id=36777)
 --> (http://bugs.kde.org/attachment.cgi?id=36777)
Map clustering, new version

new version:
- instant popup of map theme menu
- thumbnails for clusters with multiple images
- thumbnails configurable through map theme menu
- shows selected search area on the map

Question:
Should the map search by updated when the user deletes/moves/rates images?
Currently it does not, and also the Timeline-search does not update, either.

Gilles:
We can show the selected search area now. It is stored as a rectangle
internally, but when drawn on the map, it can look like a trapezoid depending
on the projection. This might be confusing to some users, but I do not know a
better solution.

Mikolaj:
Thanks for the new description and the screenshot, I understand the problem
now. But I do not know yet how to solve it exactly. When not using geosearch,
and you use the mime-type filter, and go for example from "JPEG Files" to "PNG
Files" while in preview mode, the problem does not occur. I do not know yet
where the clustering code's interaction with the filters is different for the
mime-type code.

Arnd:
Does the preview of multiple images come close to what you suggested?

left to do:
- adjust indentation in markerclusterholder-files to digikam coding guidelines,
it was reset somehow
- find a way to set a bounding box on Marble
- update the map search when images in the database are changed
- solve problem with previewed images in the main view when clusters are
changed

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #25 from Arnd Baecker <arnd baecker web de>  2009-09-13 11:01:41 ---
Michael, all this sounds brilliant, and pretty much like what I had in mind.
To comment in a qualified way, I need to get the svn version working
properly: after some fiddling around with CMakeLists.txt it compiles fine
but currently I cannot change the map theme (using the new small button).
As I am not sure if this was caused with my fiddling, I need to further
investigate this before applying and testing your patch...
Thanks a lot for your work, best Arnd

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2009-09-13 11:13:09 ---
>Gilles:
>We can show the selected search area now. It is stored as a rectangle
>internally, but when drawn on the map, it can look like a trapezoid depending
>on the projection. This might be confusing to some users, but I do not know a
>better solution.

Michael,

I have no idea exactly, but i'm sure that marblewidget has API for that.
I CC marble team (Patrick and Torsten) for more details.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #27 from Mikolaj Machowski <mikmach wp pl>  2009-09-13 11:19:20 ---
Tested latest patch and there is regression unfortunately: don't see image
thumbnails in 1 item "clusters".

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #28 from Michael G. Hansen <mhansen mghansen de>  2009-09-13 11:43:33 ---
(In reply to comment #27)
> Tested latest patch and there is regression unfortunately: don't see image
> thumbnails in 1 item "clusters".

You can/have to use the configure the thumbnails through the map-settings menu
now. I think the default setting is "off" for single-image thumbnails.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36777|0                           |1
        is obsolete|                            |




--- Comment #29 from Michael G. Hansen <mike mghansen de>  2009-09-23 19:14:12 ---
Created an attachment (id=37132)
 --> (http://bugs.kde.org/attachment.cgi?id=37132)
Map clustering, new version, zoom to cluster and speed-ups

new version:
- speedups, especially when selecting/filtering clusters. I have tested it with
6000 images. Filtering is a little slow, but moving/zooming is okay.

- zoom into a cluster using ctrl+rmb on a cluster. This is done by finding the
bounding box of the cluster and zooming in on Marble until parts of the
bounding box leave the visible area, and then zooming out once. Patch is only
tested with Marble 0.8.1, I do not yet have a multiple-kde-versions compilation
setup (advice appreciated!)

- new e-mail address on b.k.o in anticipation of an svn-account

left to do:
- adjust indentation in markerclusterholder-files to digikam coding guidelines,
it was reset somehow
- find a better way to set a bounding box on Marble
- update the map search when images in the database are changed
- solve problem with previewed images in the main view when clusters are
changed

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37132|0                           |1
        is obsolete|                            |




--- Comment #30 from Michael G. Hansen <mike mghansen de>  2009-09-23 20:42:44 ---
Created an attachment (id=37136)
 --> (http://bugs.kde.org/attachment.cgi?id=37136)
New version, make the map resizable

- added a QSplitter to make the map and the map searches resizable.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=205001


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #37136|0                           |1
        is obsolete|                            |




--- Comment #31 from Michael G. Hansen <mike mghansen de>  2009-09-25 18:54:02 ---
Created an attachment (id=37174)
 --> (http://bugs.kde.org/attachment.cgi?id=37174)
New version, adapted to KDE 4.2.4

New version. Won the battle with the build-system and can now also test against
KDE 4.2.4.

- fixes for compiling with KDE 4.2.4. Still no mouse-interaction with the
clusters in 4.2.4

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #32 from Gilles Caulier <caulier gilles gmail com>  2009-09-30 17:34:12 ---
Michael,

I recommend you to commit your code in trunk for next beta5. Do not close yet
this file until all TODO points are not yet fixed...

Patrick,

Can you help Michael about Marble widget integration, especially how to set a
bounding box ? Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #33 from Michael G. Hansen <mike mghansen de>  2009-10-01 09:22:45 ---
Gilles,

I will commit it in the next few days.

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #34 from Michael G. Hansen <mike mghansen de>  2009-10-02 08:32:57 ---
SVN commit 1030300 by mghansen:

Initial commit for clustering of markers support in the GPSSearch and the
Geolocation tab.

Known issues:
- mouse interaction with clusters does not work with Marble<0.8 (KDE 4.2)
- when the icon view is in view mode, changing the filtering can lead to no
image being shown
- the selection on the map is not necessarily shown as a rectangle
- zooming into a cluster is a hack

CCBUG: 205001


 M  +12 -0     CMakeLists.txt  
 M  +14 -0     digikam/digikamview.cpp  
 M  +22 -0     digikam/imagecategorizedview.cpp  
 M  +2 -0      digikam/imagecategorizedview.h  
 M  +1 -1      libs/CMakeLists.txt  
 M  +5 -0      libs/imageproperties/imagepropertiesgpstab.cpp  
 A             libs/imageproperties/markerclusterholder.cpp   [License: GPL
(v2+)]
 A             libs/imageproperties/markerclusterholder.h   [License: GPL
(v2+)]
 A             libs/imageproperties/markerclusterholderplugin (directory)  
 A             libs/imageproperties/markerclusterholderplugin/CMakeLists.txt  
 A            
libs/imageproperties/markerclusterholderplugin/CheckPluginBuildable.cmake  
 A            
libs/imageproperties/markerclusterholderplugin/MarbleMacros.cmake  
 A             libs/imageproperties/markerclusterholderplugin/externaldraw.cpp
 [License: GPL (v2+)]
 A             libs/imageproperties/markerclusterholderplugin/externaldraw.h  
[License: GPL (v2+)]
 M  +601 -55   libs/imageproperties/worldmapwidget.cpp  
 M  +38 -6     libs/imageproperties/worldmapwidget.h  
 M  +7 -0      libs/models/imagefiltermodel.cpp  
 M  +1 -0      libs/models/imagefiltermodel.h  
 M  +25 -0     libs/models/imagefiltersettings.cpp  
 M  +9 -0      libs/models/imagefiltersettings.h  
 M  +143 -18   utilities/gpssearch/gpssearchview.cpp  
 M  +14 -0     utilities/gpssearch/gpssearchview.h  
 M  +64 -2     utilities/gpssearch/gpssearchwidget.cpp  
 M  +2 -1      utilities/gpssearch/gpssearchwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1030300

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001


Pieter Edelman <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #35 from Pieter Edelman <p edelman gmx net>  2009-10-02 08:58:57 ---
After this commit, digiKam fails to compile because of the conditional
inclusion of markerclusterholder.h and the subsequent unconditional declaration
of setCustomPaintFunction with  MarkerClusterHolder::CustomPaintFunction.

Error msg:
In file included from
/home/pieter/tmp/digikam-extrainfo/libs/imageproperties/imagepropertiesgpstab.h:40,
                 from
/home/pieter/tmp/digikam-extrainfo/libs/imageproperties/imagepropertiessidebar.cpp:58:
/home/pieter/tmp/digikam-extrainfo/libs/imageproperties/worldmapwidget.h:118:
error: expected ‘,’ or ‘...’ before ‘::’ token
/home/pieter/tmp/digikam-extrainfo/libs/imageproperties/worldmapwidget.h:118:
error: ISO C++ forbids declaration of ‘MarkerClusterHolder’ with no type

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #36 from Gilles Caulier <caulier gilles gmail com>  2009-10-02 09:25:31 ---
Pieter,

All compile fine there. Are you tried to clean up all before ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #37 from Michael G. Hansen <mike mghansen de>  2009-10-02 09:32:18 ---
SVN commit 1030310 by mghansen:

Fixes for compilation without Marble.

CCBUG: 205001



 M  +2 -0      libs/imageproperties/worldmapwidget.cpp  
 M  +2 -0      libs/imageproperties/worldmapwidget.h  
 M  +2 -0      utilities/gpssearch/gpssearchwidget.cpp  
 M  +3 -1      utilities/gpssearch/gpssearchwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1030310

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=205001





--- Comment #38 from Pieter Edelman <p edelman gmx net>  2009-10-02 10:05:39 ---
After commit 1030315 (sorry, forgot the CCBUGS line) digiKam compiles fine
without Marble.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel