[Bug 204466] New: local contrast plugin issues

classic Classic list List threaded Threaded
26 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] New: local contrast plugin issues

Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466

           Summary: local contrast plugin issues
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: wishlist
          Priority: NOR
         Component: Image Editor
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using Devel)
Compiler:          gcc4.3.2
OS:                Linux
Installed from:    Compiled sources

Sorry for delay but better late then never. Also I knew about answers for my
post on mail on list only through Gilles post. Below is fragment of discussion
from list with my additional comments.

---------------------------------------
>> MM
> Julien Narboux
 Julien Pontabry

> > But I have two problems with it:
> >
> > 1. Name: when you google for "local contrast" you will come with many
> > sites describing one of unsharp mask techniques while this tool is much
> > more similar in spirit to Highlighs/Shadows tools from other programs.
> > Even "Pseudo HDR" nick would be better description. From WhatsThis I
> > understand is sophisticated implementation of Contrast Mask technique
> > (BTW - I wonder if it would be possible to build smart sharpening based
> > on this plugin)
>
> It seems to me that this plugin does Highlights/Shadows recovery but
> taking into account the whole picture to preserve contrast.
> Maybe it could be called :
> "Local Highlights/Shadow recovery"
> "Local Tone Mapping"
> "Spatially Varying Tone Mapping"
>
> Look wikipedia for the definition of tone mapping :
>  http://en.wikipedia.org/wiki/Tone_mapping
>
> > 2. It is really hard to use. Only after I discovered connection with
> > Contrast Mask I was able to grok something but still struggle with
> > understanding what is what (eg. Stages?). Please, user documentation :)
>
> I guess stages are just several applications of the filter.
> You can find documentation on the web page of Nasca Octavian PAUL
> (http://zynaddsubfx.sourceforge.net/other/tonemapping/) upon which this
> plugin is based.
>
> I think before writing proper documentation, it would be nice to wonder
> if there is no better gui one can think of.
> I tested using only one stage and it was fine. Does anyone has examples
> which needs several "stages" to get a good result ?
>
> Julien Narboux
>
> ps: The plugin has still to be polished because 16bits and the progress
> bar do not work.
> Maybe preview could be faster using a downscaled image ? Julien, what do
> you think about that ?

I think we should first improve the plugin code to get it faster. I'm not sure
using downscale is a good idea. See the real effect on a little part of the
original image may be better, isn't it ?

Julien
---------------------------------

Ad. 1: "Local Tone Mapping" is the best. Why not even shorter - "Tone Mapping"?

Ad. 2: About GUI - I wonder if it would be technically possible to split
functionality in profiles: Highlights/Shadows - with resctricting (or
translating somehow) sliders to effects giving "recovering" effects
Pseudo HDR - for well liked and unrealistic HDR look.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=204466


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Image Editor                |Local Contrast
            Version|unspecified                 |0.10.0
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-09-09 15:50:31 ---
To Julien Pontabry,

Do you see this entry from Mik in Bugzilla ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Bugzilla from julien.pontabry@gmail.com
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #2 from Julien Pontabry <julien pontabry gmail com>  2009-09-10 08:56:20 ---
To Gilles,

Yes I do.
"Tone Mapping" is a good name (as "Pseudo-HDR" does) because it is exactly what
the algorithm does.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|0.10.0                      |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-10-07 13:41:15 ---
SVN commit 1032246 by cgilles:

rename plugin action from "Local Contrast" to "Tone Mapping"
CCBUGS: 204466


 M  +3 -3      imageplugin_localcontrast.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1032246

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-10-07 13:43:24 ---
SVN commit 1032249 by cgilles:

set internal tool name as "Tone Mapping"
CCBUGS: 204466


 M  +3 -3      localcontrasttool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1032249

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-10-07 13:49:27 ---
Julien,

Instead to use "Stage" 1/2/3/4, why not to use "Tone Map" 1/2/3/4 or something
like that ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Bugzilla from julien.pontabry@gmail.com
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #6 from Julien Pontabry <julien pontabry gmail com>  2009-10-07 17:37:33 ---
Gilles,

This are author's words. Sure it may be better. To me, using different stages
are not very usefull : I get best results with only one stage... This comes
maybe from my pictures ?

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Bugzilla from andi.clemens@gmx.net
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #7 from Andi Clemens <andi clemens gmx net>  2009-10-07 17:40:59 ---
I find this stages stuff very confusing, and I guess the average user might do
so, too.
What does it do? For me the results are all the same, so what is the
difference?
I have always turned on all 4 stages, since this was the default setting.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-10-07 20:05:48 ---
I'm agree. I cannot see a difference with more than one Stage to use

Look code, there is a loop to apply Stage on image :

http://lxr.kde.org/source/extragear/graphics/digikam/imageplugins/localcontrast/ToneMappingFloat.cpp#63

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Bugzilla from Julien@narboux.fr
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466


Julien Narboux <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #9 from Julien Narboux <Julien narboux fr>  2009-10-07 20:46:43 ---
I agree as well. I don't understand how the stages are supposed to be used. I
think this feature could be removed. Anyway an expert user could simulate the
stages by applying the filter several times.
I don't see why there is a "function" option either. The "power function"
option gives better results for me than linear. If everybody has the same
opinion maybe this option could be deleted as well.
The "low saturation" and "high saturation" could be renamed into
"shadow saturation" and "highlights saturation".

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Bugzilla from mikmach@wp.pl
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #10 from Mikolaj Machowski <mikmach wp pl>  2009-10-07 21:49:18 ---
Please, leave at least 2 stages. I was never able to get decent results from
this plugin with one stage. With two it is much easier.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Bugzilla from Julien@narboux.fr
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #11 from Julien Narboux <Julien narboux fr>  2009-10-07 21:53:39 ---
Mikolaj,

Interesting ! could you please provide an example picture and the settings you
are using for the two stages ?

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Johannes Wienke-3
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466


Johannes Wienke <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #12 from Johannes Wienke <languitar semipol de>  2009-10-07 21:57:21 ---
What about making the number of stages editable and defaulting to one stage?
This would be a reasonable default for beginners with a clean gui. Via a drop
down we could provide more stage bloating up the gui...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #13 from Gilles Caulier <caulier gilles gmail com>  2009-10-08 09:39:29 ---
After reflection, i think to change "Local Contrast" to "Tone Mapping" is a
wrong idea.

Look in internet, "Tone Mapping" is a method using more than one image to make
HDR. This is not the case here. This can confuse end user.

http://en.wikipedia.org/wiki/Tone_mapping

A lots of internet page are in French (if you enter Tone Mapping). All speak
about more than one image to use and to fuse.

I think that we cannot use Tone Mapping ask plugin name there.

Local Contrast is more adapted.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2009-10-08 09:44:45 ---
SVN commit 1032563 by cgilles:

fix High/Low Saturation to Highlight/Shadow Saturation
CCBUGS: 204466


 M  +4 -4      localcontrasttool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1032563

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Bugzilla from Julien@narboux.fr
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #15 from Julien Narboux <Julien narboux fr>  2009-10-08 10:07:57 ---
It difficult to find the best name for this plugin.

I think "ToneMapping" describe only the process to compress the dynamic range
of a picture.
It is usually applied to high dynamic range (HDR) pictures generated from
several low dynamic range pictures but it can be applied to a single picture as
well.
People often call this "single raw hdr", where is in fact it is more "Tone
mapping from a single raw" in my opinion.

It seems to me that this plugin implements some kind of ToneMapping applied to
a single picture (either a raw file with a moderate dynamic range or a 8bit
file with low dynamic range).

The "local constrast" name is short and quite intuitive and does not confuse
the user with multiple picture hdr tonemapping.
We could also use the following names :
"Dynamic range compression"
"LDR Tone Mapping"

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Johannes Wienke-3
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #16 from Johannes Wienke <languitar semipol de>  2009-10-08 10:24:24 ---
What about "contrast improvement"?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 204466] local contrast plugin issues

Gilles Caulier-4
In reply to this post by Bugzilla from mikmach@wp.pl
https://bugs.kde.org/show_bug.cgi?id=204466





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2009-10-08 13:05:02 ---
SVN commit 1032737 by cgilles:

revert Tone Mapping name to Local Contrast. Can be confuse for end user
CCBUGS: 204466


 M  +1 -1      imageplugin_localcontrast.cpp  
 M  +10 -10    localcontrasttool.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1032737

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12