[Bug 203594] New: Option to display a vertical thumb bar

https://bugs.kde.org/show_bug.cgi?id=203594

           Summary: Option to display a vertical thumb bar
           Product: digikam
           Version: 0.10.0
          Platform: Ubuntu Packages
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0 (using KDE 4.3.0)
Installed from:    Ubuntu Packages

If you click on a photo, it gets maximized. At the bottom there is a horizontal
thumb bar that shows the previous and next photos.

Due to the fact that widescreen monitors got common and the aspect ratio of
photos is 2:3 or 3:4, I find it useful to have options
- to disable the bar,
- to make it vertical,
- to make it vertical (the only current possibility)

TIA  Martin

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594


Pieter Edelman <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Pieter Edelman <p edelman gmx net>  2009-08-14 10:15:21 ---
I also think this is a very useful option, and I think there's a quite elegant
solution to this: making the thumb bar detachable like the toolbars, so that
the user can place it either on top, bottom, left, right or make it float.

This can be quite easily accomplished by wrapping the thumb bar in a
QDockWidget. I just tried to do this with the thumb bar in the Light Table and
it is all quite straightforward. The only change to the ThumbBar class is that
a method is added to change the orientation on the fly.

By the way, it is already possible to hide the thumb bar. Just click on the
"Show Thumbnails" option in the view menu.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Preview




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #2 from Pieter Edelman <p edelman gmx net>  2009-08-17 23:14:17 ---
Created an attachment (id=36238)
 --> (http://bugs.kde.org/attachment.cgi?id=36238)
Make thumbbars dockable

The attached patch implement this idea for the image preview, the image editor,
the lighttable and showFoto. The thumbnail bars here can be dragged to any side
of the relevant window or floated above it. These states are saved between
digiKam sessions.

There turned out to be a few benefits using this approach, apart from the extra
freedom it grants the user. It is no longer required to change the orientation
in the settings menu, and a restart is no longer required after changing the
setting. Also, I think it puts bug 173746 to rest (no more splitters are used
and I can't reproduce the problem described there with this patch applied).

This method does however raise the question of where the thumbnail bars should
be placed in regard to the other widgets. I implemented the following behavior,
which seemed the most logical to me:
- The image and its "metadata siderbar" are considered to be a single entity. A
vertical thumbbar is not placed in between these two. A horizontal thumbbar
pushes up/down both the image and its sidebar.
- The left sidebar in the main preview window is regarded separate from the
image. A vertical thumbbar is placed between the it and the image. A horizontal
thumbbar will not push up/down the sidebar.

This patch adds a small support widget for the thumbnail bars, ThumbBarDock
which inherits from QDockWidget, which has a similar drag handle as a toolbar.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-08-18 14:53:48 ---
Pieter,

First, Thanks you very much for your patch. It's very appreciate.

Note : use svn diff > foo.patch to generate patch file, else it will include
diff with temp files generated by Qt, as digikamconfig.cpp

You patch do not includes changes for showfoto. It's not very complicated to
change. There is also an option in showfoto setup to change thumbbbar
orientation, which will become obsolete.

All the rest must be fine. I will test it now...

Thanks in advance for the help

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-08-18 14:56:42 ---
Showfoto do not compile with your patch :

Scanning dependencies of target showfoto
[ 75%] Building CXX object digikam/showfoto/CMakeFiles/showfoto.dir/main.o
In file included from
/home/gilles/Documents/data/devel/SVN/trunk/graphics/digikam/showfoto/main.cpp:45:
/home/gilles/Documents/data/devel/SVN/trunk/graphics/digikam/showfoto/showfoto.h:93:
error: invalid covariant return type for‘virtual Digikam::ThumbBarView*
ShowFoto::ShowFoto::thumbBar() const’
/home/gilles/Documents/data/devel/SVN/trunk/graphics/digikam/showfoto/../utilities/imageeditor/editor/editorwindow.h:171:
error:   overriding ‘virtual Digikam::ThumbBarDock*
Digikam::EditorWindow::thumbBar() const’
make[2]: *** [digikam/showfoto/CMakeFiles/showfoto.dir/main.o] Error 1
make[1]: *** [digikam/showfoto/CMakeFiles/showfoto.dir/all] Error 2
make: *** [all] Error 2

Do you use code from svn trunk ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-08-18 15:21:24 ---
Pieter,

Tested with Album View, Editor and Light Table. Few problem appear :

1/ On LT, thumbbar disappear. No way to restore it.
2/ Editor vertical thumbbar is fine, but horizontal cannot be placed under
canvas without to break right sidebbar (as the previous behavior)
3/ With Album view, It's the same than editor : horizontal thumbbar cannot be
placed under preview as well.
4/ Default thumbbar place is as toolbar. At least it must follow old setting
from rc file and set dockable thumbbar at the right place in layout.
5/ At the first time, after top apply patch, if thumbbar is not displayed from
settings file, layout is broken : typically sidebar take whole size.

Best

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-08-18 15:31:06 ---
Screenshots :

http://farm3.static.flickr.com/2468/3832946575_9b21eb58ce_o.png
http://farm3.static.flickr.com/2468/3832945947_98694b529c_o.png
http://farm3.static.flickr.com/2456/3832945803_cc9ac89bc7_o.png
http://farm4.static.flickr.com/3531/3832945655_cb00f7ff4c_o.png

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #7 from Pieter Edelman <p edelman gmx net>  2009-08-18 18:20:44 ---
Gilles, for some reason the changes I made in showfoto weren't included in the
patch, and that causes the compilation error. I'll look into the other issues
and post a new patch soon.

(In reply to comment #4)

> Showfoto do not compile with your patch :
>
> Scanning dependencies of target showfoto
> [ 75%] Building CXX object digikam/showfoto/CMakeFiles/showfoto.dir/main.o
> In file included from
> /home/gilles/Documents/data/devel/SVN/trunk/graphics/digikam/showfoto/main.cpp:45:
> /home/gilles/Documents/data/devel/SVN/trunk/graphics/digikam/showfoto/showfoto.h:93:
> error: invalid covariant return type for‘virtual Digikam::ThumbBarView*
> ShowFoto::ShowFoto::thumbBar() const’
> /home/gilles/Documents/data/devel/SVN/trunk/graphics/digikam/showfoto/../utilities/imageeditor/editor/editorwindow.h:171:
> error:   overriding ‘virtual Digikam::ThumbBarDock*
> Digikam::EditorWindow::thumbBar() const’
> make[2]: *** [digikam/showfoto/CMakeFiles/showfoto.dir/main.o] Error 1
> make[1]: *** [digikam/showfoto/CMakeFiles/showfoto.dir/all] Error 2
> make: *** [all] Error 2
>
> Do you use code from svn trunk ?
>
> Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #8 from Pieter Edelman <p edelman gmx net>  2009-08-18 19:09:57 ---
(In reply to comment #5)
> Pieter,
>
> Tested with Album View, Editor and Light Table. Few problem appear :
>
> 1/ On LT, thumbbar disappear. No way to restore it.
Gilles, I can't reproduce this no matter what I try. Does restarting digiKam
fix this issue? If not, can you send me your digikamrc?

> 2/ Editor vertical thumbbar is fine, but horizontal cannot be placed under
> canvas without to break right sidebbar (as the previous behavior)
> 3/ With Album view, It's the same than editor : horizontal thumbbar cannot be
> placed under preview as well.
If I understand your remarks correctly, this was my question: I think it makes
more sense to tie the metadata bar to the image, and so make it scale in the
same way as with the image view. Apparently, you think it shouldn't :) I will
change that.

> 4/ Default thumbbar place is as toolbar. At least it must follow old setting
> from rc file and set dockable thumbbar at the right place in layout.
The new location is not stored as a neat string, but a base64 encoded string
from QMainWindows's saveState(). I can add some code to apply the old state and
after that delete it from the config file, but this introduced extra 'cruft' in
the code. Please let me know if this is what you want.

> 5/ At the first time, after top apply patch, if thumbbar is not displayed from
> settings file, layout is broken : typically sidebar take whole size.
I don't understand. Can you post a screenshot?

>
> Best
>
> Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #9 from Martin Bretschneider <bugs bretschneidernet de>  2009-08-18 20:49:55 ---
Thanks Pieter,

if your patch it included in the next release, I would be happy. The
screenshots from Gilles look nice:)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2009-08-19 11:21:23 ---
Created an attachment (id=36274)
 --> (http://bugs.kde.org/attachment.cgi?id=36274)
Where is LT thumbbar ?

To pieter, #8, point 1/

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #11 from Gilles Caulier <caulier gilles gmail com>  2009-08-19 11:23:19 ---
Created an attachment (id=36275)
 --> (http://bugs.kde.org/attachment.cgi?id=36275)
digiKam rc file with dockable thumbbar bar applied

To pieter, #8, point 1/

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2009-08-19 11:41:39 ---
To pieter, #8,

1/ : Note : restarting digiKam do not fix the problem...

2/

>If I understand your remarks correctly, this was my question: I think it makes
>more sense to tie the metadata bar to the image, and so make it scale in the
>same way as with the image view. Apparently, you think it shouldn't :) I will
>change that.

I think no, because this will break compatibility with small screen (eepc for
example. At least your patch must follow old behavior to not lost users. Please
just set dockable place around preview view (album gui) and canvas (editor) :
on top, left, right and bottom. We will see later with users feedback if this
can be improved...

4/

>The new location is not stored as a neat string, but a base64 encoded string
>from QMainWindows's saveState(). I can add some code to apply the old state and
>after that delete it from the config file, but this introduced extra 'cruft' in
>the code. Please let me know if this is what you want.

Yes, something like that. We remember a lots of problem with splitter size
settings to save/restore from rc file, which break layut everywhere. I hope to
not see back these problem with your patch. Marcel has working hard to hack
these dysfunction. I would to see Marcel's viewpoint here...

5/ I cannot reproduce now. nevermind...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594


Pieter Edelman <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36238|0                           |1
        is obsolete|                            |




--- Comment #13 from Pieter Edelman <p edelman gmx net>  2009-08-20 18:47:57 ---
Created an attachment (id=36306)
 --> (http://bugs.kde.org/attachment.cgi?id=36306)
Make thumbbars dockable

Ok, here's an improved patch (I still didn't use the svn diff trick, will
figure that out later. But it should be clean).

Changes:
- The changes to showFoto are included.
- Dock areas are now placed directly around the image views, so the sidebars
get full height.
- Old settings for image editor and showFoto regarding thumbnail bar
orientation are followed and then removed from config file.

I can't reproduce the error where the thumbnail bar stays hidden in the
lighttable window. If I set the "Show Thumbnails" setting in the config file to
false, it is hidden (as it should be), but I can get it back by selecting "Show
Thumbnails" from the menu. Gilles, can you tell me how you lost it?

Pieter

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2009-08-20 18:51:26 ---
Pieter,

I just started LT as well. nothing more, LT appears with thumbbar

I will test your new patch soon...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2009-08-21 10:34:16 ---
Pieter,

I just started LT as well. nothing more, LT appears with NO thumbbar... I want
mean...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #16 from Gilles Caulier <caulier gilles gmail com>  2009-08-21 14:31:55 ---
Pieter,

This new patch is really better. all work fine now excepted 2 point :

In editor, when you resize right side bar, splitter do not work very well, and
canvas + horizontal thumbbbar is not resized.

In LT, thumbbar do not exist because option to show it is not enabled by
default.

That all.

I would to include your patch in 1.0.0-beta4.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36274|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #36275|0                           |1
        is obsolete|                            |




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel