[Bug 203594] New: Option to display a vertical thumb bar

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2009-08-21 14:47:36 ---
Created an attachment (id=36328)
 --> (http://bugs.kde.org/attachment.cgi?id=36328)
broken layout in editor with horizontal thumbbar

Look empty space between right side bar and canvas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #18 from Gilles Caulier <caulier gilles gmail com>  2009-08-23 19:20:06 ---
SVN commit 1014730 by cgilles:

apply patch from Pieter Edelman to make thumbbar dockable everywhere.
BUG: 203594


 M  +1 -0      CMakeLists.txt  
 M  +37 -65    digikam/albumwidgetstack.cpp  
 M  +7 -4      digikam/albumwidgetstack.h  
 M  +38 -11    digikam/digikamview.cpp  
 M  +1 -0      digikam/digikamview.h  
 M  +29 -14    libs/widgets/common/thumbbar.cpp  
 M  +2 -1      libs/widgets/common/thumbbar.h  
 M  +0 -9      showfoto/setup/setupeditor.cpp  
 M  +50 -51    showfoto/showfoto.cpp  
 M  +1 -1      showfoto/showfoto.h  
 M  +6 -19     utilities/imageeditor/editor/editorwindow.cpp  
 M  +2 -2      utilities/imageeditor/editor/editorwindow.h  
 M  +68 -51    utilities/imageeditor/editor/imagewindow.cpp  
 M  +2 -1      utilities/imageeditor/editor/imagewindow.h  
 M  +48 -25    utilities/lighttable/lighttablewindow.cpp  
 M  +1 -0      utilities/lighttable/lighttablewindow.h  
 M  +5 -2      utilities/lighttable/lighttablewindow_p.h  
 M  +2 -0      utilities/lighttable/lighttablewindowui.rc  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1014730

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #19 from Andi Clemens <andi clemens gmx net>  2009-08-24 12:49:37 ---
Another issue with the dockable thumbbar:
If you cycle through the images (by pressing the keyboard shortcuts or clicking
on the thumbnails in the thumbbar), the thumbbar gets randomly closed. This
happens at least in the iconview (where the thumbbar can be hidden).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #20 from Pieter Edelman <p edelman gmx net>  2009-08-24 17:54:49 ---
Gilles, I noticed that you changed the default behavior for the thumbbar in the
Lighttable to on, so I regard this issue as fixed now.

I'll look into the empty space problem. I have a hard time reproducing it, but
the one time I noticed it, it was gone when I resized the sidebar. I believe it
has something to do with restoring the splitter state while from a previous
session, so maybe it's not directly fixable. In that case, I think it's best to
write some code to detect if this is a transition and if it is, fall back to a
sensible default regarding the sidebars.

Andi, I'll notice the same behavior, but I'm certain it worked before. I'll see
if I can figure out the cause.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #21 from Pieter Edelman <p edelman gmx net>  2009-08-25 00:21:24 ---
Created an attachment (id=36421)
 --> (http://bugs.kde.org/attachment.cgi?id=36421)
Keep thumbbar visible/hidden when cycling through photos

This patch should fix the issue that Andi describes, that the thumbbar is
hidden (or shown) when cycling through images in the preview view.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #22 from Gilles Caulier <caulier gilles gmail com>  2009-08-25 08:51:58 ---
SVN commit 1015287 by cgilles:

apply patch to fix thumbbar visibility when cycling through photos.
CCBUGS: 203594



 M  +1 -2      digikam/digikamview.cpp  
 M  +2 -2      libs/widgets/common/thumbbardock.cpp  
 M  +10 -6     libs/widgets/common/thumbbardock.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1015287

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #23 from Pieter Edelman <p edelman gmx net>  2009-08-28 09:07:38 ---
Gilles,
I see some layout issues when using the config file from a splitter based
digiKam in the dock-based version (which should be fixed), but I can only
reproduce the issue with the gap when going the other way around: using the
config file from a dock based digiKam in an older, splitter based version.

Do you still remember the version you made the screenshot of?

(In reply to comment #17)
> Created an attachment (id=36328)
 --> (http://bugs.kde.org/attachment.cgi?id=36328) [details]
> broken layout in editor with horizontal thumbbar
>
> Look empty space between right side bar and canvas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #24 from Gilles Caulier <caulier gilles gmail com>  2009-08-28 11:03:58 ---
The rc file have generated with current code from svn, but have an history
based on old releases. I don't have cleaned this file for a while. So, it's a
typical case which can be found in users area...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #25 from Andi Clemens <andi clemens gmx net>  2009-09-02 19:50:56 ---
Pieter,
there is still an issue with the thumbbar: It doesn't seem to load its state
correctly. See the following screenshot:
http://farm3.static.flickr.com/2482/3881294309_055d67424e_o.jpg

I had the thumbbar turned on, restarted digiKam and now it is gone, although
the checkbox is set in the menu.

Gilles, Marcel,

somehow I think the action has a bad name, "Show Thumbnails" sounds confusing,
some users might think the thumbnails are the items in the iconview. Maybe
"Show Filmstrip" or something like that would be more clear?

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #26 from Gilles Caulier <caulier gilles gmail com>  2009-09-02 19:58:34 ---
>"Show Filmstrip" or something like that would be more clear?

Agree. This must be done in Preview, LT, and Editor. "Show Thumbbar" ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #27 from Pieter Edelman <p edelman gmx net>  2009-09-08 20:08:23 ---
Created an attachment (id=36798)
 --> (http://bugs.kde.org/attachment.cgi?id=36798)
Convert splitter based thumbbars to dockwidgets

I can only reproduce the reported problems if I alternately use the production
version of digiKam with the SVN version. This makes sense: the production
version writes a splitter state with three widgets next to each other
(thumbbar, main window, and right sidebar), the SVN version then loads this
state and applies it to the two widgets and consequently sets the size of the
thumbbar to the main widget and such (incidentally, this bug was also present
when switching from vertical to horizontal thumbbar, but is solved by using a
floatable widget).

This patch detects (in the editor window and showFoto) whether the saved
splitter state has three windows, and if so, removes the first size from the
list (the thumbbar). This means that the SVN version loads a config file from
an older version correctly, but not the other way around. So migrating from an
older version to the SVN version shouldn't be a problem, but using an older
version after having used the SNV version might screw up the layout.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #28 from Pieter Edelman <p edelman gmx net>  2009-09-08 20:11:33 ---
(In reply to comment #25)
> Pieter,
> there is still an issue with the thumbbar: It doesn't seem to load its state
> correctly. See the following screenshot:
> http://farm3.static.flickr.com/2482/3881294309_055d67424e_o.jpg
>
> I had the thumbbar turned on, restarted digiKam and now it is gone, although
> the checkbox is set in the menu.
>

Hi Andi,

I can't reproduce this, so I have two questions:
- Did you use the SVN version both of the times?
- What happens if you click the "Show Thumbnails" button again two times (to
hide and then show)?

Pieter

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #29 from Andi Clemens <andi clemens gmx net>  2009-09-08 20:17:54 ---
Well since I'm a developer, I always use the SVN version ;-)
I can reproduce this all the time, especially when displaying an image, showing
the thumbbar and then switching to another album.
Most of the time the thumbbar then is not visible anymore, although the
checkbox is set.

> - What happens if you click the "Show Thumbnails" button again two times (to
> hide and then show)?

It is shown again...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #30 from Pieter Edelman <p edelman gmx net>  2009-09-08 20:23:34 ---
You're right, with these steps I can reproduce it too. I will look into it.

(In reply to comment #29)

> Well since I'm a developer, I always use the SVN version ;-)
> I can reproduce this all the time, especially when displaying an image, showing
> the thumbbar and then switching to another album.
> Most of the time the thumbbar then is not visible anymore, although the
> checkbox is set.
>
> > - What happens if you click the "Show Thumbnails" button again two times (to
> > hide and then show)?
>
> It is shown again...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #31 from Andi Clemens <andi clemens gmx net>  2009-09-08 20:27:19 ---
There might be a chance that this bug even existed before your patch. Although
I have not recognized it before.
I will checkout some earlier version and use "git bisect" to check for the
faulty commit (if there is anyone in a time range of 5 months).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #32 from Andi Clemens <andi clemens gmx net>  2009-09-08 20:55:40 ---
After doing some checks, it is clear that the problem occurred with applying
the patch:
http://websvn.kde.org/?view=rev&revision=1014730

Before this commit it is working as expected.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #33 from Andi Clemens <andi clemens gmx net>  2009-09-08 21:24:33 ---
(In reply to comment #26)
> >"Show Filmstrip" or something like that would be more clear?
>
> Agree. This must be done in Preview, LT, and Editor. "Show Thumbbar" ?
>
> Gilles

I'll go with "Show Thumbbar" now, it should be clear enough.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #34 from Pieter Edelman <p edelman gmx net>  2009-09-09 23:56:19 ---
Created an attachment (id=36829)
 --> (http://bugs.kde.org/attachment.cgi?id=36829)
Fix random hides of thumbbar

This patch should fix the problem described by Andi.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #35 from Andi Clemens <andi clemens gmx net>  2009-09-10 00:49:12 ---
SVN commit 1021750 by aclemens:

Apply patch by Pieter Edelman: Fix random hides of thumbbar

CCBUG:203594

 M  +1 -1      digikam/albumwidgetstack.cpp  
 M  +0 -12     libs/widgets/common/thumbbardock.cpp  
 M  +9 -12     libs/widgets/common/thumbbardock.h  
 M  +1 -1      utilities/imageeditor/editor/editorwindow.cpp  
 M  +1 -1      utilities/imageeditor/editor/imagewindow.cpp  
 M  +1 -1      utilities/lighttable/lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1021750

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=203594





--- Comment #36 from Andi Clemens <andi clemens gmx net>  2009-09-10 00:51:03 ---
The patch seems to work fine, thanks.
I hope we can finally "close" this report now :D

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel