[Bug 202278] New: BQM: sharpen tool resets EXIF orientation

https://bugs.kde.org/show_bug.cgi?id=202278

           Summary: BQM: sharpen tool resets EXIF orientation
           Product: digikam
           Version: 1.0.0-beta3
          Platform: Debian testing
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta3 (using KDE 4.2.4)
OS:                Linux
Installed from:    Debian testing/unstable Packages

 Hi,

When using the sharpen tool (alone or as first) in batch queue manager the
resulting images have wrong orientation in EXIF.
steps to reproduce:
+ mark some images within album view
+ right click: Batch Queue Manager -> Add to existing queue -> #1
+ open BQM
+ set Target Album, File Renaming (customize filename: foobar_$)
+ go to Base Tools, double click 'Sharpen Image'
+ click 'Run'
-> check resulting images: pictures taken in portrait mode (EXIF orientation
field says: left, bottom) were not rotated, but have a different orientation
now (top, left).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=202278


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Batch Queue Manager




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=202278





--- Comment #1 from Andi Clemens <andi clemens gmx net>  2009-09-02 19:00:25 ---
The same seems to be true for the resize tool

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=202278


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #2 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-11-29 16:21:34 ---
Looking at the source of BatchTool and ActionThread, d->exifSetOrientation is
always true, and not changed by any tool, so for all tools, the orientation tag
will be reset to NORMAL.
I would suggest to be more precise with the wording ("resetExifOrientation")
and default to false - which tools need to reset the orientation tag?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=202278





--- Comment #3 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-17 22:22:40 ---
Gilles, this bug should be fixed as well.
As I see it, only Flip and Rotate need to reset the rotation flag, all other
tools should not touch this flag. Ok?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=202278





--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-12-17 22:43:02 ---
Yes Marcel, only these both tools must do that...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=202278


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-19 16:04:06 ---
SVN commit 1063913 by mwiesweg:

There were two different settings merged in one:
- the user allows to edit the exif orientation - from digikam settings
- the tool needs to reset the flag - only flip and rotate need that.
Treat this distinctly, so that not all images processed by BQM have their
orientation reset.

BUG: 202278

 M  +2 -1      NEWS  
 M  +2 -2      utilities/queuemanager/actionthread.cpp  
 M  +1 -1      utilities/queuemanager/actionthread.h  
 M  +2 -0      utilities/queuemanager/basetools/transform/flip.cpp  
 M  +2 -0      utilities/queuemanager/basetools/transform/rotate.cpp  
 M  +25 -12    utilities/queuemanager/batchtool.cpp  
 M  +12 -4     utilities/queuemanager/batchtool.h  
 M  +1 -1      utilities/queuemanager/queuemgrwindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1063913

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=202278


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta3                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=202278


Jens Mueller <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #6 from Jens Mueller <tschenser gmx de>  2010-01-07 21:59:21 ---
(In reply to comment #5)
> - the tool needs to reset the flag - only flip and rotate need that.

Marcel, what about converter tools (png, tiff, jpeg, ...)? Please have look on
https://bugs.kde.org/show_bug.cgi?id=221113#c4

Jens

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=202278

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=202278

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|BatchQueueManager           |BatchQueueManager-Tool-Shar
                   |                            |p

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel