[Bug 199975] New: Issues in Album view on Windows

https://bugs.kde.org/show_bug.cgi?id=199975

           Summary: Issues in Album view on Windows
           Product: digikam
           Version: 1.0.0-beta3
          Platform: unspecified
        OS/Version: MS Windows
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           1.0.0-beta3 (using 4.2.3 (KDE 4.2.3), MinGW 3.4.5)
Compiler:          gcc.exe
OS:                Microsoft Windows (i686) release 5.1 (XP Professional)

When hovering the mouse over a picture a blue border appears around the
picture, I guess to indicate that this is the picture under the mouse. This
blue border does however not disappear when the mouse is moved to another
picture so after moving the mouse around all images have this border. All
border disappear when I do something else like select one image or scroll up or
down until all blue borders are of screen.
Single click on an image does not trigger the view/edit action as before.
Instead I have to double click to trigger the action.
Non of this issues are there when I run the same version under Ubuntu.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=199975


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Albums GUI




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #1 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-11-29 16:06:58 ---
Someone showed me this staying-border problem during the coding sprint, so I
guess it's still around. But I cannot reproduce this. So is anyone present who
can reproduce this problem and is willing to compile with a few debug patches
added?

The single vs. double click behavior is controlled by Qt and determined by
system settings.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2009-11-29 16:12:47 ---
I can confirm this for WindowsXP: Borders stay "open", click behavior is
broken, but this is a more general problem, because in Linux it is the same.
If you set Linux / KDE to have double-click behavior, the image can still be
closed with a single click, but it will only show with a double click (very
inconsistent).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=199975


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=199975


Michael G. Hansen <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Michael G. Hansen <mike mghansen de>  2009-11-29 16:19:25 ---
I have two user accounts on my system, a regular one and a testuser. The
testuser does not have the staying-border-problem, but the regular one does. I
do not know exactly where their system settings are different, though...

Qt 4.5.3, KDE 4.3.2

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #4 from Michael G. Hansen <mike mghansen de>  2009-11-29 16:20:22 ---
Forgot to mention that this is on linux...

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #5 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-11-30 20:04:21 ---
The code drawing this border is located in imagedelegate.cpp, line 378:
if (option.state & QStyle::State_MouseOver) { ...

There is also a similar code block above (371) which is probably never used.
I see these possibilities: Either the item is not redrawn when the mouse
leaves, or the 371-code block is used, why ever. Or the MouseOver flag is
erroneously set.
It's a bit difficult to debug because the method is called for every
QModelIndex and for each redraw, so quite often. You could use debug messages
restricted to when a certain model index (e.g. row=0) is painted.
There is ImageDelegate::mouseMoved to get info about where the mouse is.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #6 from Michael G. Hansen <mike mghansen de>  2009-11-30 23:15:25 ---
Created an attachment (id=38728)
 --> (http://bugs.kde.org/attachment.cgi?id=38728)
Screenshot of border debugging

Ok, this is how far I got:

if (option.state & QStyle::State_MouseOver)
{
    kDebug()<<"mouseover!!!";
    r = d->rect;
    p->setPen(QPen(option.palette.color(QPalette::Highlight), 3,
Qt::SolidLine));
    p->drawRect(1, 1, r.width()-3, r.height()-3);
} else
{
    kDebug()<<"NOT mouseover!!!";
    r = d->rect;
    p->setBrush(QBrush(Qt::black));
    p->setPen(QPen(Qt::green, 3, Qt::SolidLine));
    p->drawRect(1, 1, r.width()-3, r.height()-3);
}

With this code, all items are black with a green border by default (middle
icon). Mouse over the icon on the left and over the one on the right in the
screenshot -> it gets a blue border, debug output "mouseover". Move mouse away
-> debug output "NOT mouseover", but the blue border stays, and you can see
that the black brush is clipped to where the overlays are located, therefore
the border was not erased...

The black artefacts around the green border are drawn at the beginning of the
function with a width of 5, and also don't erase the background of the blue
border...

Now execute the same code under a user account where the staying-border-problem
does not occur, and there is no clipping, the black brush covers the entire
inside of the green border when the mouse is moved away.

So, how do we proceed?

Marcel: The State_HasFocus branch is executed when an item has been selected
with the mouse.

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-01 21:02:51 ---
Is the differing behavior dependent of digikam config (copying over the
digikamrc, with backup ;-) ?)

Can you check the painter's clipRegion(), maybe the current painting is not
executed because it's clipped?
The area to be painted is given by option.rect, is this one correct?

The overlays are little widgets themselves, repositioned each time a new item
is entered. That will explain why their region stays black, though I'm unsure
about the exact mechanism.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #8 from Michael G. Hansen <mike mghansen de>  2009-12-03 21:47:03 ---
Marcel,

copying the digikamrc does not work for me, I always get the Configuration
Wizard of Digikam when I try it.

Clipping: QRegion(size=0), bounds = QRect(0,0 0x0)
The options.rect is okay.

Another oddity: If I block the installation of overlays in
ImageDelegate::installOverlay, the testuser (without the staying borders
problem) still works okay (without overlays), but for the regular user the
mouseMove events do not lead to a repainting of the delegate (no debug messages
from the ImageDelegate::paint function). Therefore I guess that whatever should
trigger a repaint of the ImageDelegate on mouse moves is somehow broken there,
but I could not figure it out.

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=199975


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #9 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-04 12:37:07 ---
When copying the digikamrc you need to adjust the "Database File Path" setting.
All other settings should not make the first-run wizard appear.
(That's my first approach: If this is settings dependent, we can isolate which
setting is the problem)

The second question: When the mouse is moved away, is ImageDelegate::paint()
called but with no effect, or is it not called at all?
Make sure, when testing with more than one item in the view, to include the
index's row() in the debug output to identify.
If it's not called at all, the next level to check will be
KCategorizedView::paintEvent().

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Michael G. Hansen]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #10 from Michael G. Hansen <mike mghansen de>  2009-12-05 15:21:33 ---
The staying-borders problem appears to be caused by the 'Plastique' style. If I
start KDE for a fresh user, the staying-borders problem is not there. Then I
change the widget style from Oxygen to 'Plastique' in the System Settings and
the staying-borders problem is there.

Marcel, can you reproduce this?

Michael

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-05 16:05:53 ---
Yes that's it! Absolutely reproducable.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #12 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-05 16:36:31 ---
So to me it appears that when digikam is started with Plastique as style
(changing while running may not show the effect), any paint operation on the
view's viewport, done on an item after the mouse moved away from this item, is
reverted (*).

(*) I say reverted because on areas covered by transparent widgets, the effect
of the paint operation is visible.

Is Plastique coming from KDE or Qt? Should we change the component of this bug?
If painting works with default styles but reproducibly not with a certain one,
I would assume a problem with this style.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #13 from Andi Clemens <andi clemens gmx net>  2009-12-05 16:42:53 ---
I can see painting issues in IconView for every style and theme in Linux, too.
Just change the theme (from Default to Dark for example) and watch the
iconview. It is not updated correctly, only when hovering over the items in the
iconview.
I need to close the current album and switch to another to make the iconview
refresh its style.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #14 from Andi Clemens <andi clemens gmx net>  2009-12-05 16:43:17 ---
So I guess it is more of a general problem in the iconview?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=199975





--- Comment #15 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-06 16:33:51 ---
I just see a missing redraw. All newly painted items will be drawn with the new
theme. Probably easy to fix.
Out themes are not the problem here - it's an issue with a specific QStyle.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=199975


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #16 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-12-19 16:31:25 ---
*** Bug 212108 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=199975


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.0.0-beta3                 |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel