[Bug 195561] New: Implement a selective saturation filter

https://bugs.kde.org/show_bug.cgi?id=195561

           Summary: Implement a selective saturation filter
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using KDE 4.1.4)

It would be nice to have a filter which apply saturation mostly on pixels which
are less saturated.
It would be nice also to have this filter preserve skin tones.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195561


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Wish for new plugin
            Version|unspecified                 |0.10.0
            Product|digikam                     |digikamimageplugins




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195561





--- Comment #1 from Julien Narboux <Julien narboux fr>  2009-06-07 14:58:58 ---
Created an attachment (id=34345)
 --> (http://bugs.kde.org/attachment.cgi?id=34345)
A patch to add a slider called "selective saturation" in hsl plugin

This patch adds a slider in hsl tool. The new slider is supposed to add
saturation mostly to pixels whose saturation is low.
This intent is to have something similar to the so called "vibrance" setting in
some other software.

Preserving skin tones can not be done easily without changing deeply the
current implementation of hsl, because the implementation is such that when
changing saturation we do not have access to hue directly.

I did not commit this patch because I am not satisfied with the results. The
algorithm needs a deeper study.


Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195561





--- Comment #2 from Julien Narboux <Julien narboux fr>  2009-06-07 15:01:06 ---
Some screenshots:

http://www.flickr.com/photos/julien_narboux/sets/72157619379393970/

Comments welcome.

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195561





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-10-13 22:22:11 ---
Julien,

I have completely forget this patch.

Somebody can review it, and give us viewpoint, as photograph...

Thanks in advance

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195561


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
            Version|0.10.0                      |1.0.0
            Summary|Implement a selective       |Implement a selective
                   |saturation filter           |saturation filter [patch]




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195561





--- Comment #4 from Julien Narboux <Julien narboux fr>  2009-10-13 22:46:36 ---
Gilles,

I have to work on this. This patch only saturate more low saturated pixel. We
need, in addition to saturate less colors whose hue component are similar to
skin tone....

Julien

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195561


Julien Narboux <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #34345|0                           |1
        is obsolete|                            |




--- Comment #5 from Julien Narboux <Julien narboux fr>  2010-03-27 10:59:25 ---
Created an attachment (id=42288)
 --> (http://bugs.kde.org/attachment.cgi?id=42288)
First version of a patch to add a vibrance slider to HSL tool.

This patch creates a new slider called vibrance in the HSL tool. This slider is
the same as saturation except that it adds saturation only to a special range
of colors whose hue is in a given range. The range is set to try to avoid
saturating skin tones.

TODO: add interpolation: for the time begin saturation is added to a given
range of hue, in the future saturation should be added more to some hue rand
and less to some others but with smooth transition.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195561





--- Comment #6 from Julien Narboux <Julien narboux fr>  2010-03-29 08:05:53 ---
SVN commit 1108522 by jnarboux:

First version of the vibrance slider in the HSL tool.

CCBUGS: 195561




 M  +31 -5     hslfilter.cpp  
 M  +5 -1      hslfilter.h  
 M  +28 -8     hslsettings.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1108522

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195561





--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2010-03-29 08:37:11 ---
SVN commit 1108530 by cgilles:

HSL correction tool is also available in Batch Queue Manager. Don't forget to
patch Vibrance management settings here, else, settings widget
adjustment done by user will be ignored, and default value will be used
instead.
CCBUGS: 195561


 M  +4 -0      hslcorrection.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1108530

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195561





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2010-12-04 12:23:45 ---
What's the status of this report? Has it been fixed?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195561





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2010-12-04 17:38:44 ---
Well, if BQM HSL tool has the same settings than IE HSL tool, so yes, this file
can be closed.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195561


Julien Narboux <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #10 from Julien Narboux <Julien narboux fr>  2010-12-05 18:53:21 ---
The settings are the same in BQM. I mark the bug as fixed.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195561

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.7.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=195561

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Product|digikamimageplugins         |digikam
          Component|Wish for new plugin         |Tool-General

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel