[Bug 195494] New: Deleting and cancelling a picture with the keyboard still delete the picture

https://bugs.kde.org/show_bug.cgi?id=195494

           Summary: Deleting and cancelling a picture with the keyboard
                    still delete the picture
           Product: digikam
           Version: 0.10.0
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0 (using 4.2.2 (KDE 4.2.2), Kubuntu packages)
Compiler:          cc
OS:                Linux (x86_64) release 2.6.28-12-generic

That's a weird one.

See screenshots for the visual result.

1-Go in an album with multiples pictures.
2-Delete a picture
3-With the keyboard, hit the right arrow to move the selection to "cancel"
4-Hit enter and your picture will still be deleted!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195494





--- Comment #1 from Alexandre Racine <alexandreracine gmail com>  2009-06-06 20:16:07 ---
Created an attachment (id=34330)
 --> (http://bugs.kde.org/attachment.cgi?id=34330)
1delete

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195494





--- Comment #2 from Alexandre Racine <alexandreracine gmail com>  2009-06-06 20:16:22 ---
Created an attachment (id=34331)
 --> (http://bugs.kde.org/attachment.cgi?id=34331)
2cancel

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195494





--- Comment #3 from Alexandre Racine <alexandreracine gmail com>  2009-06-06 20:16:38 ---
Created an attachment (id=34332)
 --> (http://bugs.kde.org/attachment.cgi?id=34332)
3picISgone

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195494


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-06-06 22:32:22 ---
SVN commit 978353 by cgilles:

Set Cancel button from delete dialog as default button with keyboard layout.
BUGS: 195494

 M  +1 -1      deletedialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=978353

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195494





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2009-06-06 22:43:47 ---
Alexandre,

I guess you should have pressed SPACE instead of Enter. I guess Enter will use
the default action.

Anyway the above commit should have fixed it now.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=195494


Alexandre Racine <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |




--- Comment #6 from Alexandre Racine <alexandreracine gmail com>  2009-06-07 03:10:58 ---
Andi : Since we can move the selection, the blue contour, I don't think that
having one key equalling a default, without indication, should be there.
Especially not ENTER or SPACE.

Gilles : The problem if you put ENTER = an action, instead of ENTER = current
highlighted option, is that I do actually use ENTER to delete too. So the
correct way should be ENTER = current highlighted option. Does that sound more
logic?  And if the first highlighted option is "delete" just like it is
currently for me, this is good.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195494


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #7 from Gilles Caulier <caulier gilles gmail com>  2009-06-19 12:20:13 ---
SVN commit 983830 by cgilles:

set focus to Cancel button
BUGS: 195494


 M  +1 -0      deletedialog.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=983830

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=195494


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-06-20 12:44:29 ---
Gilles, this makes the normal workflow impossible: Press Del, press Enter to
confirm. That's how it's done everywhere. No the result is: Press Del, press
(blindly) Enter to confirm, nothing happens -> user is confused and files a bug
that deleting does not work.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195494





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-06-20 14:26:19 ---
Right Marcel,
I Will fix it.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=195494





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2009-06-20 15:34:34 ---
SVN commit 984215 by cgilles:

wrap around focused button from Delete dialog. Sound like Qt and KDE api do not
follow focus button set by keyboard.
CCBUGS: 195494


 M  +32 -5     deletedialog.cpp  
 M  +5 -1      deletedialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=984215

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=195494

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |AlbumsView

--
You are receiving this mail because:
You are the assignee for the bug.