[Bug 193422] New: when deleting images the icon view backs to top

classic Classic list List threaded Threaded
17 messages Options
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] New: when deleting images the icon view backs to top

Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422

           Summary: when deleting images the icon view backs to top
           Product: digikam
           Version: unspecified
          Platform: SuSE RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.11.0 svn (using KDE 4.2.85)
OS:                Linux
Installed from:    SuSE RPMs

If you delete an image from the middle or the bottom of a folder, when in icon,
mode the view backs to the first row of images. This is quite annoying because
you have to start again to search what you where looking for.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Gilles Caulier-4
https://bugs.kde.org/show_bug.cgi?id=193422


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Albums GUI
            Version|unspecified                 |0.11.0-svn
            Summary|when deleting images the    |new icon view (model/view
                   |icon view backs to top      |based) : when deleting
                   |                            |images the icon view backs
                   |                            |to top




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Gilles Caulier-4
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-05-21 10:24:55 ---
Salvatore,

Please checkout last code from svn and try again. Marcel work on this part
every day...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Salvatore Brigaglia
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #2 from Salvatore Brigaglia <opensourcecat gmail com>  2009-05-21 22:16:40 ---
niet... still there. This is also reproduceable if you scroll down an album,
hide digikam in the task bar and then resume it... it will show the first row
of images!

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Gilles Caulier-4
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-06-19 11:49:36 ---
Salvatore,

I cannot reproduce this problem using last code from svn...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Bugzilla from andi.clemens@gmx.net
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-07-01 10:39:32 ---
The same is true when tagging an album and having a filter turned on.
For example you open an album, turn on the "Not Tagged" filter, and start
tagging images. If you tag them, they will disappear and the view is scrolled
back to the top.
Before modelview, this was not the case.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Bugzilla from mikmach@wp.pl
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #5 from Mikolaj Machowski <mikmach wp pl>  2009-07-02 20:49:48 ---
@4, Andi - actually I like this behavior :)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Bugzilla from andi.clemens@gmx.net
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #6 from Andi Clemens <andi clemens gmx net>  2009-07-02 21:06:48 ---
Why?
You have 500 images in an album, you set the filter, you tag some items in the
middle of the view and than it jumps back... this is not helpful at all.
How can you like that?
:-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Bugzilla from mikmach@wp.pl
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #7 from Mikolaj Machowski <mikmach wp pl>  2009-07-02 21:55:04 ---
Andi, I mean that images are vanishing from view. Jumping to beginning isn't
nice.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Bugzilla from andi.clemens@gmx.net
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2009-07-02 22:04:38 ---
Yeah sure, removing the items is nice ;-)
So we have the same opinion... :-)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Marcel Wiesweg
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #9 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-07-03 19:23:06 ---
SVN commit 990995 by mwiesweg:

Part A of the problem: Try to preserve selection across layoutChanged().
Simply store one persistent index and one row number to indicate where about
the selection was before the layout change. That's not perfect but simple
and works for most cases.

CCBUG: 193422

 M  +32 -2     imagecategorizedview.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=990995

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Marcel Wiesweg
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-07-03 19:51:09 ---
SVN commit 991005 by mwiesweg:

Part B of the problem: Do not call updateScrollBars after layoutChanged();
everything is invalid!

Fix possible crash from Part A's solution.

 M  +6 -3      imagecategorizedview.cpp  
 M  +1 -1      kcategorizedview.cpp  


--- trunk/extragear/graphics/digikam/digikam/imagecategorizedview.cpp
#991004:991005
@@ -576,11 +576,14 @@
         QModelIndex indexToAnchor;
         if (currentSelection.contains(current))
             indexToAnchor = current;
-        else
+        else if (!currentSelection.isEmpty())
             indexToAnchor = currentSelection.first().topLeft();
-        d->hintAtSelectionRow = indexToAnchor.row();
-        d->hintAtSelectionIndex = model()->index(d->hintAtSelectionRow ==
model()->rowCount()
+        if (indexToAnchor.isValid())
+        {
+            d->hintAtSelectionRow = indexToAnchor.row();
+            d->hintAtSelectionIndex = model()->index(d->hintAtSelectionRow ==
model()->rowCount()
                                             ? d->hintAtSelectionRow :
d->hintAtSelectionRow + 1, 0);
+        }
     }
 }

--- trunk/extragear/graphics/digikam/digikam/kcategorizedview.cpp
#991004:991005
@@ -1769,7 +1769,7 @@
 {
     if (d->proxyModel && d->categoryDrawer &&
d->proxyModel->isCategorizedModel())
     {
-        d->updateScrollbars();
+        // all cached values are invalidated, recompute immediately
         rowsInsertedArtifficial(QModelIndex(), 0, d->proxyModel->rowCount() -
1);
     }
 }

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Marcel Wiesweg
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #11 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-07-03 19:52:51 ---
For me this problem is solved. If you confirm we can close it.

What is left as WONTFIX is the behavior that when the application is minimized
and restored, the view is scrolled to the current selected item. That's Qt
behavior.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Gilles Caulier-4
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.11.0-svn                  |1.0.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Bugzilla from andi.clemens@gmx.net
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422





--- Comment #12 from Andi Clemens <andi clemens gmx net>  2009-10-08 01:33:30 ---
So should we close it then...?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

Bugzilla from andi.clemens@gmx.net
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Andi Clemens <andi clemens gmx net>  2009-10-20 18:04:54 ---
I think it is solved, closing now.
Feel free to re-open it if really necessary.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[digikam] [Bug 193422] new icon view (model/view based) : when deleting images the icon view backs to top

bugzilla_noreply
In reply to this post by Salvatore Brigaglia
https://bugs.kde.org/show_bug.cgi?id=193422

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|AlbumsView                  |AlbumsView-Icons

--
You are receiving this mail because:
You are the assignee for the bug.