[Bug 192425] New: Star rating setting under thumbnails is a nuisance

https://bugs.kde.org/show_bug.cgi?id=192425

           Summary: Star rating setting under thumbnails is a nuisance
           Product: digikam
           Version: 0.10.0
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0 (using KDE 4.2.2)
OS:                Linux
Installed from:    Ubuntu Packages

I'd prefer to classify this as a usability bug, but I suppose that the
program is (unfortunately) working as designed, so I'll add it to the
wishlist.

I'm new to digiKam 0.10.0 having used 0.9.x for a few years. One of
the most annoying new features is the ability to set the star rating
by clicking on the stars that appear when I roll the mouse pointer
over the space below a thumbnail in the album view. Until an image is
rated, that space appears blank, so it is a natural target for my
mouse pointer when I'm selecting images by clicking on ranges or
dragging a rectangle over them. I lost count of the number of times I
unintentionally rated an image or changed its rating by accidentally
clicking on this empty space and only then noticing the effect of the
roll-over and the appearance of the star-rating control.

I would much prefer (even if it is just an option) to have the star
rating control appear at all times below the image (showing the
five white stars or the text "Not Rated", if nothing is selected)
so that I can tell where not to click when navigating and selecting
images. At present, it feels like I'm navigating a mine field: I have
to check that I have not rolled over anything before every click of
the mouse button, which makes it slower to navigate images than it
should be.

I think that the *concept* of being able to set the stars on the
thumbnail is an improvement over the 0.9.x approach where the setting
was on the side panel. However, I am having such annoying usability
issues with the *implementation* that I wish the feature had never
been added.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=192425


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Usability




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-05-12 13:11:21 ---
Right. i have same problem here.

Displaying empty stars if item is not rate sound like the simplest issue.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #2 from Mikolaj Machowski <mikmach wp pl>  2009-05-12 21:43:49 ---
I will make interface terribly cluttered...

I would suggest different solution (very similar to Adobe Bridge):

White rectangle with small arrow. When arrow clicked show menu with color
labels (yaaay ;) - after choosing label rectangle changes color. But when
hovering over this rectangle show stars.

Five empty stars below each photo will look bad (IMO).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-05-13 06:25:03 ---
Mik,

Do you have screenshots from Adobe Bridge ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #4 from DGardner <dkde gardnersworld org>  2009-05-13 09:09:42 ---
Sounds good to me, Mikolaj, as long as the rectangle is always visible
(i.e., it does not default to a white rectangle on a white background
with no outline). My problem is that I find it hard to know where not
to click.

Damo.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #5 from DGardner <dkde gardnersworld org>  2009-05-13 10:52:53 ---
Some (tiny) screenshots here:


http://books.google.ie/books?id=E3Urw48Oz74C&pg=PA56&lpg=PA56&dq=adobe+bridge+stars+%22color+code%22&source=bl&ots=waTHcnWSiZ&sig=Asfa0zomLCKpLmK1oF8UYmVODhk&hl=en&ei=2oYKSs2VNJWD-AaB--3YCw&sa=X&oi=book_result&ct=result&resnum=16#PPA56,M1

Sorry, that was all I could find.

Someone else had a problem with accidentally hitting hotkeys and
changing the ratings in Photoshop:

  http://forums.adobe.com/thread/358670

They asked for a "safety lock" for the ratings. Perhaps that is all
that digiKam needs: a toggle button on the tool-bar to set whether
clicking below the thumbnails affects the star ratings or not. That
would probably be trivial to implement and would solve my problem.
I like the ratings and the way they work, I just keep clicking on
them by accident and wasting time correcting my mistakes.

Colour-coding would be a nice extra.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #6 from Mikolaj Machowski <mikmach wp pl>  2009-05-13 18:20:16 ---
Sorry, Gilles, "memoria fragilis est" - I mixed two interfaces - Adobe Bridge
and FotoStation (with small bits of IMatch). But both are interesting and with
taking elements from both of them we can agree on good mechanism.

1. Adobe Bridge. There is empty space below image like in digiKam in this space
after selection of image, dots will appear which can be selected and become
stars. You can also choose labels from main menu (not mini-menu I previously
described) and those color will appear as visible in DGardner links or your own
from other bug report:
http://digikam3rdparty.free.fr/OthersSoftware/Bridge/adobebridge-colorlabeltags.jpg
(on your screenshot there are no stars but they would  be overlayed over color
labels)
2. FotoStation: After hovering ca. 250ms over image plate small widget will
appear in lower part of image. It will containg X and 5 dots. Rating is
assigned after clicking dots, X removes rating. If you select images quickly,
before special area is activated image is selected - even if this is area of
rating - rating isn't assigned. Color labels are assigned through mini-menu on
bottom of image plate and this mini-menu is used only for color labels. IMatch
has similar mini-menu but it is practically full context menu (terribly long).

My suggestion is similar Adobe Bridge:
Don't show area or anything by default. All special actions are shown only
after selection of image. In this way first click will only select image (or
when clicked in image perform preview/edit action) and shows all additional
widgets. Maybe even show those additional elements only on one image where
mouse is?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=192425


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #7 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-05-13 19:05:00 ---
What about (additionally) a "fast rating mode", enabled by menu, where rating
stars are outlined as shadows and rating widget is shown on entering with the
mouse, but all that only temporarily for fast rating of many pictures?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=192425


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Usability                   |Thumbnails
            Version|0.10.0                      |1.0.0




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-06-01 21:15:14 ---
Marcel,

First i would to solve this issue for 1.0

About your proposal, it sound a little bit complicated to do, and require
important changes.

This is my proposal : Using QTimeLine with RatingBox, to display progressively
rating stars over item, using alpha blending with background, like selection or
rotation icons are displayed.

The goal is to force user to stay over RatingBox before to be able to rate item
really. A delay between 500-800 ms can be enough. no more. During this delay,
RatingBox is displayed progressively to be more visible step by step. User can
only rate when widget is fully visible.

What do you think about ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=192425


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-06-02 19:13:00 ---
SVN commit 976791 by cgilles:

remove RatingBox widget. Use RatingWidget instead everywhere.
RatingWidget has now a fading mode to display progressively widget
This mode is used in new icon-view based on Model View to switch is edit mode
when
user move mouse over the widget.
During fading, widget appear and rating cannot be edited. fading duration is
1500ms.
This will prevent unwanted rating assignation to item when user move mouse over
the item to
just only select it.
To really want to change rating to item, user need to stay over rating widget
more than
fading duration.
This patch only change this behavour in iconview, not with thummbar. Thumbbar
is not yet
ported to Model/View, but when it will done, we will use same component than
iconview and
problem will be fixed automatically there.
BUG: 192425


 M  +0 -1      CMakeLists.txt  
 M  +7 -6      digikam/albumiconviewfilter.cpp  
 M  +18 -17    digikam/iconview.cpp  
 M  +26 -24    digikam/imagepreviewbar.cpp  
 M  +10 -6     digikam/imageratingoverlay.cpp  
 M  +3 -2      digikam/imageratingoverlay.h  
 D             digikam/ratingbox.cpp  
 D             digikam/ratingbox.h  
 M  +174 -65   digikam/ratingwidget.cpp  
 M  +14 -0     digikam/ratingwidget.h  
 M  +1 -0      libs/imageproperties/imagedescedittab.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=976791

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

https://bugs.kde.org/show_bug.cgi?id=192425


Marcel Wiesweg <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |




--- Comment #10 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-06-02 19:16:40 ---
I agree that fading in the rating box like the other buttons is better than the
current solution.

Notwithstanding, with the number of overlays that we have or plan: Selection,
Rotation, Rating, color tags, maybe comment editing in the future - I can
imagine that some users will feel this is overloaded and want to switch off
some of these. This could be done by simple actions in the View menu.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #11 from Andi Clemens <andi clemens gmx net>  2009-06-02 19:52:07 ---
For me the fading is much too long now. Also the widget is invisible when no
rating has been done. Sure it was like this before, but at least you could have
find it more easily by accident in the past, when you were hovering over the
item.
Now it doesn't appear for a long time, and you need to really know where the
widget should be.
I can only speak for myself, but right now it is so slow that I rather use the
keyboard shortcuts :)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #12 from Mikolaj Machowski <mikmach wp pl>  2009-06-02 22:35:43 ---
Delays in KDE (and MS-Windows) interface are usually 500ms. I think this is
enough to make quick selection and move further but not so long that use will
get bored ;)

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #13 from Mikolaj Machowski <mikmach wp pl>  2009-06-02 22:57:25 ---
I see also when hovering 6 outline stars. It is reduced to five after adding
rating.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #14 from Mikolaj Machowski <mikmach wp pl>  2009-06-02 23:01:10 ---
Created an attachment (id=34208)
 --> (http://bugs.kde.org/attachment.cgi?id=34208)
six stars in album gui

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #14 from Mikolaj Machowski <mikmach wp pl>  2009-06-02 23:01:10 ---
Created an attachment (id=34208)
 --> (http://bugs.kde.org/attachment.cgi?id=34208)
six stars in album gui

--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2009-06-02 23:01:28 ---
>For me the fading is much too long now. Also the widget is invisible when no
>rating has been done. Sure it was like this before, but at least you could have
>find it more easily by accident in the past, when you were hovering over the
>item.
>Now it doesn't appear for a long time, and you need to really know where the
>widget should be.
>I can only speak for myself, but right now it is so slow that I rather use the
>keyboard shortcuts :)

Look in d private container :

http://websvn.kde.org/trunk/extragear/graphics/digikam/digikam/ratingwidget.cpp?revision=976791&view=markup

duration = 1500;   // ms

change the value and try again...

>Delays in KDE (and MS-Windows) interface are usually 500ms. I think this is
>enough to make quick selection and move further but not so long that use will
>get bored ;)

600ms to be precise :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/widgets/common/itemviewhoverbutton.cpp#57

... this is for the select button over icon view item.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #16 from Gilles Caulier <caulier gilles gmail com>  2009-06-02 23:14:13 ---
6 stars ???

this screenshot is taken during rate edition. right ?

Originaly, image do not have rating. right ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #17 from Mikolaj Machowski <mikmach wp pl>  2009-06-02 23:29:14 ---
Changed for 500ms and it is much more acceptable.

But it is hard to hit area when stars will be activated. Shouldn't be better if
*all* overlay elements would be visible after hovering over plate (with some
delay of course)?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #18 from Mikolaj Machowski <mikmach wp pl>  2009-06-02 23:31:04 ---
@16 - Gilles

Yes, originally this image didn't have rating. When I assign stars I will se
only 5 stars (with some outlined). Even after removal of rating for this image
next time I will be presented only with five outlined stars.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=192425





--- Comment #19 from Gilles Caulier <caulier gilles gmail com>  2009-06-02 23:33:50 ---
ok, with unrated picture, i can reproduce here. investiguation under progress

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel