[Bug 184156] New: showfoto lensfun select wrong lens

http://bugs.kde.org/show_bug.cgi?id=184156

           Summary: showfoto lensfun select wrong lens
           Product: digikam
           Version: 0.10.0-rc1
          Platform: Slackware Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-rc1 (using KDE 4.2.0)
OS:                Linux
Installed from:    Slackware Packages

When I open the picture in showfoto and try to fix the lens distortion showfoto
didnt select the correct lens.. "always" show "Nikon 24-85mm" didnt fill the
Lens model correctl the option "Use Metadata" is ON.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=184156


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |general
            Product|digikam                     |showfoto
            Version|0.10.0-rc1                  |0.10.0




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=184156


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Lens Distortion
            Product|showfoto                    |digikamimageplugins
            Version|0.10.0                      |0.10.0-svn




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #1 from Andi Clemens <andi clemens gmx net>  2009-02-19 08:25:26 ---
And what lens should be displayed? For me it is working fine (Nikon D50 and
Panasonic DMC-FZ3).

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #2 from Ricardson Williams <ricardsonwilliams yahoo com br>  2009-02-19 10:31:09 ---
In my case should display Nikon 17-55 lens.. and always show 24-85mm, the
machine model no problem..

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #3 from Andi Clemens <andi clemens gmx net>  2009-02-19 12:54:27 ---
Can you attach an example image? If you don't want to provide it here, you can
sent it to me by mail.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #4 from Andi Clemens <andi clemens gmx net>  2009-02-19 16:26:19 ---
Right now I can't tell if it is a bug in digiKam or lensfun, but it doesn't
work for my Nikkor 18-55mm, 1:3,5-5.6G ED AF S-DX, too.
If you take a look at the image properties tab, you see a strange lens name:
48 50 48 49 118 202 103 220 10 206 242 106 190 40 168 204 136 249 18 222 49 194
47 38 240 43 86 109 114 111 86

I don't think this is correct :-)
Need to do further investigations.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2009-02-19 16:53:17 ---
Nikon lens name is extracted to makernote using Exiv2. Nikon is know to encrypt
informations (:=(((. I remember a topic about in Exiv2 bugzilla. I don't know
if it's solved now.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #6 from Andi Clemens <andi clemens gmx net>  2009-02-19 17:18:39 ---
Right, mostly all Nikon lens seem to fail, but there are fixes for 0.18.1.
I will check the SVN version and see if it is working in there.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #7 from Andi Clemens <andi clemens gmx net>  2009-02-19 17:47:08 ---
Created an attachment (id=31476)
 --> (http://bugs.kde.org/attachment.cgi?id=31476)
lens data

I compiled latest trunk and at least your lens is detected by the command line
tool, see the attachment. Mine is still not recognized :-(

But digiKam / showFoto still displays the strange number code in the Photograph
Information tab. Why?
I recompiled libkexiv2 etc and digiKam, but it is not read properly... I know
digikam uses db for this data, too, but I tested also with showFoto and no lens
data is available.

Gilles,

any idea?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #8 from Gilles Caulier <caulier gilles gmail com>  2009-02-19 18:14:40 ---
Sound like something is missing in libkexiv2 to decode these informations.

Andreas,

There is something special in Exiv2 command line tool to decode Nikon Lens info
?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #9 from Andreas Huggel <ahuggel gmx net>  2009-02-20 01:08:05 ---
Gilles,

No, the command line tool doesn't do anything special, this is done in the
library. But what about this:

http://uk.groups.yahoo.com/group/exiv2/message/1408

Decrypting only works if digiKam/libkexiv2 use the new method to call the
pretty-print function.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #10 from Andreas Huggel <ahuggel gmx net>  2009-02-20 16:52:36 ---
Andi,

I've updated the Nikon lens list to the latest version (this database is a
separate project maintained by Robert Rottmerhusen). Can you svn update and try
again? If your lens is still not recognized, please send me an image together
with the exact lens name (see the list near the end of nikonmn.cpp file for
details/comparison).

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #11 from Andi Clemens <andi clemens gmx net>  2009-02-21 14:59:56 ---
Andreas,

somehow it seems to work now and then, I'm using the SVN built from 4 days ago.

Error: Directory NikonPreview with 8224 entries considered invalid; not read.
Exif.Nikon3.LensType                         Byte        1  D G
Exif.Nikon3.Lens                             Rational    4  18-55mm F3.5-5.6
Exif.Nikon3.LensFStops                       Undefined   4  5.33333
Exif.Nikon3.LensData                         Undefined  31  Nikon AF-S DX
Zoom-Nikkor 18-55mm f/3.5-5.6G ED

The first error message is weird... but at least the lens is detected.
Sometimes it happens that it only reads those numbers again.

I will compile latest trunk later on, right now I'm too busy.
Still in digiKam it is not working, but that seems to be our fault then.

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2009-02-21 17:11:42 ---
Andi, Andreas,

Code relevant to Lens detection is here :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp#558

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #13 from Andreas Huggel <ahuggel gmx net>  2009-02-22 08:01:32 ---
Ok. I suggest this fix in KExiv2::getExifTagString (kexiv2exif.cpp, line 679):
Just replace

684         Exiv2::ExifData exifData(d->exifMetadata);
...
688             std::ostringstream os;
689             os << *it;
690             QString tagValue = QString::fromLocal8Bit(os.str().c_str());

with

684         const Exiv2::ExifData& exifData(d->exifMetadata);
...
688             std::string val = it->print(&exifData);
689             QString tagValue = QString::fromLocal8Bit(val.str().c_str());

or is there a particular reason why the Exif metadata container must be copied
in line 684?

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #14 from Gilles Caulier <caulier gilles gmail com>  2009-02-22 09:35:22 ---
Andreas

>or is there a particular reason why the Exif metadata container must be copied
>in line 684?

With older Exiv2 (< 0.14), yes to prevent crash with mutithreading. With recent
Exiv2, it work fine.

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2009-02-22 09:52:02 ---
Andreas,

QString tagValue = QString::fromLocal8Bit(val.str().c_str());

must be :

QString tagValue = QString::fromLocal8Bit(val.c_str());

... else it doesn't compile :

[ 11%] Building CXX object
libs/libkexiv2/libkexiv2/CMakeFiles/kexiv2.dir/kexiv2exif.o
/home/gilles/Documents/devel/SVN/trunk/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2exif.cpp:
In member function ‘QString KExiv2Iface::KExiv2::getExifTagString(const char*,
bool) const’:
/home/gilles/Documents/devel/SVN/trunk/kdegraphics/libs/libkexiv2/libkexiv2/kexiv2exif.cpp:690:
error: ‘struct std::string’ has no member named ‘str’

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #16 from Gilles Caulier <caulier gilles gmail com>  2009-02-22 09:53:04 ---
SVN commit 929807 by cgilles:

patch exiv2 with Andreas tip. Need to be tested.
CCBUGS: 184156


 M  +5 -5      kexiv2exif.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=929807

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #17 from Gilles Caulier <caulier gilles gmail com>  2009-02-22 09:54:02 ---
Andi,

libkexiv2 from trunk is patched. can you try again ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel