[Bug 184156] New: showfoto lensfun select wrong lens

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #18 from Gilles Caulier <caulier gilles gmail com>  2009-02-22 10:07:22 ---
Andreas,

it->print() function exists since which Exiv2 version ?

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #19 from Andi Clemens <andi clemens gmx net>  2009-02-22 10:19:59 ---
Gilles,

it is working in showFoto, but not in digiKam. I guess the lens value is saved
in the database.
Lensfun still selects the wrong lens, but I guess they have their own database.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #20 from Andi Clemens <andi clemens gmx net>  2009-02-22 10:41:50 ---
Created an attachment (id=31536)
 --> (http://bugs.kde.org/attachment.cgi?id=31536)
lens display in showFoto

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #21 from Gilles Caulier <caulier gilles gmail com>  2009-02-22 11:51:53 ---
>lens display in showFoto

ok. this is want mean that patch work fine.

>it is working in showFoto, but not in digiKam. I guess the lens value is saved
>in the database.

yes it's stored in DB. you must sync again DB with photo metadata

>Lensfun still selects the wrong lens, but I guess they have their own database.

yes, if lensfun do not have an entry relevant of your lens, nothing special
will be done. At least a message in plugin must be displayed if lens is not
found...

Gilles

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #22 from Andreas Huggel <ahuggel gmx net>  2009-02-22 17:08:17 ---
> it->print() function exists since which Exiv2 version ?

std::string print(const ExifData* pMetadata =0) const;
in class Exiv2::Metadatum exists since 0.18-pre2. Before that it was print()
without any argument.

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156


Andi Clemens <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
                   |                            |t




--- Comment #23 from Andi Clemens <andi clemens gmx net>  2009-03-10 11:52:18 ---
*** Bug 169214 has been marked as a duplicate of this bug. ***

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #24 from Andi Clemens <andi clemens gmx net>  2009-03-10 16:56:05 ---
Created an attachment (id=31993)
 --> (http://bugs.kde.org/attachment.cgi?id=31993)
lensfun -> showfoto: different lens names?

I don't know if this is an issue, but I compared a lot of images now (taken
with different cameras of course) and lensfun always displays another lens name
then showfoto / exiv2.
Because of this everytime the first item in the camera lens combobox of lensfun
plugin is selected, although the lens name is listed in the combobox.
In this screenshot you can see that the first lens in the list was chosen, but
the actual lens is listed in the combobox, too.
There seem to be significant differences in the names from lensfun and exiv2,
this is why the lenses are never selected correctly.

I can remember that my lens was displayed as "Nikkor  18-55mm Lens...." in
showfoto some weeks ago, but not it only reads "18-55mm F3.5-5.6", so maybe
this is the reason lensfun auto detection is not working at all.

Did exiv2 change the name resolution in some way?

Andi

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #25 from Andreas Huggel <ahuggel gmx net>  2009-03-10 17:27:44 ---
> I can remember that my lens was displayed as "Nikkor  18-55mm Lens...." in
> showfoto some weeks ago, but not it only reads "18-55mm F3.5-5.6", so maybe
> this is the reason lensfun auto detection is not working at all.
>
> Did exiv2 change the name resolution in some way?

No it should still be the same, although I've updated the Nikon lens list
recently - http://dev.exiv2.org/repositories/revision/exiv2/1751

Is there a difference between showfoto+exiv2-SVN and exiv2-SVN output?
Or between exiv2-SVN and exiv2-0.18?

Andreas

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #26 from Andi Clemens <andi clemens gmx net>  2009-03-12 14:23:29 ---
I can't see any differences.
But maybe lensfun is expecting the LensData field?

Exif.Nikon3.LensType                         Byte        1  D G
Exif.Nikon3.Lens                             Rational    4  18-55mm F3.5-5.6
Exif.Nikon3.LensFStops                       Undefined   4  5.33333
Exif.Nikon3.LensData                         Undefined  31  Nikon AF-S DX
Zoom-Nikkor 18-55mm f/3.5-5.6G ED

This looks more like the string in lensfun then the Lens value we seem to use.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-svn                  |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #27 from Gilles Caulier <caulier gilles gmail com>  2010-01-25 14:35:18 ---
Andi,

Whats news there ? It's Exiv2 or lensfun issue ? Solved with last version ?

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #28 from Andi Clemens <andi clemens gmx net>  2010-01-25 22:45:44 ---
Hmm don't know what's wrong here, but I can still reproduce it.

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=184156


Jens Mueller <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #29 from Jens Mueller <tschenser gmx de>  2010-04-11 00:15:09 ---
I added some additional lensfun search in rev1111465. Andi, others: can you
please try it again? The one of my nikon lenses that is in lensfun db is found
and selected.

Jens

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

["Jens Müller"]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #30 from Jens Mueller <tschenser gmx de>  2010-04-15 00:05:46 ---
SVN commit 1114931 by jmueller:

do lensfun search not only for lenses, do it also for make and model

CCBUGS: 184156

 M  +26 -2     lensfuncameraselector.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1114931

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #31 from Gilles Caulier <caulier gilles gmail com>  2010-09-18 10:39:16 ---
Jens,

I work hard to improve metadata parsing and detect better lens type to pass on
LensFun. I fully rewritten the code about in trunk. Please take a look

The goal of this work is to provide a new BQM tool to fix lens distorsion...
The tool must be able to apply correction automatically...

Note : in digikam/libs/dimg/filters/lens, there is a new small command line
test program to parse an image and detect lens type. All is printed to the
console. The program is to hack parsing metadata code from digiKam
lensfuniface...

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #32 from Gilles Caulier <caulier gilles gmail com>  2010-09-18 10:41:06 ---
For BQM lensfun tool, take a look there :

https://bugs.kde.org/show_bug.cgi?id=216353

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #33 from Gilles Caulier <caulier gilles gmail com>  2010-09-18 10:44:57 ---
Jens,

The new code to parse metadata is not in lensfun widget anymore. I migrarted it
to lensfun iface, to make a BQM tool more easily.

Look this method :

http://lxr.kde.org/source/extragear/graphics/digikam/libs/dimg/filters/lens/lensfuniface.cpp#103

Please, test, hack, and report. I need help there. Thanks in advance

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #34 from Gandalf Lechner <gandalf lechner univie ac at>  2010-09-18 21:49:26 ---
With a fresh svn checkout, the automatic lens distortion correction crashes as
soon as I select it from the menu. In the console I read

digikam(19485)/digikam (core) Digikam::EditorToolThreaded::slotEffect: Preview
"Linsenautokorrektur"  started...
digikam: symbol lookup error: /usr/lib/kde4/digikamimageplugin_enhance.so:
undefined symbol:
_ZN7Digikam12LensFunIface17setFilterSettingsERKNS_16LensFunContainerE

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0                      |1.5.0




--- Comment #35 from Gilles Caulier <caulier gilles gmail com>  2010-09-18 22:22:46 ---
Make clean all, and recompile/install whole digiKam.

Gilles Caulier

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=184156





--- Comment #36 from Gilles Caulier <caulier gilles gmail com>  2010-09-29 15:32:56 ---
SVN commit 1180943 by cgilles:

deal with Canon Lens and LensType tags when Lensfun search lens description
from metadata
If Exiv2 cannot decrypt lens data, it will return a number, not a string.
CCBUGS: 184156


 M  +2 -1      dmetadata.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=1180943

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel