[Bug 182599] New: Hotkey / shortcut assignment lost ( = back to default) after restart

http://bugs.kde.org/show_bug.cgi?id=182599

           Summary: Hotkey / shortcut assignment lost ( = back to default)
                    after restart
           Product: digikam
           Version: 0.10.0-rc1
          Platform: Gentoo Packages
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-rc1 (using KDE 4.2.0)
Installed from:    Gentoo Packages

The shorcut configuration dialog opens very slowly (2-3 seconds).

Configuration is possible, but after restart, configuration changes are lost.

(Attachment: stderr of digikam)

Furthermore, the configuration dialog crashes sporadically, see attached
backtrace.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #1 from Ian Hubbertz <kde_bugs hubbertz de>  2009-01-31 16:22:41 ---
Created an attachment (id=30785)
 --> (http://bugs.kde.org/attachment.cgi?id=30785)
stderr output of digikam


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #2 from Ian Hubbertz <kde_bugs hubbertz de>  2009-01-31 16:23:07 ---
Created an attachment (id=30786)
 --> (http://bugs.kde.org/attachment.cgi?id=30786)
backtrace of shortcut configuration crash


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=182599


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |setup




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever Confirmed|0                           |1




--- Comment #3 from Andi Clemens <andi clemens gmx net>  2009-01-31 16:32:53 ---
I can confirm this... changes are lost after restart.
I guess the slowdown comes from querying all the kipi-plugins.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

http://bugs.kde.org/show_bug.cgi?id=182599


Marcel Wiesweg marcel wiesweg gmx de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #4 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-01-31 22:47:43 ---
The "Configure shortcuts" dialog is a service from KMainWindow, I dont see any
code related to this in digikam, is this right?
I think we just plug all our actions into the action collection and kdeui
provides the configuration.
In this case we have to move the bug to kdelibs / kdeui / XMLGui framework.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #5 from Andi Clemens <andi clemens gmx net>  2009-01-31 22:56:33 ---
It is working in showFoto / EditorWindow. I tested this with many actions, none
of the ones from MainWindow are saved, but all in ImageEditor are.
But I can't find any differences in the code.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2009-02-01 00:10:19 ---
Oh what I forgot in my previous comment: Shortcut saving works beautifully for
me. One "unusual shortcut" that I created for testing before restarting digikam
several times is still working.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #7 from Ian Hubbertz <kde_bugs hubbertz de>  2009-02-01 16:52:28 ---
For me, other applications work fine - only digikam has the problem.

What I tried is changing the rating shortcuts from Ctrl-1 to 1, Ctrl-2 to 2
etc..


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #8 from Andi Clemens <andi clemens gmx net>  2009-02-01 17:24:04 ---
I tested it again and it seems to work with all digiKam shortcuts, but if you
change the kipi-plugins actions, it is not saved.
So all modified actions in "general" are saved, but the rest is not.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #9 from Gilles Caulier <caulier gilles gmail com>  2009-02-03 10:23:26 ---
SVN commit 920568 by cgilles:

digiKam from trunk : ignore some renamed kipi plugins in loaders which can make
some troubles with keyboard shortcuts editor.
CCBUG: 182599
CCMAIL: [hidden email]


 M  +5 -0      digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=920568


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #10 from Gilles Caulier <caulier gilles gmail com>  2009-02-03 13:30:48 ---
This is my tests :

- digiKam for KDE3 save kipi-plugins shortcuts.
- digiKam for KDE4 do not save kipi-plugins shortcuts.
- others digiKam actions shortcuts are saved.

Code relevant :

http://lxr.kde.org/source/extragear/graphics/digikam/digikam/digikamapp.cpp#2029

- tested with Kphotoalbum ==> same problem: kipi shortcuts are not saved.

Code relevant :

http://lxr.kde.org/source/extragear/graphics/kphotoalbum/MainWindow/Window.cpp#1151

The job to save shortcuts is delegate to KDELibs :

http://api.kde.org/4.x-api/kdelibs-apidocs/kdeui/html/classKShortcutsDialog.html#ae5f3147f22cac3cb9e4743ba8faa0bf

For me this is a KDELibs bug...

PS: tested here with KDE 4.1.3

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #11 from Andi Clemens <andi clemens gmx net>  2009-02-03 13:46:18 ---
Maybe we define something wrong in the plugins?
Is actionCollection() a part of every plugin or is it the action collection
from KIPI::Plugin?

Maybe we need to manually save settings here?
Maybe a kmainwindow widget automatically saves all modified actions whereas
KIPI::Plugin does not?

If you change a shortcut for a KIPIplugin, quit shortcut editor and come back
again, the shortcut is still there. Only after a restart it will be gone.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=182599


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|setup                       |shortcuts
            Product|digikam                     |kdelibs
            Version|0.10.0-rc1                  |4.1




--- Comment #12 from Gilles Caulier <caulier gilles gmail com>  2009-02-03 13:53:15 ---
>If you change a shortcut for a KIPIplugin, quit shortcut editor and come back >again, the shortcut is still there. Only after a restart it will be gone.

It's clear... this job is deleguate to KDELibs and work fine in KDE3. It's a
regression. I move this file to KDElibs component now...

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=182599


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
         AssignedTo|[hidden email]       |[hidden email]




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|[hidden email]     |[hidden email]




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #13 from Andi Clemens <andi clemens gmx net>  2009-02-04 17:18:23 ---
SVN commit 921214 by aclemens:

Add one common KIPI-Plugins actionCollection(), to clean up shortcut
editor dialog. Put actions of every plugin in there. If a plugin has
more then 3 actions, generate a dedicated category inside the
actionCollection.

BUG:182599

 M  +22 -2     digikamapp.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=921214


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #14 from Andi Clemens <andi clemens gmx net>  2009-02-04 17:39:59 ---
SVN commit 921247 by aclemens:

The KIPI shortcut settings where only loaded when the shortcut editor
was started. To fix this, we need to make kipiplugins actionCollection
globally available and move the actionCollection setup into
slotKipiPluginPlug()

CCBUG:182599

 M  +24 -29    digikamapp.cpp  
 M  +4 -0      digikamappprivate.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=921247


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #15 from Gilles Caulier <caulier gilles gmail com>  2009-02-04 17:48:59 ---
Andi,

It doesn't compile with KDE 4.1.3:

[ 17%] Building CXX object digikam/digikam/CMakeFiles/digikam.dir/digikamapp.o
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/digikam/digikamapp.cpp:42:29:
error: kactioncategory.h: No such file or directory
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/digikam/digikamapp.cpp:
In member function ‘void Digikam::DigikamApp::slotKipiPluginPlug()’:
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/digikam/digikamapp.cpp:2209:
error: ‘KActionCategory’ was not declared in this scope
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/digikam/digikamapp.cpp:2209:
error: ‘category’ was not declared in this scope
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/digikam/digikamapp.cpp:2209:
error: expected type-specifier before ‘KActionCategory’
/home/gilles/Documents/devel/SVN/trunk/graphics/digikam/digikam/digikamapp.cpp:2209:
error: expected `;' before ‘KActionCategory’
make[2]: *** [digikam/digikam/CMakeFiles/digikam.dir/digikamapp.o] Error 1
make[1]: *** [digikam/digikam/CMakeFiles/digikam.dir/all] Error 2
make: *** [all] Error 2

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=182599





--- Comment #16 from Andi Clemens <andi clemens gmx net>  2009-02-04 17:55:32 ---
Damn... I got the idea from gwenview... hmm... I can remove / comment this for
now, the bug should still be solved, but the editor dialog will become less
readable again.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel