[Bug 179653] New: "Filter active" icon not set if filter is "rating equals zero stars"

http://bugs.kde.org/show_bug.cgi?id=179653

           Summary: "Filter active" icon not set if filter is "rating equals
                    zero stars"
           Product: digikam
           Version: 0.10.0-beta7
          Platform: Compiled Sources
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-beta7 (using Devel)
OS:                Linux
Installed from:    Compiled sources

Set rating filter to zero stars and condition to "equals". --> The filter
indicator in the status bar remains off (white/grey).

Wished behaviour: It should switch green or red respectively.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179653


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Filter




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179653





--- Comment #1 from Ian Hubbertz <kde_bugs hubbertz de>  2009-01-04 23:35:29 ---
Created an attachment (id=29912)
 --> (http://bugs.kde.org/attachment.cgi?id=29912)
Patch that should solve the problem

Now a filter is recognized if the rating filter is != 0 stars OR the condition
is not greaterEqual.

Due to other compile errors (marble integration), I was not able to compile and
test the patch.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179653





--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-01-05 06:01:02 ---
Andi, Marcel,

0.10.0-Beta8 tarball is not yet released. We can trying to include this patch
today if we test it soon.

Gilles Caulier


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179653





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-01-05 09:05:18 ---
SVN commit 905821 by cgilles:

fix rating filter rules if filter is "rating equals zero stars"
CCBUG: 179653


 M  +3 -0      albumiconviewfilter.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=905821


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179653


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #4 from Gilles Caulier <caulier gilles gmail com>  2009-01-05 09:31:13 ---
SVN commit 905829 by cgilles:

backport commit #905821 from KDE3 branch
BUG: 179653


 M  +2 -3      albumiconviewfilter.cpp  
 M  +1 -1      albumiconviewfilter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=905829


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179653





--- Comment #5 from Ian Hubbertz <kde_bugs hubbertz de>  2009-01-05 13:05:34 ---
> fix rating filter rules if filter is "rating equals zero stars"
> CCBUG: 179653
>
>
>  M  +3 -0      albumiconviewfilter.cpp  

In kde3 branch, you didn't remove the old line, so for a rating filter != 0,
"Rating" is added twice to the filtersList.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179653





--- Comment #6 from Gilles Caulier <caulier gilles gmail com>  2009-01-05 13:13:32 ---
SVN commit 905929 by cgilles:

missing to remove old lines with previous commit
CCBUGS: 179653


 M  +1 -4      albumiconviewfilter.cpp  
 M  +1 -1      albumiconviewfilter.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=905929


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=179653


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-beta7                |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel