[Bug 179298] New: digikam scan for new images progress bar starts at 100%

http://bugs.kde.org/show_bug.cgi?id=179298

           Summary: digikam scan for new images progress bar starts at 100%
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-beta8 (rev.: 904148M) (using Devel)
Installed from:    Compiled sources

At the start of the scan the progress bar displays 100% instead of 0% until the
"real" scan starts.

Esp. on slow machines (I'm sorry for having one :) ) this is somewhat
irritating, esp. when testing beta versions, not knowing if digikam has gone to
meet its makers.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179298


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|unspecified                 |0.10.0-beta8




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179298


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Gilles Caulier <caulier gilles gmail com>  2009-01-01 18:00:26 ---
SVN commit 904217 by cgilles:

reset progress bar when dialog is created.
Roman : this patch must be fine, but like i have only fast computers here, i'm
not sure if all will be fine for you.
BUG: 179298


 M  +3 -1      dprogressdlg.cpp  
 M  +1 -1      dprogressdlg.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=904217


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=179298





--- Comment #2 from Roman Fietze <rfkd fietze-home de>  2009-01-01 21:13:19 ---
(In reply to comment #1)

> SVN commit 904217 by cgilles ...

Thanks for that pointer.

> i'm not sure if all will be fine for you

Not really. So I took the time and checked the sources. Instead of adding
reset() to DProgressDlg CTOR, changing ScanController::createProgressDialog
would probably a better solution. But because I'm new to digikam source code, I
cannot know if that would have any side effects. At least it seems to work
here.

Index: digikam/libs/dialogs/dprogressdlg.cpp
===================================================================
--- digikam/libs/dialogs/dprogressdlg.cpp       (revision 904225)
+++ digikam/libs/dialogs/dprogressdlg.cpp       (working copy)
@@ -128,8 +128,6 @@

     connect(this, SIGNAL(cancelClicked()),
             this, SLOT(slotCancel()));
-
-    reset();
 }

 DProgressDlg::~DProgressDlg()
Index: digikam/digikam/scancontroller.cpp
===================================================================
--- digikam/digikam/scancontroller.cpp  (revision 904225)
+++ digikam/digikam/scancontroller.cpp  (working copy)
@@ -268,7 +268,7 @@
                                       "are registered in a database.") );

     d->progressDialog->setMaximum(1);
-    d->progressDialog->setValue(1);
+    d->progressDialog->setValue(0);

     connect(this, SIGNAL(incrementProgressDialog(int)),
             d->progressDialog, SLOT(incrementMaximum(int)));


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=179298





--- Comment #3 from Gilles Caulier <caulier gilles gmail com>  2009-01-01 21:56:24 ---
SVN commit 904295 by cgilles:

set progress bar to zero at startup when scancontroller start to work.
Marcel, Andi, do not forget "endl" at end of kDebug and kDwarning else
sometimes, kdelibs can crash
CCMAIL: [hidden email]
CCBUG: 179298


 M  +37 -37    scancontroller.cpp  
 M  +2 -3      scancontroller.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=904295


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=179298


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-beta8                |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=179298

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Database-Scan
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.