[Bug 172898] New: Verbiage changes for Util-ImageEditor-ImageResize.cpp

classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 172898] New: Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from mailinglist@endosquid.com
http://bugs.kde.org/show_bug.cgi?id=172898

           Summary: Verbiage changes for Util-ImageEditor-ImageResize.cpp
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: unspecified
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:            (using Devel)
Installed from:    Compiled sources

Clearing up some of the WhatsThis text to explain things more clearly.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from mailinglist@endosquid.com
http://bugs.kde.org/show_bug.cgi?id=172898





--- Comment #1 from Brendan Barry <mailinglist endosquid com>  2008-10-15 21:56:50 ---
Created an attachment (id=27921)
 --> (http://bugs.kde.org/attachment.cgi?id=27921)
Verbiage changes


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from andi.clemens@gmx.net
In reply to this post by Bugzilla from mailinglist@endosquid.com
http://bugs.kde.org/show_bug.cgi?id=172898


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
     Ever Confirmed|0                           |1




--- Comment #2 from Andi Clemens <andi clemens gmx net>  2008-10-16 01:52:31 ---
All has been merged here, but I will close your reports when everything is
committed to SVN.

Andi


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from mailinglist@endosquid.com
In reply to this post by Bugzilla from mailinglist@endosquid.com
http://bugs.kde.org/show_bug.cgi?id=172898





--- Comment #3 from Brendan Barry <mailinglist endosquid com>  2008-10-16 01:56:15 ---
Ok. Just let me know if there's anything process-wise you'd like me to change.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from andi.clemens@gmx.net
With GIT, I'm able to split your patches so I can decide what to commit and
what I want to skip now, and add / change it interactively in my branch (how
could I ever worked with SVN :-))
So when I'm finished with everything, I will post the remaining portion on the
mailinglist to check it with other devs (and you of course).

Andi


On Thursday 16 October 2008 01:56:16 Brendan Barry wrote:
> http://bugs.kde.org/show_bug.cgi?id=172898
>
>
>
>
>
> --- Comment #3 from Brendan Barry <mailinglist endosquid com>  2008-10-16
> 01:56:15 --- Ok. Just let me know if there's anything process-wise you'd
> like me to change.

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from mailinglist@endosquid.com
On Wednesday 15 October 2008, Andi Clemens wrote:
> With GIT, I'm able to split your patches so I can decide what to commit and
> what I want to skip now, and add / change it interactively in my branch
> (how could I ever worked with SVN :-))
> So when I'm finished with everything, I will post the remaining portion on
> the mailinglist to check it with other devs (and you of course).

Sounds good. Just let me know. I am going to continue hacking through the code
and smoothing things out.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

[Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Gilles Caulier-4
In reply to this post by Bugzilla from mailinglist@endosquid.com
http://bugs.kde.org/show_bug.cgi?id=172898


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Usability




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from andi.clemens@gmx.net
In reply to this post by Bugzilla from andi.clemens@gmx.net
This is a patch will all remaining hunks I'm not quite sure about.

Gilles, can you take a look at this patch?
For example in setupmime:
I think the new label is much too big for a dialog box, I don't think we need
to explain that much in there.

But if you think that everything is alright, I can merge it with my branch and
finally commit to SVN.

Andi

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

remaining.diff (10K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from andi.clemens@gmx.net
In reply to this post by Gilles Caulier-4
One more comment on the remaining patch:

welcomepageview has nested lists now. It looks nice, but the code changed a
little bit. So if this is producing any errors we might need to reset the
nested list again.

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Gilles Caulier-4
Let's me see the code in svn and the result in welcome page view.

Gilles

2008/10/16 Andi Clemens <[hidden email]>
One more comment on the remaining patch:

welcomepageview has nested lists now. It looks nice, but the code changed a
little bit. So if this is producing any errors we might need to reset the
nested list again.

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Gilles Caulier-4
In reply to this post by Bugzilla from andi.clemens@gmx.net
Agree. In setupmime.cpp, the text need to be simplified.

To be more verboze, a link to handbook can be done. As Brendan proposal to work to in Handbook (:=)))...

Gilles

2008/10/16 Andi Clemens <[hidden email]>
This is a patch will all remaining hunks I'm not quite sure about.

Gilles, can you take a look at this patch?
For example in setupmime:
I think the new label is much too big for a dialog box, I don't think we need
to explain that much in there.

But if you think that everything is alright, I can merge it with my branch and
finally commit to SVN.

Andi

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from andi.clemens@gmx.net
In reply to this post by Gilles Caulier-4
Ok, committed to SVN.
The "problem" is the usage of <ul> tags in the strings. It isn't a real
problem anyway I guess...

Andi

On Thursday 16 October 2008 13:55:57 Gilles Caulier wrote:

> Let's me see the code in svn and the result in welcome page view.
>
> Gilles
>
> 2008/10/16 Andi Clemens <[hidden email]>
>
> > One more comment on the remaining patch:
> >
> > welcomepageview has nested lists now. It looks nice, but the code changed
> > a little bit. So if this is producing any errors we might need to reset
> > the nested list again.
> >
> > Andi
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from mailinglist@endosquid.com
In reply to this post by Gilles Caulier-4
On Thursday 16 October 2008, Gilles Caulier wrote:

A link to the handbook seems like a good idea. It's just that it has to be
explained *somewhere*. I'll have to figure out why my handbook isn't there, so
I can start working on it.

> Agree. In setupmime.cpp, the text need to be simplified.
>
> To be more verboze, a link to handbook can be done. As Brendan proposal to
> work to in Handbook (:=)))...
>
> Gilles
>
> 2008/10/16 Andi Clemens <[hidden email]>
>
> > This is a patch will all remaining hunks I'm not quite sure about.
> >
> > Gilles, can you take a look at this patch?
> > For example in setupmime:
> > I think the new label is much too big for a dialog box, I don't think we
> > need
> > to explain that much in there.
> >
> > But if you think that everything is alright, I can merge it with my
> > branch and
> > finally commit to SVN.
> >
> > Andi
> >
> > _______________________________________________
> > Digikam-devel mailing list
> > [hidden email]
> > https://mail.kde.org/mailman/listinfo/digikam-devel


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from andi.clemens@gmx.net
The handbook is not in the digiKam trunk, it can be found in
branches/extragear/kde3/graphics/doc

Note that there is only a KDE3 version right now.

Andi

On Thursday 16 October 2008 15:39:11 Brendan wrote:

> On Thursday 16 October 2008, Gilles Caulier wrote:
>
> A link to the handbook seems like a good idea. It's just that it has to be
> explained *somewhere*. I'll have to figure out why my handbook isn't there,
> so I can start working on it.
>
> > Agree. In setupmime.cpp, the text need to be simplified.
> >
> > To be more verboze, a link to handbook can be done. As Brendan proposal
> > to work to in Handbook (:=)))...
> >
> > Gilles
> >
> > 2008/10/16 Andi Clemens <[hidden email]>
> >
> > > This is a patch will all remaining hunks I'm not quite sure about.
> > >
> > > Gilles, can you take a look at this patch?
> > > For example in setupmime:
> > > I think the new label is much too big for a dialog box, I don't think
> > > we need
> > > to explain that much in there.
> > >
> > > But if you think that everything is alright, I can merge it with my
> > > branch and
> > > finally commit to SVN.
> > >
> > > Andi
> > >
> > > _______________________________________________
> > > Digikam-devel mailing list
> > > [hidden email]
> > > https://mail.kde.org/mailman/listinfo/digikam-devel
>
> _______________________________________________
> Digikam-devel mailing list
> [hidden email]
> https://mail.kde.org/mailman/listinfo/digikam-devel

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from andi.clemens@gmx.net
In reply to this post by Bugzilla from andi.clemens@gmx.net
Ok, this is the final missing patch :-)
The rest is merged with my branch and will be committed later this day.
So what do you think, how can we improve those changes?

Andi


On Thursday 16 October 2008 13:23:22 Andi Clemens wrote:

> This is a patch will all remaining hunks I'm not quite sure about.
>
> Gilles, can you take a look at this patch?
> For example in setupmime:
> I think the new label is much too big for a dialog box, I don't think we
> need to explain that much in there.
>
> But if you think that everything is alright, I can merge it with my branch
> and finally commit to SVN.
>
> Andi

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

remaining.diff (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Gilles Caulier-4
No objection with this patch

Gilles

2008/10/16 Andi Clemens <[hidden email]>
Ok, this is the final missing patch :-)
The rest is merged with my branch and will be committed later this day.
So what do you think, how can we improve those changes?

Andi


On Thursday 16 October 2008 13:23:22 Andi Clemens wrote:
> This is a patch will all remaining hunks I'm not quite sure about.
>
> Gilles, can you take a look at this patch?
> For example in setupmime:
> I think the new label is much too big for a dialog box, I don't think we
> need to explain that much in there.
>
> But if you think that everything is alright, I can merge it with my branch
> and finally commit to SVN.
>
> Andi


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel



_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Bugzilla from andi.clemens@gmx.net
I think I will go with "Zoom to 100%", "Zoom to full" sounds like some kind of
fullscreen mode.

Andi

On Thursday 16 October 2008 16:14:42 Gilles Caulier wrote:
> objection

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Gilles Caulier-4
In reply to this post by Gilles Caulier-4
Andi,

Look this page for common usability over GUI:

http://wiki.openusability.org/guidelines/index.php/Appendices:Keyboard_Shortcuts

Gilles

2008/10/16 Gilles Caulier <[hidden email]>
No objection with this patch

Gilles

2008/10/16 Andi Clemens <[hidden email]>
Ok, this is the final missing patch :-)

The rest is merged with my branch and will be committed later this day.
So what do you think, how can we improve those changes?

Andi


On Thursday 16 October 2008 13:23:22 Andi Clemens wrote:
> This is a patch will all remaining hunks I'm not quite sure about.
>
> Gilles, can you take a look at this patch?
> For example in setupmime:
> I think the new label is much too big for a dialog box, I don't think we
> need to explain that much in there.
>
> But if you think that everything is alright, I can merge it with my branch
> and finally commit to SVN.
>
> Andi


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel




_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Gilles Caulier-4
for all GUI guidelines, look here :

http://wiki.openusability.org/guidelines/index.php/Main_Page

Gilles

2008/10/16 Gilles Caulier <[hidden email]>
Andi,

Look this page for common usability over GUI:

http://wiki.openusability.org/guidelines/index.php/Appendices:Keyboard_Shortcuts

Gilles

2008/10/16 Gilles Caulier <[hidden email]>

No objection with this patch

Gilles

2008/10/16 Andi Clemens <[hidden email]>
Ok, this is the final missing patch :-)

The rest is merged with my branch and will be committed later this day.
So what do you think, how can we improve those changes?

Andi


On Thursday 16 October 2008 13:23:22 Andi Clemens wrote:
> This is a patch will all remaining hunks I'm not quite sure about.
>
> Gilles, can you take a look at this patch?
> For example in setupmime:
> I think the new label is much too big for a dialog box, I don't think we
> need to explain that much in there.
>
> But if you think that everything is alright, I can merge it with my branch
> and finally commit to SVN.
>
> Andi


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel





_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
Reply | Threaded
Open this post in threaded view
|

Re: [Bug 172898] Verbiage changes for Util-ImageEditor-ImageResize.cpp

Gilles Caulier-4
Brendan,

For menu structure guidelines, look here : http://wiki.openusability.org/guidelines/index.php/Guidelines:Menus

Gilles

2008/10/16 Gilles Caulier <[hidden email]>
for all GUI guidelines, look here :

http://wiki.openusability.org/guidelines/index.php/Main_Page


Gilles

2008/10/16 Gilles Caulier <[hidden email]>
Andi,

Look this page for common usability over GUI:

http://wiki.openusability.org/guidelines/index.php/Appendices:Keyboard_Shortcuts

Gilles

2008/10/16 Gilles Caulier <[hidden email]>

No objection with this patch

Gilles

2008/10/16 Andi Clemens <[hidden email]>
Ok, this is the final missing patch :-)

The rest is merged with my branch and will be committed later this day.
So what do you think, how can we improve those changes?

Andi


On Thursday 16 October 2008 13:23:22 Andi Clemens wrote:
> This is a patch will all remaining hunks I'm not quite sure about.
>
> Gilles, can you take a look at this patch?
> For example in setupmime:
> I think the new label is much too big for a dialog box, I don't think we
> need to explain that much in there.
>
> But if you think that everything is alright, I can merge it with my branch
> and finally commit to SVN.
>
> Andi


_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel






_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel
12