[Bug 171950] New: lost pictures after 'download/delete all' when target dir had same file names

http://bugs.kde.org/show_bug.cgi?id=171950

           Summary: lost pictures after 'download/delete all' when target
                    dir had same file names
           Product: digikam
           Version: 0.9.4
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.9.4 (using 3.5.10 "release 23.1" , openSUSE )
Compiler:          Target: x86_64-suse-linux
OS:                Linux (x86_64) release 2.6.25.16-0.1-default

I lost some pictures while attempting to download them from my camera. These
were the steps I followed:

1. I selected the option 'Download/delete all' from the corresponding menu in
the Camera window.

2. I selected a folder to download the pictures. However, this folder already
contained files with the same names as those in the camera (i.e. same names but
different pictures). A window popped-up warning me of this fact, and offering
alternatives.

3. In the latter window I clicked 'Skip All', as I wanted to select a different
folder to download the pictures whose names were duplicated.

4. Thus, the pictures with the clashing names were not downloaded (and thus the
already existing files were not overwritten), which is what I was expecting -
BUT *all* the pictures in the camera were deleted. Presumably the files in the
camera were reported as downloaded when in fact they were not.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=171950


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Severity|normal                      |major
          Component|general                     |Camera GUI




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[neoclust]

https://bugs.kde.org/show_bug.cgi?id=171950


Nicolas Lécureuil <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #1 from Nicolas Lécureuil <neoclust mandriva org>  2009-04-19 01:32:22 ---
is this bug  still valid for you with digikam 0.10 ?

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=171950


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Gilles Caulier <caulier gilles gmail com>  2009-05-25 13:01:16 ---
SVN commit 972580 by cgilles:

Fix important bug in Camera gui:

- Race condition: Only show delete camera item dialog when all items are really
downloaded, to ask confirmation
- Factorize items deletion code to common method to avoid redondant
implementation.
- Only delete items which have been downloaded and not only current selection
used to perform download.
- If items are skipped during download, take a care about and do not process
deletion of.

BUG: 171950



 M  +65 -81    cameraui.cpp  
 M  +3 -0      cameraui.h  
 M  +2 -0      cameraui_p.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=972580

--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=171950


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Camera GUI                  |Import




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=171950

Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Version Fixed In|                            |1.0.0

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel