[Bug 169814] New: compilation error: no exp2()

http://bugs.kde.org/show_bug.cgi?id=169814

           Summary: compilation error: no exp2()
           Product: digikam
           Version: 0.10.0-beta2
          Platform: NetBSD pkgsrc
        OS/Version: NetBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: [hidden email]
        ReportedBy: [hidden email]


Version:           0.10.0-beta2 (using KDE 4.1.0)
Compiler:          gcc (GCC) 4.1.3 20080202 prerelease (NetBSD nb1 20080202)
OS:                NetBSD
Installed from:    NetBSD pkgsrc

digikam fails to compile on NetBSD-4.99.72/amd64, because there is no exp2()
provided by the system libraries:

[  4%] Building CXX object
digikam/CMakeFiles/digikam.dir/__/libs/dmetadata/dmet
adata.o
/scratch/digikam-kde4/work/digikam-0.10.0-beta2/libs/dmetadata/dmetadata.cpp
: In static member function 'static double
Digikam::DMetadata::apexApertureToFNu
mber(double)':
/scratch/digikam-kde4/work/digikam-0.10.0-beta2/libs/dmetadata/dmetadata.cpp
:1211: error: 'exp2' was not declared in this scope
/scratch/digikam-kde4/work/digikam-0.10.0-beta2/libs/dmetadata/dmetadata.cpp
: In static member function 'static double
Digikam::DMetadata::apexShutterSpeedT
oExposureTime(double)':
/scratch/digikam-kde4/work/digikam-0.10.0-beta2/libs/dmetadata/dmetadata.cpp
:1257: error: 'exp2' was not declared in this scope
*** Error code 1

Please use exp(log(2)*value) (or something similar) instead.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=169814





--- Comment #1 from Thomas Klausner <tk giga or at>  2008-08-25 21:26:02 ---
Created an attachment (id=27044)
 --> (http://bugs.kde.org/attachment.cgi?id=27044)
Proposed patch


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=169814


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]
          Component|general                     |Portability




--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=169814





--- Comment #2 from Andi Clemens <andi clemens gmx net>  2008-08-25 23:14:16 ---
SVN commit 852440 by aclemens:

compile

 M  +2 -2      dmetadata.cpp  


--- trunk/extragear/graphics/digikam/libs/dmetadata/dmetadata.cpp
#852439:852440
@@ -1208,7 +1208,7 @@
         return 22;
     else if (aperture == 10.0)
         return 32;
-    return exp2(aperture / 2.0);
+    return exp(log(2) * aperture / 2.0);
 }

 double DMetadata::apexShutterSpeedToExposureTime(double shutterSpeed)
@@ -1254,7 +1254,7 @@
     else if (shutterSpeed == 13.0)
         return 0.000125; // 1/8000

-    return exp2( - shutterSpeed);
+    return exp( - log(2) * shutterSpeed);
 }

 /**


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=169814


Andi Clemens andi clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #3 from Andi Clemens <andi clemens gmx net>  2008-08-25 23:14:49 ---
Please test if everything is fine for you now.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=169814





--- Comment #4 from Andi Clemens <andi clemens gmx net>  2008-09-07 15:00:53 ---
Everything alright with this commit? Can we close this?


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

http://bugs.kde.org/show_bug.cgi?id=169814


Gilles Caulier caulier gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]




--- Comment #5 from Gilles Caulier <caulier gilles gmail com>  2008-09-07 19:01:38 ---
For me the patch is fine and can be applied.

Marcel, you have implemented this code originally. Fine for you ?

Gilles


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

http://bugs.kde.org/show_bug.cgi?id=169814





--- Comment #6 from Marcel Wiesweg <marcel wiesweg gmx de>  2008-09-08 04:19:26 ---
Yes, fine for me.


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

http://bugs.kde.org/show_bug.cgi?id=169814


Thomas Klausner tk giga or at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #7 from Thomas Klausner <tk giga or at>  2008-09-08 09:53:05 ---
Since my patch was committed, I'm happy. Thanks!


--
Configure bugmail: http://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

https://bugs.kde.org/show_bug.cgi?id=169814


Gilles Caulier <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|0.10.0-beta2                |0.10.0




--
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[bugzilla_noreply]

https://bugs.kde.org/show_bug.cgi?id=169814

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Portability                 |Bundle-Tarball

--
You are receiving this mail because:
You are the assignee for the bug.