[Bug 167571] New: Unnatural order when removing images from light table

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         
           Summary: Unnatural order when removing images from light table
           Product: digikam
           Version: unspecified
          Platform: Compiled Sources
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: Light Table
        AssignedTo: digikam-devel kde org
        ReportedBy: andi.clemens gmx net


Version:           0.9.5-svn / 0.10-svn (using KDE 3.5.9)
Installed from:    Compiled From Sources
Compiler:          gcc-4.3.1 Linux (i686) release 2.6.25-ARCH
OS:                Linux

When you remove images from the light table, the order of removing them is a little bit unnatural, at least for me.

Right now removal behaves like this (codes: L = left pane, R = right pane, 1-5 image in thumbbar, * = current):

1. removal of last image:
    L1 2 3 4 R*5 => L1 R*2 3 4

2. removal of left pane image (the right pane is always assigned to the left pane)
    1 L*2 3 R4 5 => 1 L*4 R3 5

3. removal of left pane if last in thumbbar
    1 2 R3 4 L*5 => 1 2 L*3 R4

For me it feels much more natural if removing images from the thumbbar works like this:

1. removal of last image (right pane):
    L1 2 3 4 R*5 => L1 R2 3 R*4

2. removal of left pane image:
    First try to select next image to current left
    1 L*2 3 R4 5 => 1 L*3 R4 5
   
    If next is current_right, select prev.
    1 L*2 R3 4 5 => L*1 R3 4 5
    1 2 R3 4 L*5 => 1 2 R3 L*4
   
    If no next or if prev is current_right, select first image in thumbbar
    1 2 3 R4 L*5 => L*1 2 3 R4

    if no prev and next is current_right, "move" pair
    L*1 R2 3 4 5 => L*2 R3 4 5

This way the current_left and current_right pane image stay as long as possible where they are and will not be switched all the time like it is now. I'll provide a patch for this behavior. Please test it. What do you think? For me it just "feels" right in terms of usability.

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 10:46 -------
Created an attachment (id=26455)
 --> (http://bugs.kde.org/attachment.cgi?id=26455&action=view)
patch #1

This patch will also be applied to the KDE3 branch (if users like the new
behavior).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From caulier.gilles gmail com  2008-07-28 12:47 -------
Arnd,

As you have implemented old behaviour, i let's you comments the new one (:=)))...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From mikmach wp pl  2008-07-28 13:04 -------
Dnia 28-07-2008 o godz. 10:45 Andi Clemens napisa�(a):
[bugs.kde.org quoted mail]
This one OK.

> 2. removal of left pane image:
>     First try to select next image to current left
>     1 L*2 3 R4 5 => 1 L*3 R4 5


Sorry, don't have digiKam atm to test how it behaves but it should be:

1 3 L4 R*5

(for comment see below)
     
>     If next is current_right, select prev.
>     1 L*2 R3 4 5 => L*1 R3 4 5


1 L3 R*4 5
(generally moving back is last resort because with natural workflow it
was already discarded even if not completely removed)

>     1 2 R3 4 L*5 => 1 2 R3 L*4


1 2 L3 R*4
   
>     If no next or if prev is current_right, select first image in thumbbar
>     1 2 3 R4 L*5 => L*1 2 3 R4


R*1 2 3 L4

>     if no prev and next is current_right, "move" pair
>     L*1 R2 3 4 5 => L*2 R3 4 5


L2 R*3 4 5

> This way the current_left and current_right pane image stay as long as
> possible where they are and will not be switched all the time like it is
> now. I'll provide a patch for this behavior. Please test it. What do you
> think? For me it just "feels" right in terms of usability.


No. You are looking on it from "order in thumbbar" POV. But core
functionality of LT is "fight" between Master on the left and Pretender
on the right. If you are removing Master it means Pretender won and this
is new Master to which all next images will be compared. That is why R
should be default get focus.

----------------------------------------------------
Nie wiesz jak dojecha� docelu.pl ?
Poka�emy Ci adres, odleg�o��, czas przejazdu
i najbli�sz� stacj� benzynow� lub dworzec PKP.
Kliknij: http://klik.wp.pl/?adr=www.Docelu.pl&sid=432

_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 13:28 -------
OK I see your point, I really looked at it from just the thumbar POV.
The current implementation works nearly the way you mention here, but not
exactly.
I will post the current behavior under your suggestions. Maybe we can then
change it to your way of removing images.

> > 2. removal of left pane image:
> >     First try to select next image to current left
> >     1 L*2 3 R4 5 => 1 L*3 R4 5
>
> Sorry, don't have digiKam atm to test how it behaves but it should be:
>
> 1 3 L4 R*5


1 3 L*4 R5 (nearly the same)

>
> (for comment see below)
>
> >     If next is current_right, select prev.
> >     1 L*2 R3 4 5 => L*1 R3 4 5
>
> 1 L3 R*4 5


1 L*3 R4 5 (nearly the same)

> (generally moving back is last resort because with natural workflow it
> was already discarded even if not completely removed)
>
> >     1 2 R3 4 L*5 => 1 2 R3 L*4
>
> 1 2 L3 R*4


1 2 L*3 R4 (nearly the same)

>
> >     If no next or if prev is current_right, select first image in
> > thumbbar 1 2 3 R4 L*5 => L*1 2 3 R4
>
> R*1 2 3 L4


1 2 3 LR*4 (but the right pane is empty)

>
> >     if no prev and next is current_right, "move" pair
> >     L*1 R2 3 4 5 => L*2 R3 4 5
>
> L2 R*3 4 5


L*2 R3 4 5 (nearly the same)

So there is only one big difference, in the other cases only the current item
has to be defined in a different way.

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 14:33 -------
SVN commit 838662 by aclemens:

Fixed the activation of the current active panel. If the left panel item is removed, the right panel should be activated.

CCBUGS:167571

 M  +42 -40    lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=838662
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 14:48 -------
SVN commit 838669 by aclemens:

backport commit #838662 from KDE4 branch

 M  +37 -35    lighttablewindow.cpp


WebSVN link: http://websvn.kde.org/?view=rev&revision=838669
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 14:51 -------
The activation of the panel is fixed now, the only problem left is

> >
> > >     If no next or if prev is current_right, select first image in
> > > thumbbar 1 2 3 R4 L*5 => L*1 2 3 R4
> >
> > R*1 2 3 L4


> 1 2 3 LR*4 (but the right pane is empty)

Unfortunately Arnd is on holiday for the next 3 weeks, but I guess this behavior can be changed anyway, because it feels right (now that I understand the light table a bit better :-))
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 15:26 -------
SVN commit 838675 by aclemens:

If the left panel item is the last item in the thumbbar and the right panel item the second last (left to the current_left item), set the left panel item to the current_right and the right panel item to the first item of the thumbbar.

CCBUGS:167571

 M  +3 -3      lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=838675
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 15:30 -------
SVN commit 838676 by aclemens:

backport commit #838675 from KDE4 branch

CCBUGS:167571

 M  +3 -3      lighttablewindow.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=838676
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 15:32 -------
Mik,

all issues you mentioned should be fixed now. If you have the time, please test the changes (either in 0.9.5-svn or 0.10-svn).

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From mikmach wp pl  2008-07-28 18:23 -------
> I will post the current behavior under your suggestions. Maybe we can
> then change it to your way of removing images.


Well, this is not exactly "my way". As Gilles wrote Arnd implemented it
but I suggested workflow basing on extensive screencast of Adobe
Lightroom lighttable. Sorry don't remember URL, that was some time ago.

Tested 0.9 version. Everything works OK. Thanks.

Two small things could improve it further: when opening LT place first
two images in panels - 1st on the left, 2nd on the right; going through
images with PgUp/PgDown should wrap around first/last image.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 18:29 -------
> Two small things could improve it further: when opening LT place first
> two images in panels - 1st on the left, 2nd on the right; going through
> images with PgUp/PgDown should wrap around first/last image.


If you add images to the light table (F6), the first and second image already
are assigned to the panels.

With wrap around you mean if you arrive at the end of thumbbar, it should
start at the beginning again?

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From mikmach wp pl  2008-07-28 18:54 -------
> If you add images to the light table (F6), the first and second image
> already are assigned to the panels.

It doesn't happen with context menu. With keyboard shortcut it works.

> With wrap around you mean if you arrive at the end of thumbbar, it
> should start at the beginning again?

Yes.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-28 19:27 -------
> It doesn't happen with context menu. With keyboard shortcut it works.


That's because it is a different action. The context menu only appends the
images to the light table, the other action clears the light table and does
exactly what you want (both actions can be found in the main menu).

There has been a discussion why not both actions are added to the context
menu, if I was to decide they would be added but it seems that other devs
think it would bloat the context menu.

Andi
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         
mikmach wp pl changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From mikmach wp pl  2008-07-31 20:52 -------
OK. I think this bug is closed.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-07-31 20:57 -------
We could implement the wrapping... if nobody is against it :-)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From mikmach wp pl  2008-08-02 16:47 -------
> ------- We could implement the wrapping... if nobody is against it :-)

I am for it :)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From andi.clemens gmx net  2008-08-02 22:59 -------
Created an attachment (id=26584)
 --> (http://bugs.kde.org/attachment.cgi?id=26584&action=view)
wrap patch

This patch will enable the "wrapping" mentioned by Mik.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=167571         




------- Additional Comments From caulier.gilles gmail com  2008-08-02 23:01 -------
Andi,

Wrapper is fine for me.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel