[Bug 164301] New: Filter Albums sub-tree names too, when using quickfilter on icon view

[Paristo]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         
           Summary: Filter Albums sub-tree names too, when using quickfilter
                    on icon view
           Product: digikam
           Version: unspecified
          Platform: Mandriva RPMs
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: Filter
        AssignedTo: digikam-devel kde org
        ReportedBy: Paristo Gmail com


Version:            (using KDE 3.5.9)
Installed from:    Mandriva RPMs
OS:                Linux

Currently when "View > Include Albums Sub-Tree" is ON and user has main album open what includes multiple sub-albums, the icon view filter does not filter search results from album names, only from photos and tags etc.

Expand this functionality so when typing to filter path, it is going to be searched from photos and sub-albums names too.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From andi.clemens gmx net  2008-06-17 15:55 -------
Created an attachment (id=25407)
 --> (http://bugs.kde.org/attachment.cgi?id=25407&action=view)
patch #1

Gilles,

what do you think? Can we add this to the final release...? This is really a
little patch that doesn't break anything.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
      everconfirmed|0                           |1
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From caulier.gilles gmail com  2008-06-17 16:00 -------
Andi,

Agree. Go ahead.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From andi.clemens gmx net  2008-06-17 16:05 -------
Yes Sir... :-)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         
andi.clemens gmx net changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From andi.clemens gmx net  2008-06-17 16:10 -------
SVN commit 821448 by aclemens:

Album names are searched as well now when using the quickfilter.

BUG:164301

 M  +1 -0      NEWS  
 M  +4 -1      digikam/albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=821448
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From caulier.gilles gmail com  2008-06-17 16:36 -------
SVN commit 821456 by cgilles:

backport commit #821448 from KDE3 branch
CCBUGS: 164301


 M  +6 -1      albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=821456
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From caulier.gilles gmail com  2008-06-19 14:01 -------
Andi,

I have found a little problem with your patch : the album titles will be filtered only if this condition is true :

if (settings->getIconShowName())
{
}

... getIconShowName() is return true if icon item name is displayed on iconview (file name in fact). This is not related to album title.

This is want mean than album titles will be filtered only when file names are displayed on icon-view. To solve this problem you just need to move album titles filtering code outside this conditional section.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From andi.clemens gmx net  2008-06-19 14:42 -------
So the quickfilter for text search only works when the filename, caption or tags are displayed in the thumbnail item? Maybe this should be mentioned somewhere, because if you don't display those fields, the search will always fail and some users might be confused.
I don't know but do we really need to check on those special cases? Like only filter for filename if filename is also displayed?
But as for the specific problem you are right of course, I need to move this line somewhere else.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From andi.clemens gmx net  2008-06-19 14:54 -------
SVN commit 822181 by aclemens:

fixed searching for folder names

CCBUGS:164301

 M  +6 -2      albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=822181
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From caulier.gilles gmail com  2008-06-19 15:15 -------
SVN commit 822187 by cgilles:

backport commit #822181 from KDE3 branch
CCBUGS: 164301


 M  +7 -4      albumlister.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=822187
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

> So the quickfilter for text search only works when the filename, caption or tags are displayed in the thumbnail item? Maybe this should be mentioned somewhere, because if you don't display those fields, the search will always fail and some users might be confused.
> I don't know but do we really need to check on those special cases? Like only filter for filename if filename is also displayed?

I am also not sure about this. I.e. the quick filter could always
work, even if filename/caption or tag are not displayed.
Conceptually this is the difference between filtering
according to the "properties" of an image, or according
to what is displayed. Maybe the first is more natural?
(For example for more than a few tags, they are not visible anyway
due to lack of space....)

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From arnd.baecker web de  2008-06-19 15:25 -------
> So the quickfilter for text search only works when the filename, caption or tags are displayed in the thumbnail item? Maybe this should be mentioned somewhere, because if you don't display those fields, the search will always fail and some users might be confused.
> I don't know but do we really need to check on those special cases? Like only filter for filename if filename is also displayed?


I am also not sure about this. I.e. the quick filter could always
work, even if filename/caption or tag are not displayed.
Conceptually this is the difference between filtering
according to the "properties" of an image, or according
to what is displayed. Maybe the first is more natural?
(For example for more than a few tags, they are not visible anyway
due to lack of space....)

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=164301         




------- Additional Comments From andi.clemens gmx net  2008-06-19 15:34 -------
Also if displaying tags, filenames and tags all together is turned off, the quick filter for text search becomes disabled (visually). But if you don't know why this is happening, some might think this is a bug.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel