[Bug 162113] New: "set as background" does not fully escape filenames

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=162113         
           Summary: "set as background" does not fully escape filenames
           Product: digikam
           Version: 0.9.3
          Platform: Ubuntu Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: john calixto net


Version:           0.9.3 (using KDE 3.5.9)
Installed from:    Ubuntu Packages
OS:                Linux

If the path to an image file contains a single quote character ('),
digikam is not able to set it as the desktop background image.

Steps To Reproduce
------------------
- Create an album with a single quote character (') in its name, or
  add a photo with a single quote character in its name.  E.g.

    Garp's Birthday.jpg

- Try to set it as the desktop background using the "Set As
  Background" entry in the Image menu.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=162113         




------- Additional Comments From john calixto net  2008-05-15 08:01 -------
With strace, I found the following errors when trying to set the
background:

    [pid  8172] write(2, "/bin/sh: ", 9)    = 9
    [pid  8172] write(2, "Syntax error: Unterminated quote"..., 40) = 40

Further investigation with strace revealed that digikam uses dcop to
set the background image - something to the effect of:

    dcop kdesktop KBackgroundIface setWallpaper ...

I'm not sure if this is the correct place for the fix, but I found
the following code in imageviewer.cpp:

        QString com=QString("dcop kdesktop KBackgroundIface setWallpaper '%1' %2 >/dev/null 2>/dev/null")
                                .arg(m_loaded_image_url.url())

The problem seems pretty obvious from that snippet.  I'll try and
submit a patch later.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=162113         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Albums GUI
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=162113         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|digikam-devel kde org       |kde-imaging kde org
          Component|Albums GUI                  |wallpaper
            Product|digikam                     |kipiplugins
            Version|0.9.3                       |0.1.0
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel