[Bug 160966] New: some searches don't work properly with the new sqlite3-3.5.8

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From andi.clemens gmx net  2008-04-27 23:24 -------
Just one little note... I found out why I was not able to compile the SVN version: I used

./configure --prefix=/opt/kde --enable-gcc-hidden-visibility --enable-debug=full

for the beta4 tarball, but only

./configure --prefix=/opt/kde --enable-gcc-hidden-visibility

for the SVN version. If all optimizations are turned on, my laptop just "hangs"... with full debugging and no optimizations it is working...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From arnd.baecker web de  2008-04-28 06:34 -------
Andi: very interesting - which compiler version do you use ("gcc -v")?
Does the *whole* laptop hang, or just digikam on start?
(and at what place does it hang, i.e. are there any messages on the konsole?)
One of the next steps would be to use a different (=older) gcc version.
Isolating the offending part of the code will be a nice ride ... ;-)

Gilles, could this be related to problems like
http://bugs.kde.org/show_bug.cgi?id=156146 ?
(Even though that sounds a bit different  ...)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From andi.clemens gmx net  2008-04-28 07:53 -------
Hi Arnd,

like I said in #26 I'm using gcc-4.3.0.
The laptop "hangs" during the compile process, not during startup, although I'm not sure if it actually hangs or if the optimizations just take so long. But after 2 hours compiling one little CPP file I'm losing patience and normally kill the compile process. So this might not be any kind of a bug, maybe my laptop is just too old (Mobile AMD Sempron(tm) Processor 2800+, 1256MB RAM), although I'm pretty sure I once compiled digikam without "--enable-debug=full" and with full optimization...
When I wrote my diploma thesis, I also used CImg in the first place, but I never had to wait that long for gcc to finish its job.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From caulier.gilles gmail com  2008-04-28 07:55 -------
Andi,

Your report #36 is very important.

It's certainly a specific part on digiKam core which failded if no debug options is used to compile digiKam.

Note : no debug option is the same way than to not use ".configure --enable-final". This mode is used to generate final package without debug info and with full optimization.

In KDE3 with autotools, there is a macro to disable optimizations to a specific folder to compile : KDE_OPTIONS = nofinal. It's used for ex. in digikam/libs/jpegutils/Makefile.am with transupp.cpp code which do not support compilation optimizations.

I recommend you to make investiguations where code failed exactly. Certainly in DB interface which is mixed indeep in digikam/digikam folder with GUI (code is separated in KDE4). Just place the KDE macro to the digikam/digikam/Makefile.am and check if it work...

Arnd,

yes, i suspect than #156146 has the same problem.

Marcel, if you have any tips here...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From caulier.gilles gmail com  2008-04-28 08:03 -------
Andi,

If last CImg 1.2.8 included in digiKam core recently do not compile fine for you, it certainly a problem in CImg implementation. I will contact David Tschumperlé (CImg author).

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From andi.clemens gmx net  2008-06-01 00:53 -------
I think sqlite3-3.5.9 has this problem solved, at least the developers say so in the bugreport (posted by Arnd). I will try to get the newest version to check if the problem is still there.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From andi.clemens gmx net  2008-06-01 00:59 -------
Oh this was a quick compile :-)
Yes, I can confirm that sqlite3-3.5.9 solved the problem, so I guess there is nothing we can do about this problem. Hopefully most distributions will update their packages soon.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From caulier.gilles gmail com  2008-06-01 08:58 -------
Andi,

we must update all Sqlite version depencies everywhere :

- README file (KDE3 and KDE4)
- .configure.in.in (KDE3)
- .configure.in.bot (KDE3)
- CMakeList.txt (KDE4)

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2008-06-01 12:30 -------
SVN commit 815139 by cgilles:

digiKam from KDE3 branch : fix libsqlite depency >= 3.5.9 release
BUGS: 160966


 M  +2 -2      README  
 M  +44 -27    configure.in.bot  
 M  +1 -1      configure.in.in  


WebSVN link: http://websvn.kde.org/?view=rev&revision=815139
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From caulier.gilles gmail com  2008-06-01 14:44 -------
SVN commit 815218 by cgilles:

digiKAm from KDE3 branch : sqlite 3.5.9 code source inclusion to digiKam core.
duing a wrong package config provided in sqlite3 package, it's impossible to find the right version installed on computer.
Including sqlite3 directly on digiKam will solve this problem, prevents all future bug reports, and reduce depencies.
CCBUGS: 160966


 M  +1 -1      NEWS  
 M  +0 -1      README  
 M  +0 -13     configure.in.bot  
 M  +0 -20     configure.in.in  
 M  +2 -1      digikam/Makefile.am  
 M  +1 -1      digikam/albumdb.cpp  
 M  +4 -4      kioslave/Makefile.am  
 M  +1 -1      kioslave/sqlitedb.cpp  
 M  +1 -1      libs/Makefile.am  
 A             libs/sqlite3 (directory)  
 A             libs/sqlite3/Makefile.am  
 AM            libs/sqlite3/sqlite3.c   [POSSIBLY UNSAFE: system,gets] [License: GENERATED FILE]
 AM            libs/sqlite3/sqlite3.h   [POSSIBLY UNSAFE: system] [License: GENERATED FILE]


WebSVN link: http://websvn.kde.org/?view=rev&revision=815218
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From marcel.wiesweg gmx de  2008-06-01 15:46 -------
For the KDE4 version we are using the QtSql plugin for SQLite, and do not directly link to libsqlite3. Qt packages its own libsqlite3 (as you did above) or uses the libsqlite3 available on the system, depending on configure options.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From caulier.gilles gmail com  2008-06-01 19:07 -------
Marcel,

To be sure to not have a side effect in KDE4 port, i will backport sqlite 3.5.9 code from KDE3. The advantage is to remove sqlite3 external depencies.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From caulier.gilles gmail com  2008-06-01 19:25 -------
SVN commit 815399 by cgilles:

digiKam from trunk : removing external SQLite shared lib depency
CCBUGS: 160966


 M  +4 -15     CMakeLists.txt  
 M  +1 -2      README  
 M  +1 -0      digikam/CMakeLists.txt  
 M  +1 -1      libs/database/backendsqlite3.cpp  
 A             libs/database/sqlite3 (directory)  
 AM            libs/database/sqlite3/sqlite3.c   [POSSIBLY UNSAFE: system,gets] [License: GENERATED FILE]
 AM            libs/database/sqlite3/sqlite3.h   [POSSIBLY UNSAFE: system] [License: GENERATED FILE]
 M  +4 -2      project/project.kdevelop  


WebSVN link: http://websvn.kde.org/?view=rev&revision=815399
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Rex Dieter]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         
rdieter math unl edu changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rdieter math unl edu
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From ach mpe mpg de  2008-06-18 19:20 -------
Only IMHO: Nahh,  I'll never buy this argument~! Sorry :(

  digiKam from trunk : removing external SQLite shared lib depency
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From current myrealbox com  2008-06-18 19:39 -------
> duing a wrong package config provided in sqlite3 package, it's impossible to find the right version installed on computer.
Including sqlite3 directly on digiKam will solve this problem, prevents all future bug reports, and reduce depencies.


From a distributors perspective this is just wrong. We don't want to pester our users with multiple sqlite engines and we want to issue a single security announcement for sqlite in case of a vulnerability and not for multiple packages. By including libraries instead using shared ones, you increase the memory usage on systems holding mutliple copies of the engine in memory and increase distributors workload. Thanks, no.
 
Simply adding a notice to your release notes, which sqlite engine is fine to use would be just fine.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         
jkt gentoo org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jkt gentoo org
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |



------- Additional Comments From jkt gentoo org  2008-06-18 22:23 -------
I have to agree with #50. While this might fix an issue brought in in a recent sqlite update, it is going to cause massive headache to both packagers and users and in long term just bring in more trouble. Please consider reverting this particular change.

Reopening for proper discussion, feel free to close, it's your bug and your code after all.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From arnd.baecker web de  2008-06-18 22:41 -------
Jan, the real solution would be to figure out a way so that during
configuration of digikam  (sqlite<3.5.8 or sqlite >3.5.8) is ensured.
Gilles has tried very hard (see the discussion on the mailing list)
to achieve this with autotools, but nothing worked out.
So if you or anyone else provides a patch for this, I am optimistic
that it can be integrated ...

Best, Arnd
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From jkt gentoo org  2008-06-18 22:56 -------
Considering that the affected version of sqlite has been available for "just one month" and that most distributions that went ahead and bumped their version to 3.5.8 are likely to ship 3.5.9 in a timely fashion, I'd just ommit the check altogether. Bugs happen all the time and including a known-to-be-safe version in the name of "reducing dependencies" is a way to hell.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=160966         




------- Additional Comments From arnd.baecker web de  2008-06-18 23:08 -------
I don't see how this is a way to hell, there are surely much worse sins ...

There were already several users reporting problems which were caused by this particular sqlite issue, however finding the real cause in each of these
causes did take some time; also many users might not report such an
issue and just discard digikam ("it is just too slow ...").
This is why this sqlite was included.
Still, IMO the proper solution is the version check.
Jan, do you have an idea how to do that?

Actually, another (less optimal) option might
be a runtime check of the used sqlite and prevent digikam from starting
with 3.5.8. What do you think Gilles?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel