[Bug 154941] New: Improve exception safety with smart pointers

[Markus Elfring]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154941         
           Summary: Improve exception safety with smart pointers
           Product: digikam
           Version: unspecified
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: Markus.Elfring web de


Version:           0.9.3 (using KDE KDE 3.5.7)
OS:                Linux

Would you like to wrap pointer data members with the template class "std::auto_ptr"?
http://en.wikipedia.org/wiki/Auto_ptr
http://websvn.kde.org/trunk/extragear/graphics/digikam/digikam/albumfiletip.cpp?revision=750485&view=markup
http://websvn.kde.org/trunk/extragear/graphics/digikam/digikam/albumhistory.cpp?revision=729732&view=markup
http://websvn.kde.org/trunk/extragear/graphics/digikam/digikam/cameratype.cpp?revision=687121&view=markup
http://websvn.kde.org/trunk/extragear/graphics/digikam/themedesigner/mainwindow.cpp?revision=719640&view=markup
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154941         




------- Additional Comments From caulier.gilles gmail com  2008-01-01 21:28 -------
Markus,

Are you talking about data pointer used in 'd' private container class ?

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Markus Elfring]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154941         




------- Additional Comments From Markus.Elfring web de  2008-01-04 20:22 -------
Yes ...
I see the following attributes as candidates for encapsulation.
- d
- m_backwardStack
- m_forwardStack

Will window objects delete themselves?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154941         




------- Additional Comments From caulier.gilles gmail com  2008-01-04 21:40 -------
yes Qt object are deleted automaticly by Qt lib (like Java do).

d container is deleted in destructor of main class...

So no need to manage anymore. Valgrind do not report any memory leak here...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Markus Elfring]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154941         




------- Additional Comments From Markus.Elfring web de  2008-01-04 22:13 -------
I doubt that the first AlbumStack object will be properly deleted if the second allocation will throw an exception in the AlbumHistory constructor.

How do you think about the chance to omit explicit delete instructions?
http://www.gotw.ca/publications/using_auto_ptr_effectively.htm
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154941         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcel.wiesweg gmx de



------- Additional Comments From caulier.gilles gmail com  2008-03-18 12:46 -------
Marcel,

What do you think about this entry. It's still valid ?

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Marcel Wiesweg]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154941         




------- Additional Comments From marcel.wiesweg gmx de  2008-03-18 17:58 -------
I think it's KDE style to rely on QObject mechanims for auto-deletion.
We dont use exceptions (or catch them from libexiv2), so we won't throw any in constructors.
Other than that, I am not familiar with std::auto_ptr
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=154941         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |WORKSFORME



------- Additional Comments From caulier.gilles gmail com  2008-03-18 18:04 -------
I'm agree with you Marcel. So i close this file...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel