[Bug 153070] New: search for image by geo location

[Christian Weiske]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
           Summary: search for image by geo location
           Product: digikam
           Version: 0.9.2
          Platform: Gentoo Packages
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: wishlist
          Priority: NOR
         Component: general
        AssignedTo: digikam-devel kde org
        ReportedBy: cweiske cweiske de


Version:           0.9.2 (using KDE KDE 3.5.7)
Installed from:    Gentoo Packages
OS:                Linux

Digikam supports geotagging photos, which is great - but unfortunately, there is no way to make use of this location information.

KDE 4 brings Marble (http://edu.kde.org/marble/), a desktop globe widget that can be embedded into other applications.

What I wish is that geotagged photos are displayed/marked as dots on the globe, so you can search specifically for images taken at a certain location/area. I imagine the desktop globe to be a similar "tab" like the current folder tree or the tag search. All images that are currently visible on the globe should be shown in the image list. The more you zoom into the globe (and thus restrict the area), the fewer photos are shown.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|general                     |Searches



------- Additional Comments From caulier.gilles gmail com  2007-11-28 19:08 -------
Chistian,

This feature is planed with KDE4 port of digiKam...

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From caulier.gilles gmail com  2008-06-04 21:51 -------
SVN commit 816774 by cgilles:

digiKam from trunk (KDE4) : I'm happy to said than a new powerfull Search tool is available in digiKam : Searches over a map !

This tool use Marble widget from trunk with a patch from me to perform a rectangle selection on the canvas. Thepatch is available at this url:

http://digikam3rdparty.free.fr/misc.tarballs/marbleselection.patch

When you make a selection, digiKam query the database to find all pictures which have been taken into this area.

There is a screenshot of this tool in action at this url:

http://digikam3rdparty.free.fr/Screenshots/NewSearchTools/mapsearchtool.png

Several improvments need to be done in marble to have a more suitable selection tool, but at least it work fine as well.

CCMAIL: marcel.wiesweg gmx de
CCMAIL: digikam-users kde org
CCMAIL: tackat kde org

BUGS: 153070




 M  +6 -8      gpssearchview.cpp  
 M  +6 -6      gpssearchwidget.cpp  
 M  +3 -3      gpssearchwidget.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=816774
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From tackat kde org  2008-06-04 22:48 -------
Nice start, but the code in question doesn't work as advertized and can't get committed to SVN like this and needs some improvement before it gets applied:

1.) Most obvious problem is that the method

void MarbleWidget::setSelection(const QRect& region)

completely ignores the current projection when defining the "corners" of the
bounding box. The suggested method works fine for the example Iceland. But if you select a larger area closer to the poles in globe projection you might realize that the suggested way to create a latLonBoundingBox doesn't work.

The correct solution would make use of

virtual GeoDataLatLonAltBox AbstractProjection::latLonAltBox( const QRect& screenRect, const ViewportParams *viewport );

Please have a look at the implementation of

GeoDataLatLonAltBox ViewportParams::viewLatLonAltBox() const

as an example. The viewLatLonAltBox returns a GeoDataLatLonBox for the current view.

This is an important issue that needs to get fixed before this patch can be committed to SVN.

2.) I'm not sure whether it's a good solution to make a Rubberband the property of a MarbleWidgetInputHandler. Shouldn't this be a property of the view?
I also have concerns about the performance of the painting of the rubberband. Does it work well for you? IIRC due to technical/conceptual limits Marble needs to repaint the whole screen at least for some backends even if there's just a dirtyRect changed ( e.g. due to the calculation of labels not overlapping which needs to take into account the whole screen ) .

3.) I'm not sure whether the introduction of a boolean for the selectionMode is a good solution. I guess in the future we'll have many different "input modes" and I wonder whether having a boolean for each of them would be a proper solution.

I like the screenshot :-)

Torsten
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
tackat kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |UNCONFIRMED
         Resolution|FIXED                       |



------- Additional Comments From tackat kde org  2008-06-04 22:55 -------
Oh and please use GeoDataLatLon(Alt)Box as much as possible when improving the patch. :-)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From caulier.gilles gmail com  2008-06-04 23:36 -------
Created an attachment (id=25128)
 --> (http://bugs.kde.org/attachment.cgi?id=25128&action=view)
patch version 2

new version of patch for marble. point 1/ fixed.

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tackat kde org
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From tackat kde org  2008-06-05 08:12 -------
Hi,

When dealing with latitude longitude bounding boxes please make sure in the application on your end that you also properly deal with the International Date Line (IDL): You are emitting the bounding box ranges as "coordinates" (I see the need to create plain double types from the GeoDataLatLonAltBox however I wonder whether there's a better solution instead of emitting the "coordinates" in a list).

You might run into a problem in your application if you expect the "western" value to be always to the left of the "eastern" value: on the -180 - 180 longitude range the western value can actually be to the right of the eastern bounding box range. In that case you have to treat the single bounding box like TWO split bounding boxes which range from the western value to the 180 deg longitude and from the -180 deg longitude to the eastern value.

This is a problem that is inherent with the concept of latitude longitude bounding boxes and it's not Marble specific and it happens with all projections.

If you don't take this issue into account then you'll get everything outside the bounding box selected if the bounding box covers the IDL ( of course still within proper latitude ranges, but I fear that doesn't help ).
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25128|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-06-05 08:19 -------
Created an attachment (id=25131)
 --> (http://bugs.kde.org/attachment.cgi?id=25131&action=view)
patch version 3

This version KML import as string code which is another issue...
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From caulier.gilles gmail com  2008-06-05 08:50 -------
Torsten,

About point #2, here QRubberBand performance drawing are fine here (Qt 4.3.3).

I use this widget in digiKam without problem.

Of course we can use the view instance to host this widget. We will take a look later after to fix point #1

About #3 : yes, this can be optimized. In fact MarbleWidgetInputHandler code need to be fully re-writted...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |marcel.wiesweg gmx de



------- Additional Comments From caulier.gilles gmail com  2008-06-05 08:55 -------
Marcel,

About #6 from Torsten, let's me hear if IDL stuff can be a problem in database interface to perform map search.

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From tackat kde org  2008-06-05 09:07 -------
Ok, sorry if it looks a bit like nitpicking but selections are really something that I'd like to see well-done right from the start.

I'd like to have the signal you're emitting changed a bit:

Currently it's called "newSelection" which uses the C++ keywords "new" and doesn't stick to the Qt naming scheme of things. What about naming the signal

void regionSelected( QList<double> coords )

or emitting simply a

void selectionChanged()

and letting the application retrieve through another method "QList<double> selection() const" what area is actually selected.

BTW: how does your method cover deselection?


> About point #2, here QRubberBand performance drawing are fine here (Qt 4.3.3).

Great :-) Just wanted to have feedback whether it works fine. So forget about it.
 
> About #3 : yes, this can be optimized. In fact
> MarbleWidgetInputHandler code need to be fully re-writted...

Yes, this is known but I haven't had the time to take care of it. Do you have any suggestions how MarbleWidgetInputHandler should look like in the future and what would you like to see changed about it?
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From caulier.gilles gmail com  2008-06-05 09:57 -------
>Yes, this is known but I haven't had the time to take care of it. Do you have any >suggestions how MarbleWidgetInputHandler should look like in the future and what >would you like to see changed about it?

1/ In first, the code structure can still the same but the coding style need to be polished. It's really hard to read code. A lots of comments need to be added, and bracketing fixed.

2/ The section witch handle keyboard do not use Qt keys definition. All is hardcoded without any comments... It's can be not portable (in the case of key definition can be differents in others OS)

I can do point #1

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25131|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-06-05 10:04 -------
Created an attachment (id=25132)
 --> (http://bugs.kde.org/attachment.cgi?id=25132&action=view)
patch version 4

Fix signal name emit by marble widget.
Fix selection behaviours when region is outside active map.
Remove bool flags about section status.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From tackat kde org  2008-06-05 11:01 -------
> I can do point #1

Yes, that would be great.
I think I've done #2 with Revision 817093
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         
caulier.gilles gmail com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #25132|0                           |1
        is obsolete|                            |



------- Additional Comments From caulier.gilles gmail com  2008-06-05 14:42 -------
Created an attachment (id=25137)
 --> (http://bugs.kde.org/attachment.cgi?id=25137&action=view)
patch version 5

compile with last changes from svn
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From tackat kde org  2008-06-05 15:37 -------
I wonder whether we shouldn't go for this API for selections which is derived from the API from QGraphicsItem and which seems to cover all cases I can think of at the moment:

void MarbleWidget::setSelectionArea ( GeoDataLatLonAltBox latLonAltBox );
void MarbleWidget::setSelectionArea ( double west, double east, double north, double south );

GeoDataLatLonAltBox MarbleWidget::selectionArea () const
void MarbleWidget::selectionArea ( double &west, double &east, double &north, double &south );

QList<GeoDataObjects *> MarbleWidget::selectedItems () const

void MarbleWidget::selectionChanged ()   [signal]

Do you think this makes sense and do you think that you can change the Digikam code accordingly? :-)
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From caulier.gilles gmail com  2008-06-05 17:28 -------
Torsten,

I'm fully agree with your api. changing digiKam code is not a problem (:=))) go ahead...

Gilles
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Gilles Caulier-4]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=153070         




------- Additional Comments From caulier.gilles gmail com  2008-06-06 07:52 -------
A video of map search tool in action is available at this url:

http://digikam3rdparty.free.fr/TourMovies/mapsearchdemo.ogv

Gilles Caulier
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel

[Arnd Baecker]

This is really really great!

I think it would be useful to display the the location of all
found images as small yellow dots in the right world view and use
(e.g.) a red mark for the currently selected image.
Clicking on a dot should make that image the current one.
(What is not obvious: if there are many dots at essentially the same
point, which should be chosen? Google earth has a pretty good
solution of displaying all the possibilities as a cloud around the
chosen point.
However, I am not sure if something like this is possible with marble...)

Another nice thing would be mini-thumbnails as mouse-overs
over a dot. This could be realized using appropriate kml code
in which the (already generated) thumbnail of the image displayed
in a much smaller version.
_______________________________________________
Digikam-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/digikam-devel